You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/24 18:06:39 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #5724: Use consistent arrow version
tustvold opened a new pull request, #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This is the quick fix for https://github.com/apache/arrow-datafusion/pull/5603/files#r1147905129
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5724: Use consistent arrow version
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#discussion_r1147927968
##########
datafusion/common/Cargo.toml:
##########
@@ -40,13 +40,13 @@ pyarrow = ["pyo3", "arrow/pyarrow"]
[dependencies]
apache-avro = { version = "0.14", default-features = false, features = ["snappy"], optional = true }
-arrow = { workspace = true, default-features = false }
-arrow-array = { version = "35.0.0", default-features = false, features = ["chrono-tz"] }
+arrow = { workspace = true }
+arrow-array = { workspace = true }
chrono = { version = "0.4", default-features = false }
cranelift-module = { version = "0.92.0", optional = true }
num_cpus = "1.13.0"
object_store = { version = "0.5.4", default-features = false, optional = true }
-parquet = { workspace = true, default-features = false, optional = true }
+parquet = { workspace = true, optional = true }
Review Comment:
default-features on a workspace dependency doesn't do anything see https://github.com/apache/arrow-datafusion/issues/5667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5724: Use consistent arrow version
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#discussion_r1147932414
##########
datafusion/common/Cargo.toml:
##########
@@ -40,13 +40,13 @@ pyarrow = ["pyo3", "arrow/pyarrow"]
[dependencies]
apache-avro = { version = "0.14", default-features = false, features = ["snappy"], optional = true }
-arrow = { workspace = true, default-features = false }
-arrow-array = { version = "35.0.0", default-features = false, features = ["chrono-tz"] }
+arrow = { workspace = true }
+arrow-array = { workspace = true }
chrono = { version = "0.4", default-features = false }
cranelift-module = { version = "0.92.0", optional = true }
num_cpus = "1.13.0"
object_store = { version = "0.5.4", default-features = false, optional = true }
-parquet = { workspace = true, default-features = false, optional = true }
+parquet = { workspace = true, optional = true }
Review Comment:
The tests need to be updated because https://github.com/apache/arrow-datafusion/pull/5603 enabled chrono-tz, but because it was linking in arrow-array 35, this didn't percolate to other crates that are still using arrow-array 34.
This doesn't change the behaviour of default-features for parquet, this has been "broken" since the move to workspace dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5724: Use consistent arrow version
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#discussion_r1147929875
##########
datafusion-examples/Cargo.toml:
##########
@@ -36,7 +36,7 @@ required-features = ["datafusion/avro"]
[dev-dependencies]
arrow = { workspace = true }
-arrow-flight = { version = "34.0.0", features = ["flight-sql-experimental"] }
+arrow-flight = { workspace = true }
Review Comment:
👍
##########
datafusion/common/Cargo.toml:
##########
@@ -40,13 +40,13 @@ pyarrow = ["pyo3", "arrow/pyarrow"]
[dependencies]
apache-avro = { version = "0.14", default-features = false, features = ["snappy"], optional = true }
-arrow = { workspace = true, default-features = false }
-arrow-array = { version = "35.0.0", default-features = false, features = ["chrono-tz"] }
+arrow = { workspace = true }
+arrow-array = { workspace = true }
chrono = { version = "0.4", default-features = false }
cranelift-module = { version = "0.92.0", optional = true }
num_cpus = "1.13.0"
object_store = { version = "0.5.4", default-features = false, optional = true }
-parquet = { workspace = true, default-features = false, optional = true }
+parquet = { workspace = true, optional = true }
Review Comment:
So this means we lose coverage of the non default feature path (which is why the tests need to be updated?)
##########
datafusion/core/tests/sql/set_variable.rs:
##########
@@ -440,7 +443,10 @@ async fn set_time_zone_bad_time_zone_format() {
.unwrap();
let err = pretty_format_batches(&result).err().unwrap().to_string();
- assert_eq!(err, "Parser error: Invalid timezone \"08\": only offset based timezones supported without chrono-tz feature");
+ assert_eq!(
+ err,
+ "Parser error: Invalid timezone \"08\": '08' is not a valid timezone"
+ );
// we dont support named time zone yet
Review Comment:
comment looks out of date now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5724: Use consistent arrow version
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#discussion_r1147927968
##########
datafusion/common/Cargo.toml:
##########
@@ -40,13 +40,13 @@ pyarrow = ["pyo3", "arrow/pyarrow"]
[dependencies]
apache-avro = { version = "0.14", default-features = false, features = ["snappy"], optional = true }
-arrow = { workspace = true, default-features = false }
-arrow-array = { version = "35.0.0", default-features = false, features = ["chrono-tz"] }
+arrow = { workspace = true }
+arrow-array = { workspace = true }
chrono = { version = "0.4", default-features = false }
cranelift-module = { version = "0.92.0", optional = true }
num_cpus = "1.13.0"
object_store = { version = "0.5.4", default-features = false, optional = true }
-parquet = { workspace = true, default-features = false, optional = true }
+parquet = { workspace = true, optional = true }
Review Comment:
default-features doesn't do anything see https://github.com/apache/arrow-datafusion/issues/5667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5724: Use consistent arrow version
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ozankabak commented on pull request #5724: Use consistent arrow version
Posted by "ozankabak (via GitHub)" <gi...@apache.org>.
ozankabak commented on PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#issuecomment-1483414964
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5724: Use consistent arrow version
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#discussion_r1147932414
##########
datafusion/common/Cargo.toml:
##########
@@ -40,13 +40,13 @@ pyarrow = ["pyo3", "arrow/pyarrow"]
[dependencies]
apache-avro = { version = "0.14", default-features = false, features = ["snappy"], optional = true }
-arrow = { workspace = true, default-features = false }
-arrow-array = { version = "35.0.0", default-features = false, features = ["chrono-tz"] }
+arrow = { workspace = true }
+arrow-array = { workspace = true }
chrono = { version = "0.4", default-features = false }
cranelift-module = { version = "0.92.0", optional = true }
num_cpus = "1.13.0"
object_store = { version = "0.5.4", default-features = false, optional = true }
-parquet = { workspace = true, default-features = false, optional = true }
+parquet = { workspace = true, optional = true }
Review Comment:
The tests need to be updated because https://github.com/apache/arrow-datafusion/pull/5603 enabled chrono-tz, but because it was linking in arrow-array 35, this didn't percolate to other crates that are still using arrow-array 34.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5724: Use consistent arrow version
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#discussion_r1147929739
##########
datafusion/core/tests/sql/set_variable.rs:
##########
@@ -427,7 +427,10 @@ async fn set_time_zone_bad_time_zone_format() {
.unwrap();
let err = pretty_format_batches(&result).err().unwrap().to_string();
- assert_eq!(err, "Parser error: Invalid timezone \"08:00\": only offset based timezones supported without chrono-tz feature");
+ assert_eq!(
Review Comment:
These changes are because the chrono-tz feature is now enabled for the common arrow version
This feature was enabled in https://github.com/apache/arrow-datafusion/pull/5603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5724: Use consistent arrow version
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#discussion_r1147932414
##########
datafusion/common/Cargo.toml:
##########
@@ -40,13 +40,13 @@ pyarrow = ["pyo3", "arrow/pyarrow"]
[dependencies]
apache-avro = { version = "0.14", default-features = false, features = ["snappy"], optional = true }
-arrow = { workspace = true, default-features = false }
-arrow-array = { version = "35.0.0", default-features = false, features = ["chrono-tz"] }
+arrow = { workspace = true }
+arrow-array = { workspace = true }
chrono = { version = "0.4", default-features = false }
cranelift-module = { version = "0.92.0", optional = true }
num_cpus = "1.13.0"
object_store = { version = "0.5.4", default-features = false, optional = true }
-parquet = { workspace = true, default-features = false, optional = true }
+parquet = { workspace = true, optional = true }
Review Comment:
The tests need to be updated because https://github.com/apache/arrow-datafusion/pull/5603 enabled chrono-tz, but because it was linking in arrow-array 35, this didn't percolate to other crates that are still using arrow-array 34.
This doesn't change the behaviour of default-features for parquet, this has been "broken" since the move to workspace dependencies
See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace
> Other than optional and features, inherited dependencies cannot use any other dependency key (such as version or default-features).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5724: Use consistent arrow version
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5724:
URL: https://github.com/apache/arrow-datafusion/pull/5724#discussion_r1147932414
##########
datafusion/common/Cargo.toml:
##########
@@ -40,13 +40,13 @@ pyarrow = ["pyo3", "arrow/pyarrow"]
[dependencies]
apache-avro = { version = "0.14", default-features = false, features = ["snappy"], optional = true }
-arrow = { workspace = true, default-features = false }
-arrow-array = { version = "35.0.0", default-features = false, features = ["chrono-tz"] }
+arrow = { workspace = true }
+arrow-array = { workspace = true }
chrono = { version = "0.4", default-features = false }
cranelift-module = { version = "0.92.0", optional = true }
num_cpus = "1.13.0"
object_store = { version = "0.5.4", default-features = false, optional = true }
-parquet = { workspace = true, default-features = false, optional = true }
+parquet = { workspace = true, optional = true }
Review Comment:
The tests need to be updated because https://github.com/apache/arrow-datafusion/pull/5603 enabled chrono-tz, but because it was linking in arrow-array 35, this didn't percolate to other crates that are still using arrow-array 34.
This doesn't change the behaviour of default-features for parquet, this has been "broken" since the move to workspace dependencies
See https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org