You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/22 16:27:47 UTC

[GitHub] [beam] chrlarsen commented on a change in pull request #13572: [BEAM-11482] Thrift support for KafkaTableProvider

chrlarsen commented on a change in pull request #13572:
URL: https://github.com/apache/beam/pull/13572#discussion_r547374291



##########
File path: sdks/java/io/thrift/src/main/java/org/apache/beam/sdk/io/thrift/ThriftCoder.java
##########
@@ -72,15 +71,13 @@ protected ThriftCoder(Class<T> type, TProtocolFactory protocolFactory) {
    */
   @Override
   public void encode(T value, OutputStream outStream) throws CoderException, IOException {
-    ByteArrayOutputStream baos = new ByteArrayOutputStream();
-    TProtocol protocol = protocolFactory.getProtocol(new TIOStreamTransport(baos));
+    TProtocol protocol = protocolFactory.getProtocol(new TIOStreamTransport(outStream));

Review comment:
       LGTM. I think this was an artifact from earlier development. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org