You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/18 01:06:25 UTC
[GitHub] williaster commented on issue #5662: Minor improvements to SQL Lab
UI
williaster commented on issue #5662: Minor improvements to SQL Lab UI
URL: https://github.com/apache/incubator-superset/pull/5662#issuecomment-414021338
These look great! 🙌
I'll 👀 more closely, my only high-level thought for now is about the "See table Schema" change. I thiiiink if you don't add a table, you can't actually query it in the SQL lab editor which is why it was labeled "add table". If that's true I wonder if "add table to workspace" or something would be a better label? Just a thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org