You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "AlbumenJ (via GitHub)" <gi...@apache.org> on 2024/03/20 03:13:07 UTC
[I] [Feature] Update FileTest in 3.3 [dubbo]
AlbumenJ opened a new issue, #13961:
URL: https://github.com/apache/dubbo/issues/13961
### Pre-check
- [X] I am sure that all the content I provide is in English.
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar feature requirement.
### Apache Dubbo Component
Java SDK (apache/dubbo)
### Descriptions
Update `org.apache.dubbo.dependency.FileTest` in 3.3 to support check `dubbo-all-shaded` and `dubbo-core-spi`
### Related issues
_No response_
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Update FileTest in 3.3 [dubbo]
Posted by "CrazyHZM (via GitHub)" <gi...@apache.org>.
CrazyHZM closed issue #13961: [Feature] Update FileTest in 3.3
URL: https://github.com/apache/dubbo/issues/13961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Update FileTest in 3.3 [dubbo]
Posted by "Stellar1999 (via GitHub)" <gi...@apache.org>.
Stellar1999 commented on issue #13961:
URL: https://github.com/apache/dubbo/issues/13961#issuecomment-2011312608
"I would like to try to do this. Can you assign it to me? Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Update FileTest in 3.3 [dubbo]
Posted by "Stellar1999 (via GitHub)" <gi...@apache.org>.
Stellar1999 commented on issue #13961:
URL: https://github.com/apache/dubbo/issues/13961#issuecomment-2017491953
> I would like to try to do this. Can you assign it to me? Thanks~ I think I should remove them from the ignored list and add them to the dependencies pom, which will check them.
> @AlbumenJ This can describe the content of the specific need to check what it is. This PR (#13978) does not understand what needs to be done.
Sorry for that. I think I actually didn't understand. As I said, I think `dubbo-all-shaded` and `dubbo-core-spi` are new modules that need to be checked. Now, when @CrazyHZM reninded it, I think they should have their own checks like `dubbo-all` and `dubbo-bom`. This time, do I understand correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Update FileTest in 3.3 [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13961:
URL: https://github.com/apache/dubbo/issues/13961#issuecomment-2020160688
Update `checkDubboAllTransform` in `FileTest` to check `dubbo-all-shaded` and `dubbo-core-spi`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Update FileTest in 3.3 [dubbo]
Posted by "Stellar1999 (via GitHub)" <gi...@apache.org>.
Stellar1999 commented on issue #13961:
URL: https://github.com/apache/dubbo/issues/13961#issuecomment-2019334877
Another question, what is the positioning of `core-spi` and `all-shaded`? Are they gradually replacing the SPI and includes in `dubbo-all` using the Maven Shade Plugin? I think `dubbo-all-shaded` should imply this, but `dubbo-core-spi` hasn't been updated for a long time. I'm not sure whether it should only check the included SPI or all SPI. Should I also update the SPI dependencies in pom?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Update FileTest in 3.3 [dubbo]
Posted by "CrazyHZM (via GitHub)" <gi...@apache.org>.
CrazyHZM commented on issue #13961:
URL: https://github.com/apache/dubbo/issues/13961#issuecomment-2017337706
@AlbumenJ This can describe the content of the specific need to check what it is.
This PR (https://github.com/apache/dubbo/pull/13978) does not understand what needs to be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org