[GitHub] [cassandra-website] ErickRamirezAU commented on a diff in pull request #208: CASSANDRA-18244 Improve documentation about releases for Cassandra website

["ErickRamirezAU (via GitHub)" <gi...@apache.org>]

ErickRamirezAU commented on code in PR #208:
URL: https://github.com/apache/cassandra-website/pull/208#discussion_r1101019805


##########
site-content/source/modules/ROOT/pages/development/release_process.adoc:
##########
@@ -63,19 +65,92 @@ the ASF nexus staging repository and dev distribution location:
 cd ~/git
 git clone https://github.com/apache/cassandra-builds.git
 git clone https://github.com/apache/cassandra.git
+----
 
+[source,none]
+----
 # Edit the variables at the top of the `prepare_release.sh` file
 edit cassandra-builds/cassandra-release/prepare_release.sh
+----
+
+You must specify your ASF username to `asf_username` variable. Next, `gpg_key` environment variable must be 
+set to a fingerprint of your gpg key. Execute `gpg --list-keys` or a similar command to get the value. Finally, you must
+add ASF remote to your cloned repository and `git_asf_remote` variable needs to be set to point to that. For example, when this command is executed:
+
+[source,none]
+----
+git remote add asf https://gitbox.apache.org/repos/asf/cassandra.git
+----
 
+then `git_asf_remote` variable needs to be set to `asf`. 
+NOTE: This is very important step as tags are pushed to ASF repository and they are synchronized to GitHub automatically.
+
+[source,none]
+----
 # Ensure your 4096 RSA key is the default secret key
 edit ~/.gnupg/gpg.conf # update the `default-key` line
-edit ~/.rpmmacros # update the `%gpg_name <key_id>` line
+----
+
+A reference configuration should look like these examples:
 
+[source,none]
+----
+default-key <fingerprint of your key>
+personal-digest-preferences SHA512
+cert-digest-algo SHA512
+default-preference-list SHA512 SHA384 SHA256 SHA224 AES256 AES192 AES CAST5 ZLIB BZIP2 ZIP Uncompressed
+----
+
+[source,none]
+----
+edit ~/.rpmmacros # update the `%_gpg_name <key_id>` line
 # Ensure DEBFULLNAME and DEBEMAIL is defined and exported, in the debian scripts configuration
 edit ~/.devscripts
+----
+
+The reference content of these files is:
 
-# The prepare_release.sh is run from the actual cassandra git checkout,
-# on the branch/commit that we wish to tag for the tentative release along with version number to tag.
+[source,none]
+----
+$ cat ~/.rpmmacros 
+%_gpg_name email@youusedforyourkey.org
+$ cat ~/.devscripts 
+DEBFULLNAME="Your Name"
+DEBEMAIL=email@youusedforyourkey.org
+----
+
+Empirically testing shows that you also must have the above `DEB*` environemnt variables exported before proceeding.

Review Comment:
   ```suggestion
   Empirical testing shows that you also must have the above `DEB*` environemnt variables exported before proceeding.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org