[GitHub] [ozone] ChenSammi commented on pull request #3469: HDDS-3630: Merge rocksdb in datanode

[GitBox <gi...@apache.org>]

ChenSammi commented on PR #3469:
URL: https://github.com/apache/ozone/pull/3469#issuecomment-1143442798

   > @ChenSammi Please do not merge on GitHub UI, as that will squash commits. Feature branches should be merged via command-line.
   > 
   > This PR proposes to merge directly from [ChenSammi:HDDS-3630](https://github.com/ChenSammi/ozone/tree/HDDS-3630) into [apache:master](https://github.com/apache/ozone). I think we should update the feature branch ([HDDS-3630](https://issues.apache.org/jira/browse/HDDS-3630)) in Apache first. The process should be:
   > 
   >     1. Update `apache:HDDS-3630` from `apache:master`
   >        
   >        1. Merge `apache:master` into `ChenSammi:HDDS-3630` (done)
   >        2. Wait for CI to pass
   >        3. Push `ChenSammi:HDDS-3630` to `apache:HDDS-3630`
   >        4. Wait for CI to pass
   > 
   >     2. Merge `apache:HDDS-3630` into `apache:master` (optionally preceded by PR for code review)
   >        
   >        1. Open a PR from `apache:HDDS-3630` to `apache:master` for code review and CI
   >        2. Address any code comments in separate Jiras and PRs targeted at `apache:HDDS-3630`
   >        3. Merge `apache:HDDS-3630` into `apache:master` via command-line (not via PR)
   
   @adoroszlai, thanks for the instructions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org