[GitHub] [superset] jfrag1 commented on a diff in pull request #24303: fix: Copy dashboard filters when copying dashboard

["jfrag1 (via GitHub)" <gi...@apache.org>]

jfrag1 commented on code in PR #24303:
URL: https://github.com/apache/superset/pull/24303#discussion_r1220485179


##########
tests/integration_tests/dashboards/dao_tests.py:
##########
@@ -154,6 +154,34 @@ def test_copy_dashboard(self, mock_g):
         db.session.delete(dash)
         db.session.commit()
 
+    @pytest.mark.usefixtures("load_world_bank_dashboard_with_slices")
+    @patch("superset.dashboards.dao.g")
+    def test_copy_dashboard_copies_native_filters(self, mock_g):

Review Comment:
   test fails without this fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org