[jira] [Commented] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603888#comment-17603888 ] 

ASF GitHub Bot commented on HADOOP-18429:
-----------------------------------------

huxinqiu opened a new pull request, #4823:
URL: https://github.com/apache/hadoop/pull/4823

   ### Description of PR
   JIRA - [HADOOP-18429](https://issues.apache.org/jira/browse/HADOOP-18429)
   The Unit Test get stuck in an infinite loop
   ```java
   public void testMutableGaugeFloat() {
       MutableGaugeFloat mgf = new MutableGaugeFloat(Context,3.2f);
       assertEquals(3.2f, mgf.value(), 0.0);
       mgf.incr();
       assertEquals(4.2f, mgf.value(), 0.0);
     }
   ``` 
   
   The current implementation converts the value from int to float, causing the compareAndSet method to get stuck.
   ```java
   private final boolean compareAndSet(float expect, float update) {
     return value.compareAndSet(Float.floatToIntBits(expect),
         Float.floatToIntBits(update));
   }
   
   private void incr(float delta) {
     while (true) {
       float current = value.get();
       float next = current + delta;
       if (compareAndSet(current, next)) {
         setChanged();
         return;
       }
     }
   } 
   ```
   
   Perhaps it could be:
   ```java
   private void incr(float delta) {
     while (true) {
       float current = Float.intBitsToFloat(value.get());
       float next = current + delta;
       if (compareAndSet(current, next)) {
         setChanged();
         return;
       }
     }
   }
   ```
   
   ### How was this patch tested?
   unit test in TestMutableMetrics#testMutableGaugeFloat()
   
   




> MutableGaugeFloat#incr(float) get stuck in an infinite loop
> -----------------------------------------------------------
>
>                 Key: HADOOP-18429
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18429
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>            Reporter: xinqiu.hu
>            Assignee: Ashutosh Gupta
>            Priority: Major
>              Labels: pull-request-available
>
> The current implementation converts the value from int to float, causing the compareAndSet method to get stuck.
> {code:java}
> private final boolean compareAndSet(float expect, float update) {
>   return value.compareAndSet(Float.floatToIntBits(expect),
>       Float.floatToIntBits(update));
> }
> private void incr(float delta) {
>   while (true) {
>     float current = value.get();
>     float next = current + delta;
>     if (compareAndSet(current, next)) {
>       setChanged();
>       return;
>     }
>   }
> } {code}
>  
> Perhaps it could be:
> {code:java}
> private void incr(float delta) {
>   while (true) {
>     float current = Float.intBitsToFloat(value.get());
>     float next = current + delta;
>     if (compareAndSet(current, next)) {
>       setChanged();
>       return;
>     }
>   }
> } {code}
>  
> The unit test looks like this
> {code:java}
> MutableGaugeFloat mgf = new MutableGaugeFloat(Context,3.2f);
> assertEquals(3.2f, mgf.value(), 0.0);
> mgf.incr();
> assertEquals(4.2f, mgf.value(), 0.0); {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org