You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2014/06/27 10:44:25 UTC
[Bug 56678] New: Proxy support for timestamping jars
https://issues.apache.org/bugzilla/show_bug.cgi?id=56678
Bug ID: 56678
Summary: Proxy support for timestamping jars
Product: Ant
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Core tasks
Assignee: notifications@ant.apache.org
Reporter: robbie_usenet@yahoo.co.uk
Created attachment 31755
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31755&action=edit
Code patch
The documentation for the SignJar task states:
'Timestamped JAR files were introduced in Java1.5 and supported in Ant since
Ant 1.7. Ant does not yet support proxy setup for this signing process. '
With Oracle recommending systematic timestamping of JAR files at signature
time, adding proxy support would broaden the audience of this task.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56678] Proxy support for timestamping jars
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56678
--- Comment #7 from Robbie Gibson <ro...@yahoo.co.uk> ---
I think you have the best version now, we have no way of knowing (short of
duplicating jarsigner code to read the user's keystore and parse the
certificate inside it) whether to proxy http or https in the tsaCert case. If
you wanted to make it even simpler, you could just always proxy both http and
https and not even bother trying to work out which one is needed.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56678] Proxy support for timestamping jars
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56678
--- Comment #3 from Stefan Bodewig <bo...@apache.org> ---
refined with git commit f98f495
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56678] Proxy support for timestamping jars
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56678
--- Comment #6 from Stefan Bodewig <bo...@apache.org> ---
only the proxy< setup code tries to parse the scheme to proxy from the url :-)
If only the cert is given the only thing I think we can do is enable the proxy
for http as well as https. Or is there a better way?
git commit ba17089
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56678] Proxy support for timestamping jars
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56678
--- Comment #1 from Robbie Gibson <ro...@yahoo.co.uk> ---
Created attachment 31756
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31756&action=edit
Documentation patch
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56678] Proxy support for timestamping jars
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56678
--- Comment #4 from Robbie Gibson <ro...@yahoo.co.uk> ---
OK, it was the right call to modify as in Comment 2, well done. I had
deliberately removed the option to provide a cert without the URL, but
re-reading the documentation I see I had misunderstood this feature and it
should actually be EITHER a tsaUrl OR a tsaCert (from which the URL is
deduced).
However, the proxy configuration should be used in either case, so you should
revert to commit f98f495, since your later refinement means that the proxy
config won't get used if there is a tsaCert provided - external communication
will still be needed in this case.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56678] Proxy support for timestamping jars
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56678
--- Comment #5 from Robbie Gibson <ro...@yahoo.co.uk> ---
Sorry, I mean revert to commit 7f51882 - that is, back out commit f98f495
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56678] Proxy support for timestamping jars
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56678
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |1.9.5
--- Comment #2 from Stefan Bodewig <bo...@apache.org> ---
added as git commit 7f51882, thanks!
I've modified you patch slightly as you removed the option to only provide a
cert without an url, something that might not make any sense but was possible
before.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 56678] Proxy support for timestamping jars
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56678
Robbie Gibson <ro...@yahoo.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31755|0 |1
is patch| |
--
You are receiving this mail because:
You are the assignee for the bug.