[GitHub] [flink] lincoln-lil commented on a diff in pull request #23209: [FLINK-32824] Port Calcite's fix for the sql like operator

["lincoln-lil (via GitHub)" <gi...@apache.org>]

lincoln-lil commented on code in PR #23209:
URL: https://github.com/apache/flink/pull/23209#discussion_r1296990792


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala:
##########
@@ -793,4 +794,29 @@ class CalcITCase extends StreamingTestBase {
     val expected = List("2.0", "2.0", "2.0")
     assertEquals(expected.sorted, sink.getAppendResults.sorted)
   }
+
+  @Test
+  def testFilterOnString(): Unit = {

Review Comment:
   nit: we can simply extend the current `org.apache.flink.table.planner.runtime.batch.sql.CalcITCase#testFilterOnString` test case adding a new `checkResult` clause to cover the change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org