You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Teddy Choi <pu...@gmail.com> on 2013/04/25 07:16:31 UTC

Review Request: HIVE-3846 alter view rename NPEs with authorization on.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10771/
-----------------------------------------------------------

Review request for hive.


Description
-------

HiveOperation.ALTERVIEW_RENAME was missing.
I added it on HiveOperation and SemanticAnalyzerFactory. Also I added a test to reproduce the error as Ashutosh Chauhan mentioned and it was fixed.

Please read https://issues.apache.org/jira/browse/HIVE-3846 for more details.


This addresses bug HIVE-3846.
    https://issues.apache.org/jira/browse/HIVE-3846


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java e89f580 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 4b1c429 
  ql/src/test/queries/clientpositive/authorization_8.q PRE-CREATION 

Diff: https://reviews.apache.org/r/10771/diff/


Testing
-------


Thanks,

Teddy Choi

Re: Review Request: HIVE-3846 alter view rename NPEs with authorization on.

Posted by Teddy Choi <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10771/
-----------------------------------------------------------

(Updated May 8, 2013, 1:33 a.m.)


Review request for hive.


Changes
-------

Summary of changes
- authorization_8.q.out is included.
- authorization_8.q does not make other tests fail.
- alter_view_rename.q.out and recursive_view.q.out is updated.


Description
-------

HiveOperation.ALTERVIEW_RENAME was missing.
I added it on HiveOperation and SemanticAnalyzerFactory. Also I added a test to reproduce the error as Ashutosh Chauhan mentioned and it was fixed.

Please read https://issues.apache.org/jira/browse/HIVE-3846 for more details.


This addresses bug HIVE-3846.
    https://issues.apache.org/jira/browse/HIVE-3846


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 48a05e8 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 4b1c429 
  ql/src/test/queries/clientpositive/authorization_8.q PRE-CREATION 
  ql/src/test/results/clientnegative/recursive_view.q.out 3a2618b 
  ql/src/test/results/clientpositive/alter_view_rename.q.out 6a498e8 
  ql/src/test/results/clientpositive/authorization_8.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/10771/diff/


Testing
-------


Thanks,

Teddy Choi