You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/19 02:12:57 UTC
[GitHub] codecov-io commented on issue #3725: Replace partition ranges with
partitions
codecov-io commented on issue #3725: Replace partition ranges with partitions
URL: https://github.com/apache/incubator-pinot/pull/3725#issuecomment-455740495
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3725?src=pr&el=h1) Report
> Merging [#3725](https://codecov.io/gh/apache/incubator-pinot/pull/3725?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f09db48ebf4b0bd7a551e8f0c2fd86c1177e4f7a?src=pr&el=desc) will **increase** coverage by `0.1%`.
> The diff coverage is `63.91%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3725?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3725 +/- ##
===========================================
+ Coverage 67.18% 67.28% +0.1%
Complexity 4 4
===========================================
Files 1027 1027
Lines 50830 50800 -30
Branches 7093 7090 -3
===========================================
+ Hits 34150 34182 +32
+ Misses 14336 14278 -58
+ Partials 2344 2340 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3725?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erter/stats/RealtimeNoDictionaryColStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVOb0RpY3Rpb25hcnlDb2xTdGF0aXN0aWNzLmphdmE=) | `64% <ø> (-5.24%)` | `0 <0> (ø)` | |
| [.../core/realtime/PinotLLCRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90TExDUmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `73.07% <0%> (+1.5%)` | `0 <0> (ø)` | :arrow_down: |
| [...lder/PartitionAwareOfflineRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL1BhcnRpdGlvbkF3YXJlT2ZmbGluZVJvdXRpbmdUYWJsZUJ1aWxkZXIuamF2YQ==) | `68.42% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...che/pinot/common/config/ColumnPartitionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0NvbHVtblBhcnRpdGlvbkNvbmZpZy5qYXZh) | `27.27% <0%> (-35.52%)` | `0 <0> (ø)` | |
| [...ot/controller/helix/core/util/ZKMetadataUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvWktNZXRhZGF0YVV0aWxzLmphdmE=) | `68.96% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...time/converter/stats/RealtimeColumnStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVDb2x1bW5TdGF0aXN0aWNzLmphdmE=) | `46.57% <0%> (-1.53%)` | `0 <0> (ø)` | |
| [...e/realtime/converter/RealtimeSegmentConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvUmVhbHRpbWVTZWdtZW50Q29udmVydGVyLmphdmE=) | `75.75% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...mon/metadata/segment/SegmentPartitionMetadata.java](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0YWRhdGEvc2VnbWVudC9TZWdtZW50UGFydGl0aW9uTWV0YWRhdGEuamF2YQ==) | `65% <0%> (+8.47%)` | `0 <0> (ø)` | :arrow_down: |
| [.../impl/stats/SegmentPreIndexStatsCollectorImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9zdGF0cy9TZWdtZW50UHJlSW5kZXhTdGF0c0NvbGxlY3RvckltcGwuamF2YQ==) | `66.15% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `88.75% <100%> (+0.34%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [41 more](https://codecov.io/gh/apache/incubator-pinot/pull/3725/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3725?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3725?src=pr&el=footer). Last update [f09db48...2a90700](https://codecov.io/gh/apache/incubator-pinot/pull/3725?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org