You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/16 13:32:40 UTC
[GitHub] [bookkeeper] StevenLuMT opened a new pull request #3056: change rocksdb init: use OptionsUtil
StevenLuMT opened a new pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056
Descriptions of the changes in this PR:
### Motivation
1. some old parameters in rocksDB is not configurable
### Changes
1.rocks all old parameter change to be configurable,use OptionsUtil to init all params for rocksdb
the old pr #3006 has some rebase error,open a new pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042918594
@eolivelli @pkumar-singh @zymap @mauricebarnum
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1059910831
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1046515549
@eolivelli @pkumar-singh @zymap @mauricebarnum
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1055390478
@dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276 @sijie
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1059910831
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1050422542
@eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1050424498
@dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1055390478
@dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276 @sijie
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1047548442
@eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1050422542
@eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042641702
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042641702
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042692672
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1059764097
@dlg99 @eolivelli @pkumar-singh @zymap @hangc0276 @lordcheng10
If you have time, please help me review it, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042917916
@eolivelli @pkumar-singh @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042918594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1047548442
@eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1053774915
@dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1046515549
@eolivelli @pkumar-singh @zymap @mauricebarnum
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1046441936
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1054870382
@dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1041608351
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042692672
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1046843178
@eolivelli @pkumar-singh @zymap @mauricebarnum
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1055371711
@dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1041608351
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1046843178
@eolivelli @pkumar-singh @zymap @mauricebarnum
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1042917916
@eolivelli @pkumar-singh @zymap
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 merged pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
dlg99 merged pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
lordcheng10 removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1059906510
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1053774915
@dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1050424498
@dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1054870382
@dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1055371711
@dlg99 @eolivelli @pkumar-singh @zymap @mauricebarnum @hangc0276
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3056: change rocksdb init: use OptionsUtil
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on pull request #3056:
URL: https://github.com/apache/bookkeeper/pull/3056#issuecomment-1059906510
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org