You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/08/05 02:57:55 UTC

[GitHub] [rocketmq] xiangwangcheng commented on a change in pull request #1361: fix logging module bug

xiangwangcheng commented on a change in pull request #1361: fix logging module bug
URL: https://github.com/apache/rocketmq/pull/1361#discussion_r310423913
 
 

 ##########
 File path: logging/src/main/java/org/apache/rocketmq/logging/inner/Logger.java
 ##########
 @@ -88,8 +88,8 @@ synchronized void closeNestedAppenders() {
         Enumeration enumeration = this.getAllAppenders();
         if (enumeration != null) {
             while (enumeration.hasMoreElements()) {
-                Appender a = (Appender) enumeration.nextElement();
-                if (a instanceof Appender.AppenderPipeline) {
+                if (enumeration instanceof Appender) {
 
 Review comment:
   Why do u think enumeration is an instance of Appender?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services