You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Henry Saputra (Created) (JIRA)" <ji...@apache.org> on 2011/12/02 01:22:40 UTC

[jira] [Created] (SHINDIG-1665) Shindig BasicImageRewriter corrupted transparant png images with proxy

Shindig BasicImageRewriter corrupted transparant png images with proxy
----------------------------------------------------------------------

                 Key: SHINDIG-1665
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1665
             Project: Shindig
          Issue Type: Bug
          Components: Java
    Affects Versions: 2.0.2, 3.0.0
            Reporter: Henry Saputra
             Fix For: 3.0.0


Shindig "optimizes" images before caching them to reduce space. However, during this optimization PNG images with transparency get corrupted.

The problem seems to happen in ImageUtils.palettize when used by PNGOptimizer#rewriteImpl.

To repro try with attached gadget.xml and image

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1665) Shindig BasicImageRewriter corrupted transparant png images with proxy

Posted by "Ryan Baxter (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227547#comment-13227547 ] 

Ryan Baxter commented on SHINDIG-1665:
--------------------------------------

Henry do you /  are you working on a fix for this?  We are seeing the same problem.  I am not sure who has the expertise to fix this...
                
> Shindig BasicImageRewriter corrupted transparant png images with proxy
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1665
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1665
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.2, 2.5.0
>            Reporter: Henry Saputra
>              Labels: patch, rewriter
>             Fix For: 2.5.0
>
>
> Shindig "optimizes" images before caching them to reduce space. However, during this optimization PNG images with transparency get corrupted.
> The problem seems to happen in ImageUtils.palettize when used by PNGOptimizer#rewriteImpl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SHINDIG-1665) Shindig BasicImageRewriter corrupted transparant png images with proxy

Posted by "Henry Saputra (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saputra updated SHINDIG-1665:
-----------------------------------

    Description: 
Shindig "optimizes" images before caching them to reduce space. However, during this optimization PNG images with transparency get corrupted.

The problem seems to happen in ImageUtils.palettize when used by PNGOptimizer#rewriteImpl.


  was:
Shindig "optimizes" images before caching them to reduce space. However, during this optimization PNG images with transparency get corrupted.

The problem seems to happen in ImageUtils.palettize when used by PNGOptimizer#rewriteImpl.

To repro try with attached gadget.xml and image

    
> Shindig BasicImageRewriter corrupted transparant png images with proxy
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1665
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1665
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.2, 3.0.0
>            Reporter: Henry Saputra
>              Labels: patch, rewriter
>             Fix For: 3.0.0
>
>
> Shindig "optimizes" images before caching them to reduce space. However, during this optimization PNG images with transparency get corrupted.
> The problem seems to happen in ImageUtils.palettize when used by PNGOptimizer#rewriteImpl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1665) Shindig BasicImageRewriter corrupted transparant png images with proxy

Posted by "Richard Kettelerij (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227990#comment-13227990 ] 

Richard Kettelerij commented on SHINDIG-1665:
---------------------------------------------

I've noticed the same issue with PNGs. What would help is a setting (in shindig.properties) to disable image rewriting altogether. Currently it's only getting in the way. 

As a workaround I've excluded PNG files from being rewritten using "shindig.content-rewrite.exclude-urls". While PNG files are now rendered correctly it also causes PNGs to be served directly from the original gadget host. No proxying is happening, which is unfortunate especially in a secure (SSL) environment.
                
> Shindig BasicImageRewriter corrupted transparant png images with proxy
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1665
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1665
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.2, 2.5.0
>            Reporter: Henry Saputra
>              Labels: patch, rewriter
>             Fix For: 2.5.0
>
>
> Shindig "optimizes" images before caching them to reduce space. However, during this optimization PNG images with transparency get corrupted.
> The problem seems to happen in ImageUtils.palettize when used by PNGOptimizer#rewriteImpl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1665) Shindig BasicImageRewriter corrupted transparant png images with proxy

Posted by "Richard Kettelerij (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237487#comment-13237487 ] 

Richard Kettelerij commented on SHINDIG-1665:
---------------------------------------------

@Rich, Thanks for the tip, it works great!
                
> Shindig BasicImageRewriter corrupted transparant png images with proxy
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1665
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1665
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.2, 2.5.0
>            Reporter: Henry Saputra
>              Labels: patch, rewriter
>             Fix For: 2.5.0
>
>
> Shindig "optimizes" images before caching them to reduce space. However, during this optimization PNG images with transparency get corrupted.
> The problem seems to happen in ImageUtils.palettize when used by PNGOptimizer#rewriteImpl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1665) Shindig BasicImageRewriter corrupted transparant png images with proxy

Posted by "Henry Saputra (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228020#comment-13228020 ] 

Henry Saputra commented on SHINDIG-1665:
----------------------------------------

We did the same workaround for now. Been trying to spend time to work on it but so far havent gotten chance to revisit this bug
                
> Shindig BasicImageRewriter corrupted transparant png images with proxy
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1665
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1665
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.2, 2.5.0
>            Reporter: Henry Saputra
>              Labels: patch, rewriter
>             Fix For: 2.5.0
>
>
> Shindig "optimizes" images before caching them to reduce space. However, during this optimization PNG images with transparency get corrupted.
> The problem seems to happen in ImageUtils.palettize when used by PNGOptimizer#rewriteImpl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1665) Shindig BasicImageRewriter corrupted transparant png images with proxy

Posted by "Rich Thompson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228102#comment-13228102 ] 

Rich Thompson commented on SHINDIG-1665:
----------------------------------------

We had someone point out that setting
    shindig.image-rewrite.max-inmem-bytes=0
will cause only images with less than 0 bytes to be rewritten ... i.e. disables the image rewriter
                
> Shindig BasicImageRewriter corrupted transparant png images with proxy
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-1665
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1665
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.0.2, 2.5.0
>            Reporter: Henry Saputra
>              Labels: patch, rewriter
>             Fix For: 2.5.0
>
>
> Shindig "optimizes" images before caching them to reduce space. However, during this optimization PNG images with transparency get corrupted.
> The problem seems to happen in ImageUtils.palettize when used by PNGOptimizer#rewriteImpl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira