You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/25 17:45:23 UTC
[GitHub] [arrow] pitrou opened a new pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
pitrou opened a new pull request #9317:
URL: https://github.com/apache/arrow/pull/9317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#issuecomment-767480687
Revision: 262b3e66ba50981058ffdc88a7e9eb28638d8c5b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-50](https://github.com/ursacomputing/crossbow/branches/all?query=actions-50)
|Task|Status|
|----|------|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-50-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#issuecomment-766993816
https://issues.apache.org/jira/browse/ARROW-11377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#issuecomment-767001462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#issuecomment-767465914
@github-actions crossbow submit test-ubuntu-20.04-cpp-thread-sanitizer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#discussion_r564010378
##########
File path: cpp/build-support/run-test.sh
##########
@@ -65,14 +65,9 @@ function setup_sanitizers() {
# Configure TSAN (ignored if this isn't a TSAN build).
#
- # Deadlock detection (new in clang 3.5) is disabled because:
- # 1. The clang 3.5 deadlock detector crashes in some unit tests. It
- # needs compiler-rt commits c4c3dfd, 9a8efe3, and possibly others.
- # 2. Many unit tests report lock-order-inversion warnings; they should be
- # fixed before reenabling the detector.
- TSAN_OPTIONS="$TSAN_OPTIONS detect_deadlocks=0"
- TSAN_OPTIONS="$TSAN_OPTIONS suppressions=$ROOT/build-support/tsan-suppressions.txt"
Review comment:
Hmm, no, the removal is a mistake. Will re-add them (they're for CUDA).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on a change in pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
bkietz commented on a change in pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#discussion_r563966100
##########
File path: cpp/build-support/run-test.sh
##########
@@ -65,14 +65,9 @@ function setup_sanitizers() {
# Configure TSAN (ignored if this isn't a TSAN build).
#
- # Deadlock detection (new in clang 3.5) is disabled because:
- # 1. The clang 3.5 deadlock detector crashes in some unit tests. It
- # needs compiler-rt commits c4c3dfd, 9a8efe3, and possibly others.
- # 2. Many unit tests report lock-order-inversion warnings; they should be
- # fixed before reenabling the detector.
- TSAN_OPTIONS="$TSAN_OPTIONS detect_deadlocks=0"
- TSAN_OPTIONS="$TSAN_OPTIONS suppressions=$ROOT/build-support/tsan-suppressions.txt"
Review comment:
Is it correct to remove these suppressions? If so, why not also remove tsan-suppressions.txt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#issuecomment-766993816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#discussion_r564010378
##########
File path: cpp/build-support/run-test.sh
##########
@@ -65,14 +65,9 @@ function setup_sanitizers() {
# Configure TSAN (ignored if this isn't a TSAN build).
#
- # Deadlock detection (new in clang 3.5) is disabled because:
- # 1. The clang 3.5 deadlock detector crashes in some unit tests. It
- # needs compiler-rt commits c4c3dfd, 9a8efe3, and possibly others.
- # 2. Many unit tests report lock-order-inversion warnings; they should be
- # fixed before reenabling the detector.
- TSAN_OPTIONS="$TSAN_OPTIONS detect_deadlocks=0"
- TSAN_OPTIONS="$TSAN_OPTIONS suppressions=$ROOT/build-support/tsan-suppressions.txt"
Review comment:
Hmm, no, the removal is a mistake. Will re-add them (they're for CUDA).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9317:
URL: https://github.com/apache/arrow/pull/9317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#issuecomment-767516246
The Crossbow test failure is expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#issuecomment-767001462
@github-actions crossbow submit test-ubuntu-20.04-cpp-thread-sanitizer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#issuecomment-767027416
cc @bkietz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#issuecomment-767007629
Revision: 4530d0276a1494cab5986af9575c52302870afd4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-46](https://github.com/ursacomputing/crossbow/branches/all?query=actions-46)
|Task|Status|
|----|------|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-46-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on a change in pull request #9317: ARROW-11377: [C++][CI] Add Thread Sanitizer nightly build
Posted by GitBox <gi...@apache.org>.
bkietz commented on a change in pull request #9317:
URL: https://github.com/apache/arrow/pull/9317#discussion_r563966100
##########
File path: cpp/build-support/run-test.sh
##########
@@ -65,14 +65,9 @@ function setup_sanitizers() {
# Configure TSAN (ignored if this isn't a TSAN build).
#
- # Deadlock detection (new in clang 3.5) is disabled because:
- # 1. The clang 3.5 deadlock detector crashes in some unit tests. It
- # needs compiler-rt commits c4c3dfd, 9a8efe3, and possibly others.
- # 2. Many unit tests report lock-order-inversion warnings; they should be
- # fixed before reenabling the detector.
- TSAN_OPTIONS="$TSAN_OPTIONS detect_deadlocks=0"
- TSAN_OPTIONS="$TSAN_OPTIONS suppressions=$ROOT/build-support/tsan-suppressions.txt"
Review comment:
Is it correct to remove these suppressions? If so, why not also remove tsan-suppressions.txt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org