You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/17 08:57:41 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new issue #11861: Suggestion: adjust the name of some example modules.

RaigorJiang opened a new issue #11861:
URL: https://github.com/apache/shardingsphere/issues/11861


   Hi community,
   
   I have some doubts when reading the example project:
   Modules like `sharding-spring-boot-jpa-example` and `sharding-spring-boot-mybatis-example` 
   can know from the name that `mybatis` or `jpa` is used.
   `government-spring-boot-example` integrates `mybatis` but is not named according to the above format, looks like the `ORM` is not used?
   
   Similarly, from the name of `transaction-2pc-xa-bitronix-raw-jdbc-example`, it can be seen that `bitronix` is used, while `transaction-2pc-xa-raw-jdbc-example` uses `Atomikos` but cannot be seen from the name.
   
   Therefore, I suggest to adjust the names of the modules to make them more intuitive and reduce user confusion.
   The following are the modules I think need to be optimized:
   1. governance-spring-boot-example (mybatis used)
   2. governance-spring-namespace-example (mybatis used) 
   3. transaction-2pc-xa-raw-jdbc-example (atomikos used)
   4. encrypt-spring-boot-example (mybatis used)
   5. encrypt-spring-namespace-example (mybatis used)
   6. shadow-spring-boot-example (mybatis used)
   7. shadow-spring-namespace-example (mybatis used)
   
   Note that if the module name is modified,
   [README.md](https://github.com/apache/shardingsphere/blob/master/examples/README.md)  and 
   [README_ZH.md](https://github.com/apache/shardingsphere/blob/master/examples/README_ZH.md)also need to be modified accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on issue #11861: Suggestion: adjust the name of some example modules.

Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #11861:
URL: https://github.com/apache/shardingsphere/issues/11861#issuecomment-900119404


   I want to try this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero closed issue #11861: Suggestion: adjust the name of some example modules.

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #11861:
URL: https://github.com/apache/shardingsphere/issues/11861


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero closed issue #11861: Suggestion: adjust the name of some example modules.

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #11861:
URL: https://github.com/apache/shardingsphere/issues/11861


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #11861: Suggestion: adjust the name of some example modules.

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #11861:
URL: https://github.com/apache/shardingsphere/issues/11861#issuecomment-900170893


   @yx9o Welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org