[GitHub] [spark] HeartSaVioR commented on a change in pull request #27678: [SPARK-30927][SS]StreamingQueryManager should avoid keeping reference to terminated StreamingQuery

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #27678: [SPARK-30927][SS]StreamingQueryManager should avoid keeping reference to terminated StreamingQuery
URL: https://github.com/apache/spark/pull/27678#discussion_r383070001
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
 ##########
 @@ -125,11 +134,11 @@ class StreamingQueryManager private[sql] (sparkSession: SparkSession) extends Lo
   @throws[StreamingQueryException]
   def awaitAnyTermination(): Unit = {
     awaitTerminationLock.synchronized {
 
 Review comment:
   While we're here, how about simply calling `awaitAnyTermination(Long.MAX_VALUE)` which is effectively same?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org