You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by gi...@git.apache.org on 2017/08/31 00:09:55 UTC
[GitHub] saandrews commented on a change in pull request #731: End to End Encryption Support - Java client
saandrews commented on a change in pull request #731: End to End Encryption Support - Java client
URL: https://github.com/apache/incubator-pulsar/pull/731#discussion_r136219844
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -34,6 +34,11 @@ message KeyValue {
required string value = 2;
}
+message KeyByteValue {
Review comment:
I see. One of the recommendation is to use byte array when keys are stored. Since it's encrypted key, we should be ok with string. Will change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services