You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by lizhanhui <gi...@git.apache.org> on 2017/04/28 03:38:50 UTC
[GitHub] incubator-rocketmq pull request #100: BugFix: ROCKETMQ-191
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/100
BugFix: ROCKETMQ-191
As we are setting socket options(sndbuf/recvbuf size) for the future SocketChannel, we need to use childOption for ServerBootstrap class.
Semantics differences can be found [Netty docs](http://netty.io/wiki/user-guide-for-4.x.html)
Actually, this is an easy-to-get-confused issue, [Spark had a similar bug too](https://issues.apache.org/jira/browse/SPARK-3502)
[Vertx has similar settings that we can refer to](https://github.com/eclipse/vert.x/blob/master/src/main/java/io/vertx/core/net/impl/NetServerBase.java) See the `applyConnectionOptions` method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-191
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit c80d40abecfe745ff7b17e297d8f04f969f54d8e
Author: Li Zhanhui <li...@apache.org>
Date: 2017-04-28T03:29:24Z
BugFix: ROCKETMQ-191
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #100: [ROCKETMQ-191] Fix socket options
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #100: BugFix: ROCKETMQ-191
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/100
[](https://coveralls.io/builds/11287015)
Coverage decreased (-0.09%) to 37.876% when pulling **f77bddd6db14ed3650e33dbc1eb9cca0c0753966 on lizhanhui:ROCKETMQ-191** into **6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #100: [ROCKETMQ-191] Fix socket options
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/100
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #100: [ROCKETMQ-191] Fix socket options
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/100
> please comply with PR best practice for title as you have corrected before.
Yes. Fixed.
> 2. you can consider the order when many logic and operator together
What you said is definitely reasonable, but this method is actually a single shot run, rendering optimization sort of unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #100: BugFix: ROCKETMQ-191
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/100
[](https://coveralls.io/builds/11283185)
Coverage decreased (-0.06%) to 37.906% when pulling **c80d40abecfe745ff7b17e297d8f04f969f54d8e on lizhanhui:ROCKETMQ-191** into **6609c86650917ebfb5bd12a4bd8b1bcf9c477759 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #100: BugFix: ROCKETMQ-191
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/100
That's a good polish, but I must point out the 2 point for this optimization. 1. please comply with PR best practice for title as you have corrected before. 2. you can consider the order when many logic and operator together, such as 0&&1&&1(similar 1||0||0, nor 0||0||1), making your logic more effective. For this context, linux platform and netty epoll judge, which one happen to 0 more easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---