You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Igor Bondarenko <je...@gmail.com> on 2015/02/12 15:01:53 UTC
[allura:tickets] #7833 Trim emails before saving them to mongo
---
** [tickets:#7833] Trim emails before saving them to mongo**
**Status:** open
**Milestone:** unreleased
**Created:** Thu Feb 12, 2015 02:01 PM UTC by Igor Bondarenko
**Last Updated:** Thu Feb 12, 2015 02:01 PM UTC
**Owner:** nobody
Right now you can claim address like "email@example.com " (note spaces in the end) or even "email@example.com\t" (tab in the end, you can't type this but can copy&paste from some source. That's how I discovered this issue actually).
That's a problem because on the UI you can't see this blank symbols and later, when user types the same email in, say, password recovery form, but without spaces in the end, system will not find it, therefore user will not be able to recover password. Also, association of commits with users and other stuff won't work.
Probably fix is as simple as adding `.strip()` inside `EmailAddress.canonical`, since we use it everywhere already, but it's good to test/investigate further.
Don't sure what to do with existing emails like this which are already in mongo.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7833 Trim emails before saving them to mongo
Posted by Igor Bondarenko <je...@gmail.com>.
- Description has changed:
Diff:
~~~~
--- old
+++ new
@@ -1,4 +1,4 @@
-Right now you can claim address like "email@example.com " (note spaces in the end) or even "email@example.com\t" (tab in the end, you can't type this but can copy&paste from some source. That's how I discovered this issue actually).
+Right now you can claim address like `"email@example.com "` (note spaces in the end) or even `"email@example.com\t"` (tab in the end, you can't type this but can copy&paste from some source. That's how I discovered this issue actually).
That's a problem because on the UI you can't see this blank symbols and later, when user types the same email in, say, password recovery form, but without spaces in the end, system will not find it, therefore user will not be able to recover password. Also, association of commits with users and other stuff won't work.
~~~~
---
** [tickets:#7833] Trim emails before saving them to mongo**
**Status:** open
**Milestone:** unreleased
**Created:** Thu Feb 12, 2015 02:01 PM UTC by Igor Bondarenko
**Last Updated:** Thu Feb 12, 2015 02:01 PM UTC
**Owner:** nobody
Right now you can claim address like `"email@example.com "` (note spaces in the end) or even `"email@example.com\t"` (tab in the end, you can't type this but can copy&paste from some source. That's how I discovered this issue actually).
That's a problem because on the UI you can't see this blank symbols and later, when user types the same email in, say, password recovery form, but without spaces in the end, system will not find it, therefore user will not be able to recover password. Also, association of commits with users and other stuff won't work.
Probably fix is as simple as adding `.strip()` inside `EmailAddress.canonical`, since we use it everywhere already, but it's good to test/investigate further.
Don't sure what to do with existing emails like this which are already in mongo.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7833 Trim emails before saving them to mongo
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **status**: review --> closed
- **Comment**:
Looks good Igor :)
---
** [tickets:#7833] Trim emails before saving them to mongo**
**Status:** closed
**Milestone:** unreleased
**Labels:** 42cc sf-2 sf-current
**Created:** Thu Feb 12, 2015 02:01 PM UTC by Igor Bondarenko
**Last Updated:** Thu Mar 19, 2015 06:34 PM UTC
**Owner:** Igor Bondarenko
Right now you can claim address like `"email@example.com "` (note spaces in the end) or even `"email@example.com\t"` (tab in the end, you can't type this but can copy&paste from some source. That's how I discovered this issue actually).
That's a problem because on the UI you can't see this blank symbols and later, when user types the same email in, say, password recovery form, but without spaces in the end, system will not find it, therefore user will not be able to recover password. Also, association of commits with users and other stuff won't work.
Probably fix is as simple as adding `.strip()` inside `EmailAddress.canonical`, since we use it everywhere already, but it's good to test/investigate further.
Don't sure what to do with existing emails like this which are already in mongo.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7833 Trim emails before saving them to mongo NEEDS SCRIPT
Posted by Dave Brondsema <da...@brondsema.net>.
- **summary**: Trim emails before saving them to mongo --> Trim emails before saving them to mongo NEEDS SCRIPT
---
** [tickets:#7833] Trim emails before saving them to mongo NEEDS SCRIPT**
**Status:** closed
**Milestone:** unreleased
**Labels:** 42cc sf-2 sf-current
**Created:** Thu Feb 12, 2015 02:01 PM UTC by Igor Bondarenko
**Last Updated:** Thu Mar 19, 2015 06:42 PM UTC
**Owner:** Igor Bondarenko
Right now you can claim address like `"email@example.com "` (note spaces in the end) or even `"email@example.com\t"` (tab in the end, you can't type this but can copy&paste from some source. That's how I discovered this issue actually).
That's a problem because on the UI you can't see this blank symbols and later, when user types the same email in, say, password recovery form, but without spaces in the end, system will not find it, therefore user will not be able to recover password. Also, association of commits with users and other stuff won't work.
Probably fix is as simple as adding `.strip()` inside `EmailAddress.canonical`, since we use it everywhere already, but it's good to test/investigate further.
Don't sure what to do with existing emails like this which are already in mongo.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7833 Trim emails before saving them to mongo
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **Reviewer**: Heith Seewald
---
** [tickets:#7833] Trim emails before saving them to mongo**
**Status:** review
**Milestone:** unreleased
**Labels:** 42cc sf-2 sf-current
**Created:** Thu Feb 12, 2015 02:01 PM UTC by Igor Bondarenko
**Last Updated:** Mon Mar 16, 2015 09:56 AM UTC
**Owner:** Igor Bondarenko
Right now you can claim address like `"email@example.com "` (note spaces in the end) or even `"email@example.com\t"` (tab in the end, you can't type this but can copy&paste from some source. That's how I discovered this issue actually).
That's a problem because on the UI you can't see this blank symbols and later, when user types the same email in, say, password recovery form, but without spaces in the end, system will not find it, therefore user will not be able to recover password. Also, association of commits with users and other stuff won't work.
Probably fix is as simple as adding `.strip()` inside `EmailAddress.canonical`, since we use it everywhere already, but it's good to test/investigate further.
Don't sure what to do with existing emails like this which are already in mongo.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7833 Trim emails before saving them to mongo NEEDS SCRIPT
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: 42cc, sf-2, sf-current --> 42cc, sf-2
---
** [tickets:#7833] Trim emails before saving them to mongo NEEDS SCRIPT**
**Status:** closed
**Milestone:** unreleased
**Labels:** 42cc sf-2
**Created:** Thu Feb 12, 2015 02:01 PM UTC by Igor Bondarenko
**Last Updated:** Thu Mar 19, 2015 06:45 PM UTC
**Owner:** Igor Bondarenko
Right now you can claim address like `"email@example.com "` (note spaces in the end) or even `"email@example.com\t"` (tab in the end, you can't type this but can copy&paste from some source. That's how I discovered this issue actually).
That's a problem because on the UI you can't see this blank symbols and later, when user types the same email in, say, password recovery form, but without spaces in the end, system will not find it, therefore user will not be able to recover password. Also, association of commits with users and other stuff won't work.
Probably fix is as simple as adding `.strip()` inside `EmailAddress.canonical`, since we use it everywhere already, but it's good to test/investigate further.
Don't sure what to do with existing emails like this which are already in mongo.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7833 Trim emails before saving them to mongo
Posted by Igor Bondarenko <je...@gmail.com>.
- **status**: in-progress --> review
- **Comment**:
Closed #741. `allura:ib/7833`
On SF need to run `allura/scripts/trim_emails.py` `ScriptTask` to fix emails that are already there (I've checked production db, and there are some).
---
** [tickets:#7833] Trim emails before saving them to mongo**
**Status:** review
**Milestone:** unreleased
**Labels:** 42cc sf-2 sf-current
**Created:** Thu Feb 12, 2015 02:01 PM UTC by Igor Bondarenko
**Last Updated:** Mon Mar 09, 2015 03:59 PM UTC
**Owner:** Igor Bondarenko
Right now you can claim address like `"email@example.com "` (note spaces in the end) or even `"email@example.com\t"` (tab in the end, you can't type this but can copy&paste from some source. That's how I discovered this issue actually).
That's a problem because on the UI you can't see this blank symbols and later, when user types the same email in, say, password recovery form, but without spaces in the end, system will not find it, therefore user will not be able to recover password. Also, association of commits with users and other stuff won't work.
Probably fix is as simple as adding `.strip()` inside `EmailAddress.canonical`, since we use it everywhere already, but it's good to test/investigate further.
Don't sure what to do with existing emails like this which are already in mongo.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7833 Trim emails before saving them to mongo
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: 42cc --> 42cc, sf-2, sf-current
---
** [tickets:#7833] Trim emails before saving them to mongo**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc sf-2 sf-current
**Created:** Thu Feb 12, 2015 02:01 PM UTC by Igor Bondarenko
**Last Updated:** Wed Mar 04, 2015 12:05 PM UTC
**Owner:** Igor Bondarenko
Right now you can claim address like `"email@example.com "` (note spaces in the end) or even `"email@example.com\t"` (tab in the end, you can't type this but can copy&paste from some source. That's how I discovered this issue actually).
That's a problem because on the UI you can't see this blank symbols and later, when user types the same email in, say, password recovery form, but without spaces in the end, system will not find it, therefore user will not be able to recover password. Also, association of commits with users and other stuff won't work.
Probably fix is as simple as adding `.strip()` inside `EmailAddress.canonical`, since we use it everywhere already, but it's good to test/investigate further.
Don't sure what to do with existing emails like this which are already in mongo.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.