You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@gmail.com> on 2013/08/10 00:56:08 UTC
Re: Review Request 13452: SQOOP-924 Sqoop2: Devguide: Describe wire protocol
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13452/
-----------------------------------------------------------
(Updated Aug. 9, 2013, 10:56 p.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Changes
-------
update the commit message.
Summary (updated)
-----------------
SQOOP-924 Sqoop2: Devguide: Describe wire protocol
Bugs: SQOOP-924
https://issues.apache.org/jira/browse/SQOOP-924
Repository: sqoop-sqoop2
Description (updated)
-------
commit 1b533c60a4c4f0da12b9140fdb0838ba24c00045
Author: Mengwei Ding <me...@gmail.com>
Date: Tue Aug 6 14:34:40 2013 -0700
SQOOP-924 Sqoop2: Devguide: Describe wire protocol
:000000 100644 0000000... 1022795... A docs/src/site/sphinx/NetworkAPI.rst
:100644 100644 15ddfbb... 1d83db5... M docs/src/site/sphinx/index.rst
Diffs (updated)
-----
docs/src/site/sphinx/NetworkAPI.rst PRE-CREATION
docs/src/site/sphinx/index.rst 15ddfbb
Diff: https://reviews.apache.org/r/13452/diff/
Testing
-------
Thanks,
Mengwei Ding
Re: Review Request 13452: SQOOP-924 Sqoop2: Devguide: Describe wire protocol
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13452/#review25216
-----------------------------------------------------------
Hi Mengwei,
thank you for putting this Guide together, it's very helpful!
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49507>
Do you think that we can rename the document to "Sqoop REST API Guide", so that the name is more descriptive?
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49508>
... interacting with Sqoop server.
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49509>
Please provide link from "client API" to the client API documentation.
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49511>
Can we add here something like general introduction? I think that from the introduction user should have an idea that the REST API is offered as an HTTP call and that data will be encoded using json.
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49510>
The host|port|webapp might be problematic when one will be running Sqoop on https. Let's just describe that you need Sqoop server URL.
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49513>
I don't think that Connection vs. Job is difference belong here, as it's not specific to web API. It should be described in more generic section.
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49512>
Form is not a group of inputs, it's list of inputs (e.g. different data type).
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49514>
I would suggest not to use word function here as HTTP do not have functions. Perhaps a HTTP call or REST call?
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49515>
The example seems to be unnecessary long, would you mind cutting it?
- Jarek Cecho
On Aug. 9, 2013, 10:56 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13452/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 10:56 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-924
> https://issues.apache.org/jira/browse/SQOOP-924
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 1b533c60a4c4f0da12b9140fdb0838ba24c00045
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Aug 6 14:34:40 2013 -0700
>
> SQOOP-924 Sqoop2: Devguide: Describe wire protocol
>
> :000000 100644 0000000... 1022795... A docs/src/site/sphinx/NetworkAPI.rst
> :100644 100644 15ddfbb... 1d83db5... M docs/src/site/sphinx/index.rst
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/NetworkAPI.rst PRE-CREATION
> docs/src/site/sphinx/index.rst 15ddfbb
>
> Diff: https://reviews.apache.org/r/13452/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 13452: SQOOP-924 Sqoop2: Devguide: Describe wire protocol
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13452/#review25512
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Aug. 20, 2013, 12:20 a.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13452/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2013, 12:20 a.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-924
> https://issues.apache.org/jira/browse/SQOOP-924
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 5242f478e2106cfcfc19d0ada9307aa27fb9c829
> Author: Mengwei Ding <me...@gmail.com>
> Date: Mon Aug 19 15:42:52 2013 -0700
>
> SQOOP-924 Sqoop2: Devguide: Describe wire protocol
>
> :000000 100644 0000000... 04908e8... A docs/src/site/sphinx/RESTAPI.rst
> :100644 100644 6b03e62... 07e3c47... M docs/src/site/sphinx/index.rst
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/RESTAPI.rst PRE-CREATION
> docs/src/site/sphinx/index.rst 6b03e62
>
> Diff: https://reviews.apache.org/r/13452/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 13452: SQOOP-924 Sqoop2: Devguide: Describe wire protocol
Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13452/
-----------------------------------------------------------
(Updated Aug. 20, 2013, 12:20 a.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Changes
-------
incorporate the comments.
Bugs: SQOOP-924
https://issues.apache.org/jira/browse/SQOOP-924
Repository: sqoop-sqoop2
Description (updated)
-------
commit 5242f478e2106cfcfc19d0ada9307aa27fb9c829
Author: Mengwei Ding <me...@gmail.com>
Date: Mon Aug 19 15:42:52 2013 -0700
SQOOP-924 Sqoop2: Devguide: Describe wire protocol
:000000 100644 0000000... 04908e8... A docs/src/site/sphinx/RESTAPI.rst
:100644 100644 6b03e62... 07e3c47... M docs/src/site/sphinx/index.rst
Diffs (updated)
-----
docs/src/site/sphinx/RESTAPI.rst PRE-CREATION
docs/src/site/sphinx/index.rst 6b03e62
Diff: https://reviews.apache.org/r/13452/diff/
Testing
-------
Thanks,
Mengwei Ding
Re: Review Request 13452: SQOOP-924 Sqoop2: Devguide: Describe wire protocol
Posted by rj...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13452/#review25069
-----------------------------------------------------------
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49247>
Blank space at the end of line
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49246>
Change intput to input
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49245>
Give correct description
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49248>
For GET request, not required to filled. Let it be "Framework's Job Configuration forms"
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49249>
For GET request, not required to filled. Let it be "Framework's connection configuration forms"
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49250>
Enable a job?
docs/src/site/sphinx/NetworkAPI.rst
<https://reviews.apache.org/r/13452/#comment49251>
progress
- vasanthkumar
On Aug. 9, 2013, 10:56 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13452/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 10:56 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-924
> https://issues.apache.org/jira/browse/SQOOP-924
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 1b533c60a4c4f0da12b9140fdb0838ba24c00045
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Aug 6 14:34:40 2013 -0700
>
> SQOOP-924 Sqoop2: Devguide: Describe wire protocol
>
> :000000 100644 0000000... 1022795... A docs/src/site/sphinx/NetworkAPI.rst
> :100644 100644 15ddfbb... 1d83db5... M docs/src/site/sphinx/index.rst
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/NetworkAPI.rst PRE-CREATION
> docs/src/site/sphinx/index.rst 15ddfbb
>
> Diff: https://reviews.apache.org/r/13452/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>