You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by alibazlamit <no...@github.com> on 2016/10/28 22:10:30 UTC

[jclouds/jclouds-labs] pb-updates-v3 (#333)

@nacx Here is the v3 updates with the fixed two live tests that were failing, ready for review.

Thanks.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/333

-- Commit Summary --

  * pb-updates-v3

-- File Changes --

    M profitbricks-rest/pom.xml (2)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/ProfitBricksApiMetadata.java (2)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/binder/BaseProfitBricksRequestBinder.java (27)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Nic.java (64)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Volume.java (187)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/FirewallApi.java (2)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/IpBlockApi.java (2)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/LanApi.java (2)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/NicApi.java (2)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/ServerApi.java (2)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/SnapshotApi.java (2)
    M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/VolumeApi.java (2)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/DataCenterApiMockTest.java (2)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/FirewallApiLiveTest.java (16)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/FirewallApiMockTest.java (4)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/ImageApiMockTest.java (4)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/IpBlockApiMockTest.java (2)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/LanApiMockTest.java (4)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/NicApiMockTest.java (2)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/ServerApiLiveTest.java (115)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/ServerApiMockTest.java (4)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/SnapshotApiMockTest.java (4)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/VolumeApiMockTest.java (2)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/internal/BaseProfitBricksApiMockTest.java (4)
    M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/internal/BaseProfitBricksLiveTest.java (29)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/333.patch
https://github.com/jclouds/jclouds-labs/pull/333.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by alibazlamit <no...@github.com>.
@nacx What is the next step for  moving this provider to production?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-262578988

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by Ignasi Barrera <no...@github.com>.
nacx commented on this pull request.

Just a couple minors. Apart from that LGTM! Thanks @alibazlamit!

> @@ -69,30 +72,31 @@ public void testCreateServer() {
               .cores(1)
               .ram(1024)
               .build());
-      
+
+      assertRequestCompleted(testServer);

Duplicated?

> @@ -105,149 +109,166 @@ public void testUpdateServer() {
               .ram(1024 * 2)
               .cores(2)
               .build());
-      
+
+      assertRequestCompleted(updated);

Duplicated?

>        attachedVolume = serverApi().attachVolume(
               Server.Request.attachVolumeBuilder()
               .dataCenterId(testServer.dataCenterId())
               .serverId(testServer.id())
               .volumeId(volume.id())
               .build()
       );
-      
+
+      assertRequestCompleted(attachedVolume);

Same here, duplicate?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#pullrequestreview-6369950

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by Ignasi Barrera <no...@github.com>.
BTW, I've amended the commit message before merging.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-257294527

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by Ignasi Barrera <no...@github.com>.
HI @alibazlamit! I've opened [JCLOUDS-1207](https://issues.apache.org/jira/browse/JCLOUDS-1207) to track the promotion of profitbricks-rest.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-263222048

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by alibazlamit <no...@github.com>.
@nacx removed duplicates. and squashed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-257267014

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by alibazlamit <no...@github.com>.
@alibazlamit pushed 1 commit.

6af4e89  minor change to the return type


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333/files/9c48deeb44a58204d48b025c3fc575189a32c35c..6af4e897014b2d51a1dc42558ebf26db7d783bb3

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by Ignasi Barrera <no...@github.com>.
Live tests are all green :)
Tests run: 94, Failures: 0, Errors: 0, Skipped: 3

Pushed to master as [61e5651b](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/61e5651b). Thanks @alibazlamit!




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-257294463

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by alibazlamit <no...@github.com>.
@nacx how are we going to proceed with this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-262791295

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by Ignasi Barrera <no...@github.com>.
Having the live tests passing consistently, which is something we can verify now that we have a periodical build. That's the most important one.

Apart from that (and it is something the soap based provider is missing) the provider should ideally:

* Honor the templateOptions.inboundPorts, and create firewall rules for the servers accordingly.
* Implement the SecurityGroupExtension, to be able to manage firewalls and firewall rules (templates and rules in ProfitBricks?).
* Implement the ImageExtension, to be able to create an image from a running server.

If those features make sense for ProfitBricks it would be great to open a JIRA issue for each one so we can properly track them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#issuecomment-262592096

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by Ignasi Barrera <no...@github.com>.
Closed #333.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333#event-841896044

Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)

Posted by alibazlamit <no...@github.com>.
@alibazlamit pushed 1 commit.

abb5027  Removed duplicates in live tests


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/333/files/5d5508ba9e265270a627c8bfb992b5195f8fb00b..abb50270c3a7f695390065bf217bf092bab2061b