You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/13 09:12:51 UTC

[GitHub] [shardingsphere] natehuangting opened a new pull request, #18330: MySQL Normal Replication preferentially uses custom sql to judge replication delay

natehuangting opened a new pull request, #18330:
URL: https://github.com/apache/shardingsphere/pull/18330

   Fixes #18327 .
   
   Changes proposed in this pull request:
   - MySQL Normal Replication preferentially uses custom sql to judge replication delay.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] natehuangting commented on pull request #18330: MySQL Normal Replication preferentially uses custom sql to judge replication delay

Posted by GitBox <gi...@apache.org>.
natehuangting commented on PR #18330:
URL: https://github.com/apache/shardingsphere/pull/18330#issuecomment-1153804369

   > @natehuangting Hi bro, thank you for your pull request. your idea so cool. But` select abs(unix_timestamp(now())-unix_timestamp(max(Ftime))) as delay from dba.delay_monitor limit 1` this sql is by yourself business definition? `ShardingSphere` not provide save insert time, So i think this feature are not suitable `ShardingSphere`. You can achieve your purpose by implemente `DatabaseDiscoveryProviderAlgorithm` interface.
   
   
   
   > @natehuangting Hi bro, thank you for your pull request. your idea so cool. But` select abs(unix_timestamp(now())-unix_timestamp(max(Ftime))) as delay from dba.delay_monitor limit 1` this sql is by yourself business definition? `ShardingSphere` not provide save insert time, So i think this feature are not suitable `ShardingSphere`. You can achieve your purpose by implemente `DatabaseDiscoveryProviderAlgorithm` interface.
   
   Thank you for your suggestion. My initial idea was to be compatible with the original mode. If the user does not define the sql, then use second_behind_master. I think your suggestion is very good. If it is independent, we can force the user to define the SQL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zjcnb commented on pull request #18330: MySQL Normal Replication preferentially uses custom sql to judge replication delay

Posted by GitBox <gi...@apache.org>.
zjcnb commented on PR #18330:
URL: https://github.com/apache/shardingsphere/pull/18330#issuecomment-1153821874

   > @zjcnb Thank you for your suggestion. My initial idea was to be compatible with the original mode. If the user does not define the sql, then use second_behind_master. I think your suggestion is very good. If it is independent, we can force the user to define the SQL.
   
   Yeah, thanks. Welcome to sumbit other pull request. So i closed this pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zjcnb commented on pull request #18330: MySQL Normal Replication preferentially uses custom sql to judge replication delay

Posted by GitBox <gi...@apache.org>.
zjcnb commented on PR #18330:
URL: https://github.com/apache/shardingsphere/pull/18330#issuecomment-1153792711

   @natehuangting Hi bro, thank you for your pull request. your idea so cool. But` select abs(unix_timestamp(now())-unix_timestamp(max(Ftime))) as delay from dba.delay_monitor limit 1` this sql is by yourself business definition?  `ShardingSphere` not provide save insert time, So i think this feature are not suitable `ShardingSphere`. You can achieve your purpose by implemente `DatabaseDiscoveryProviderAlgorithm` interface.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zjcnb closed pull request #18330: MySQL Normal Replication preferentially uses custom sql to judge replication delay

Posted by GitBox <gi...@apache.org>.
zjcnb closed pull request #18330: MySQL Normal Replication preferentially uses custom sql to judge replication delay
URL: https://github.com/apache/shardingsphere/pull/18330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #18330: MySQL Normal Replication preferentially uses custom sql to judge replication delay

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18330:
URL: https://github.com/apache/shardingsphere/pull/18330#issuecomment-1153715225

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18330?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#18330](https://codecov.io/gh/apache/shardingsphere/pull/18330?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b618f9e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a4f2d12b8c7e336f7fde0b9b35eefccaaf20bef1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4f2d12) will **decrease** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18330      +/-   ##
   ============================================
   - Coverage     59.14%   59.14%   -0.01%     
   - Complexity     2199     2200       +1     
   ============================================
     Files          3733     3737       +4     
     Lines         54734    54746      +12     
     Branches       9302     9305       +3     
   ============================================
   + Hits          32371    32377       +6     
   - Misses        19612    19618       +6     
     Partials       2751     2751              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18330?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ReplicationDatabaseDiscoveryProviderAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL3R5cGUvTXlTUUxOb3JtYWxSZXBsaWNhdGlvbkRhdGFiYXNlRGlzY292ZXJ5UHJvdmlkZXJBbGdvcml0aG0uamF2YQ==) | `50.90% <0.00%> (-6.24%)` | :arrow_down: |
   | [...ler/query/DatabaseDiscoveryRuleQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9xdWVyeS9EYXRhYmFzZURpc2NvdmVyeVJ1bGVRdWVyeVJlc3VsdFNldC5qYXZh) | `84.00% <0.00%> (-1.72%)` | :arrow_down: |
   | [...nfra/rule/builder/schema/DatabaseRulesBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9ydWxlL2J1aWxkZXIvc2NoZW1hL0RhdGFiYXNlUnVsZXNCdWlsZGVyLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...l/parser/core/database/visitor/SQLVisitorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2RhdGFiYXNlL3Zpc2l0b3IvU1FMVmlzaXRvclJ1bGUuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | [...xt/distsql/rql/rule/SchemaRulesCountResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL3J1bGUvU2NoZW1hUnVsZXNDb3VudFJlc3VsdFNldC5qYXZh) | | |
   | [...aultSingleTableSchemaRuleConfigurationBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNpbmdsZS10YWJsZS9zaGFyZGluZ3NwaGVyZS1zaW5nbGUtdGFibGUtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2luZ2xldGFibGUvcnVsZS9idWlsZGVyL0RlZmF1bHRTaW5nbGVUYWJsZVNjaGVtYVJ1bGVDb25maWd1cmF0aW9uQnVpbGRlci5qYXZh) | | |
   | [.../DefaultSchemaRuleConfigurationBuilderFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9ydWxlL2J1aWxkZXIvc2NoZW1hL0RlZmF1bHRTY2hlbWFSdWxlQ29uZmlndXJhdGlvbkJ1aWxkZXJGYWN0b3J5LmphdmE=) | | |
   | [.../rule/builder/schema/SchemaRuleBuilderFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9ydWxlL2J1aWxkZXIvc2NoZW1hL1NjaGVtYVJ1bGVCdWlsZGVyRmFjdG9yeS5qYXZh) | | |
   | [.../distsql/rql/rule/DatabaseRulesCountResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL3J1bGUvRGF0YWJhc2VSdWxlc0NvdW50UmVzdWx0U2V0LmphdmE=) | `82.25% <0.00%> (ø)` | |
   | [...ule/builder/schema/DatabaseRuleBuilderFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9ydWxlL2J1aWxkZXIvc2NoZW1hL0RhdGFiYXNlUnVsZUJ1aWxkZXJGYWN0b3J5LmphdmE=) | `100.00% <0.00%> (ø)` | |
   | ... and [10 more](https://codecov.io/gh/apache/shardingsphere/pull/18330/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18330?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18330?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a4f2d12...b618f9e](https://codecov.io/gh/apache/shardingsphere/pull/18330?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org