[GitHub] [arrow] nevi-me commented on pull request #8739: ARROW-10684: [Rust] Inherit struct nulls in child

[GitBox <gi...@apache.org>]

nevi-me commented on pull request #8739:
URL: https://github.com/apache/arrow/pull/8739#issuecomment-731743163


   @jorgecarleitao @alamb I've only implemented this for `<struct<primitive>>` for now, I'd like to get some feedback on whether the approach that I'm taking is fine.
   
   The change mainly keeps track of the null buffer of `ArrayData` for arrays, and combines the array's null buffer with the child's, when a nested type is encountered. I use `BitAnd` to combine the buffers.
   
   Where we need null counts for comparisons, we have to recalculate the counts from the separate null buffer, as they might have been combined with the parent's null buffer (buffer-ception? let me know if my sentence is unclear).
   
   I'll work on the below so we have sufficient test coverage:
   * `<struct<struct<primitive>>>`
   * `<struct<struct<dictionary>>>`
   * `<list<primitive>>`
   * `<list<dictionary>>`
   * `<list<struct<list<primitive>>>>`
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org