You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2017/05/25 04:42:06 UTC
[1/5] git commit: [flex-asjs] [refs/heads/release0.8.0] - make sure
className and new styles get applied
Repository: flex-asjs
Updated Branches:
refs/heads/release0.8.0 0428a145c -> 8cfef0691
make sure className and new styles get applied
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/7e415e0f
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/7e415e0f
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/7e415e0f
Branch: refs/heads/release0.8.0
Commit: 7e415e0f2562c7643f3ef44fa4820d5332bc0a86
Parents: f6bf8c6
Author: Alex Harui <ah...@apache.org>
Authored: Wed May 24 21:41:13 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Wed May 24 21:41:58 2017 -0700
----------------------------------------------------------------------
.../Basic/src/main/flex/org/apache/flex/core/UIBase.as | 7 +++++++
1 file changed, 7 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/7e415e0f/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
index d917b8d..d0e8528 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/UIBase.as
@@ -960,6 +960,11 @@ package org.apache.flex.core
_style.top = _y;
if (!isNaN(_x))
_style.left = _x;
+ COMPILE::JS
+ {
+ if (parent)
+ ValuesManager.valuesImpl.applyStyles(this, _style);
+ }
dispatchEvent(new Event("stylesChanged"));
}
}
@@ -1293,6 +1298,8 @@ package org.apache.flex.core
COMPILE::JS
{
+ if (!_className && typeNames)
+ setClassName(typeNames);
if (style)
ValuesManager.valuesImpl.applyStyles(this, style);
}
[5/5] git commit: [flex-asjs] [refs/heads/release0.8.0] - set
imagebutton padding to zero
Posted by ah...@apache.org.
set imagebutton padding to zero
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/8cfef069
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/8cfef069
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/8cfef069
Branch: refs/heads/release0.8.0
Commit: 8cfef0691c9ce71e72203e5c29fb50c77eaca8f6
Parents: 7e415e0
Author: Alex Harui <ah...@apache.org>
Authored: Wed May 24 21:41:50 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Wed May 24 21:41:59 2017 -0700
----------------------------------------------------------------------
frameworks/projects/Basic/src/main/resources/defaults.css | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/8cfef069/frameworks/projects/Basic/src/main/resources/defaults.css
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/resources/defaults.css b/frameworks/projects/Basic/src/main/resources/defaults.css
index 90f0ccb..e38763c 100644
--- a/frameworks/projects/Basic/src/main/resources/defaults.css
+++ b/frameworks/projects/Basic/src/main/resources/defaults.css
@@ -323,16 +323,19 @@ ImageButton
{
IBeadModel: ClassReference("org.apache.flex.html.beads.models.ImageModel");
border-style: none;
+ padding: 0px;
}
ImageButton:hover
{
border-style: none;
+ padding: 0px;
}
ImageButton:active
{
border-style: none;
+ padding: 0px;
}
VContainer
[3/5] git commit: [flex-asjs] [refs/heads/release0.8.0] - absolute
positioned containers without any size specification appear to be treated as
zero size inside of flex-box. We could have absolute positioning layouts set
sizes but for now, just set the
Posted by ah...@apache.org.
absolute positioned containers without any size specification appear to be treated as zero size inside of flex-box. We could have absolute positioning layouts set sizes but for now, just set the size on the container.
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/0b50ba35
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/0b50ba35
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/0b50ba35
Branch: refs/heads/release0.8.0
Commit: 0b50ba354c6007e435d75de46ac3d2df642b6a79
Parents: 0428a14
Author: Alex Harui <ah...@apache.org>
Authored: Wed May 24 20:27:16 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Wed May 24 21:41:58 2017 -0700
----------------------------------------------------------------------
.../flexjs/FlexJSStore/src/main/flex/productsView/ProductCart.mxml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/0b50ba35/examples/flexjs/FlexJSStore/src/main/flex/productsView/ProductCart.mxml
----------------------------------------------------------------------
diff --git a/examples/flexjs/FlexJSStore/src/main/flex/productsView/ProductCart.mxml b/examples/flexjs/FlexJSStore/src/main/flex/productsView/ProductCart.mxml
index 3469806..5df06d8 100755
--- a/examples/flexjs/FlexJSStore/src/main/flex/productsView/ProductCart.mxml
+++ b/examples/flexjs/FlexJSStore/src/main/flex/productsView/ProductCart.mxml
@@ -96,7 +96,7 @@ limitations under the License.
removeProduct="productListEventHandler(event)"
showQuantity="true" />
- <js:Container style="right:0" id="totalContainer">
+ <js:Container style="right:0" id="totalContainer" width="100%" height="60">
<js:beads>
<js:VerticalColumnLayout numColumns="2" />
</js:beads>
[4/5] git commit: [flex-asjs] [refs/heads/release0.8.0] - ImageButton
is now a button with an image so click events are often on th e image and not
the containing button. Maybe there's a better way to get the event target to
not be the image, but for no
Posted by ah...@apache.org.
ImageButton is now a button with an image so click events are often on th e image and not the containing button. Maybe there's a better way to get the event target to not be the image, but for now we'll look up one level of parenting.
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/48018d58
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/48018d58
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/48018d58
Branch: refs/heads/release0.8.0
Commit: 48018d5868187b498c130dea82e1323f9e1b44e0
Parents: 0b50ba3
Author: Alex Harui <ah...@apache.org>
Authored: Wed May 24 20:32:08 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Wed May 24 21:41:58 2017 -0700
----------------------------------------------------------------------
.../flex/org/apache/flex/events/BrowserEvent.as | 27 +++++++++++++++-----
1 file changed, 21 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/48018d58/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEvent.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEvent.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEvent.as
index d87b429..1237529 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEvent.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEvent.as
@@ -179,8 +179,13 @@ package org.apache.flex.events
{
var o:Object = wrappedEvent.currentTarget;
- if (o && o.flexjs_wrapper)
- return o.flexjs_wrapper;
+ if (o)
+ {
+ if (o.flexjs_wrapper)
+ return o.flexjs_wrapper;
+ if (o.parentNode && o.parentNode.flexjs_wrapper)
+ return o.parentNode.flexjs_wrapper;
+ }
return o;
}
@@ -355,8 +360,13 @@ package org.apache.flex.events
{
var o:Object = wrappedEvent.relatedTarget;
- if (o && o.flexjs_wrapper)
- return o.flexjs_wrapper;
+ if (o)
+ {
+ if (o.flexjs_wrapper)
+ return o.flexjs_wrapper;
+ if (o.parentNode && o.parentNode.flexjs_wrapper)
+ return o.parentNode.flexjs_wrapper;
+ }
return o;
}
@@ -453,8 +463,13 @@ package org.apache.flex.events
{
var o:Object = wrappedEvent.target;
- if (o && o.flexjs_wrapper)
- return o.flexjs_wrapper;
+ if (o)
+ {
+ if (o.flexjs_wrapper)
+ return o.flexjs_wrapper;
+ if (o.parentNode && o.parentNode.flexjs_wrapper)
+ return o.parentNode.flexjs_wrapper;
+ }
return o;
}
[2/5] git commit: [flex-asjs] [refs/heads/release0.8.0] - need to
dispatch childrenAdded as promised.
Posted by ah...@apache.org.
need to dispatch childrenAdded as promised.
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/f6bf8c69
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/f6bf8c69
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/f6bf8c69
Branch: refs/heads/release0.8.0
Commit: f6bf8c69954d3979f847a1d3ffdc4aa72b3d3fb7
Parents: 48018d5
Author: Alex Harui <ah...@apache.org>
Authored: Wed May 24 20:32:33 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Wed May 24 21:41:58 2017 -0700
----------------------------------------------------------------------
.../flex/org/apache/flex/core/ContainerBase.as | 4 ++++
.../main/flex/org/apache/flex/core/GroupBase.as | 22 ++++++++++++++++++++
2 files changed, 26 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/f6bf8c69/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/ContainerBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/ContainerBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/ContainerBase.as
index 0dcb0e3..af3472b 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/ContainerBase.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/ContainerBase.as
@@ -109,6 +109,8 @@ package org.apache.flex.core
var layoutHost:ILayoutHost = view as ILayoutHost;
var contentView:IParent = layoutHost.contentView as IParent;
contentView.addElement(c, dispatchEvent);
+ if (dispatchEvent)
+ this.dispatchEvent(new Event("childrenAdded"));
}
/**
@@ -120,6 +122,8 @@ package org.apache.flex.core
var layoutHost:ILayoutHost = view as ILayoutHost;
var contentView:IParent = layoutHost.contentView as IParent;
contentView.addElementAt(c, index, dispatchEvent);
+ if (dispatchEvent)
+ this.dispatchEvent(new Event("childrenAdded"));
}
/**
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/f6bf8c69/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/GroupBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/GroupBase.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/GroupBase.as
index 07859a1..3a89556 100644
--- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/GroupBase.as
+++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/core/GroupBase.as
@@ -292,5 +292,27 @@ package org.apache.flex.core
_transitions = value;
}
+ /**
+ * @private
+ */
+ COMPILE::SWF
+ override public function addElement(c:IChild, dispatchEvent:Boolean = true):void
+ {
+ super.addElement(c, dispatchEvent);
+ if (dispatchEvent)
+ this.dispatchEvent(new Event("childrenAdded"));
+ }
+
+ /**
+ * @private
+ */
+ COMPILE::SWF
+ override public function addElementAt(c:IChild, index:int, dispatchEvent:Boolean = true):void
+ {
+ super.addElementAt(c, index, dispatchEvent);
+ if (dispatchEvent)
+ this.dispatchEvent(new Event("childrenAdded"));
+ }
+
}
}