[GitHub] [cassandra] sumanth-pasupuleti commented on a change in pull request #1043: CASSANDRA-16669 - Obfuscate password for DCL statements in QueryEvents

[GitBox <gi...@apache.org>]

sumanth-pasupuleti commented on a change in pull request #1043:
URL: https://github.com/apache/cassandra/pull/1043#discussion_r649277548



##########
File path: src/java/org/apache/cassandra/cql3/QueryEvents.java
##########
@@ -72,8 +82,9 @@ public void notifyQuerySuccess(CQLStatement statement,
     {
         try
         {
+
             for (Listener listener : listeners)
-                listener.querySuccess(statement, query, options, state, queryTime, response);
+                listener.querySuccess(statement, possiblyObfuscateQuery(statement, query), options, state, queryTime, response);

Review comment:
       > Another idea:
   > Can we do this before for loop to avoid the overhead / unnecessary cost
   > `query = listeners.size()>0? possiblyObfuscateQuery(statement, query) : query; `
   
   incorporating ^




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org