You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by bu...@apache.org on 2010/12/10 05:53:38 UTC

DO NOT REPLY [Bug 50450] New: [patch] use System.array copy in jacobi solver as, being native, is more performant.

https://issues.apache.org/bugzilla/show_bug.cgi?id=50450

           Summary: [patch] use System.array copy in jacobi solver as,
                    being native, is more performant.
           Product: JMeter
           Version: Nightly (Please specify date)
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HTTP
        AssignedTo: notifications@jakarta.apache.org
        ReportedBy: dbrosius@apache.org


Spline3.java

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org

DO NOT REPLY [Bug 50450] [patch] use System.array copy in jacobi solver as, being native, is more performant.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50450

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Sebb <se...@apache.org> 2010-12-14 15:48:58 EST ---
Thanks, applied - except I had to change _rs => _rS in the second part of the
patch.

URL: http://svn.apache.org/viewvc?rev=1049262&view=rev
Log:
Bug 50450 - use System.array copy in jacobi solver as, being native, is more
performant.

Modified:
  
jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/Spline3.java
   jakarta/jmeter/trunk/xdocs/changes.xml

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org

DO NOT REPLY [Bug 50450] [patch] use System.array copy in jacobi solver as, being native, is more performant.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50450

--- Comment #3 from Dave Brosius <db...@apache.org> 2010-12-10 07:52:56 EST ---
Created an attachment (id=26391)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26391)
add arraycopy for second loop

converting newX[i] = _B[i]; to a arraycopy probably is counter productive given
that the loop is used for other things as well, but the third one is certainly
valid.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org

DO NOT REPLY [Bug 50450] [patch] use System.array copy in jacobi solver as, being native, is more performant.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50450

--- Comment #1 from Dave Brosius <db...@apache.org> 2010-12-09 23:54:37 EST ---
Created an attachment (id=26390)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26390)
use System.arraycopy

rather than manual copying.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org

DO NOT REPLY [Bug 50450] [patch] use System.array copy in jacobi solver as, being native, is more performant.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50450

--- Comment #2 from Sebb <se...@apache.org> 2010-12-10 07:22:35 EST ---
Can't one do the same to the first loop entry? i.e:

      newX[i] = _B[i];

As far as I can tell, it does not matter if newX is overwritten before starting
the loop.

Likewise at the end, there is another copy loop:

        for (i = 0; i < _n; i++) {
            _rS[i + 1] = newX[i];
        }

which might benefit from System.arraycopy.

If FindBugs did not find the last one, then perhaps it needs tweaking ;-)
The second one is perhaps harder (but even better if Findbugs can find it).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org