[jira] Commented: (WINK-28) Use published org.json dependencies instead of duplicating sources

["Jason Dillon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WINK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726054#action_12726054 ] 

Jason Dillon commented on WINK-28:
----------------------------------

Some more context...

So compile wise, using 20080701 works, but some tests fail, looks like an ordering issue in what is expected from the response.

For example:

JsonProviderTest.testGetJsonFeed with this dep returns:

{noformat}
{"feed": {
 "@xmlns": {"$": "http://www.w3.org/2005/Atom"},
 "id": {
   "$": "id",
   "@xmlns": {"$": "http://www.w3.org/2005/Atom"}
 },
 "title": {
   "$": "title",
   "@type": "text",
   "@xmlns": {"$": "http://www.w3.org/2005/Atom"}
 }
}}
{noformat}

But the test expects it to be:

{noformat}
{"feed": {
 "@xmlns": {"$": "http:\/\/www.w3.org\/2005\/Atom"},
 "id": {
   "@xmlns": {"$": "http:\/\/www.w3.org\/2005\/Atom"},
   "$": "id"
 },
 "title": {
   "@type": "text",
   "@xmlns": {"$": "http:\/\/www.w3.org\/2005\/Atom"},
   "$": "title"
 }
}}
{noformat}

Both look valid to me, unless I'm missing something.  My guess is that the tests should probably be augmented to be agnostic on the order of keys in the map returned... ?


> Use published org.json dependencies instead of duplicating sources
> ------------------------------------------------------------------
>
>                 Key: WINK-28
>                 URL: https://issues.apache.org/jira/browse/WINK-28
>             Project: Wink
>          Issue Type: Improvement
>          Components: Common, Server
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>             Fix For: 0.1
>
>         Attachments: WINK-28.patch
>
>
> The following sources do not have the standard ASL 2.0 legal header on them:
>  * wink-common/src/main/java/org/apache/wink/common/model/json/JSONArray.java
>  * wink-common/src/main/java/org/apache/wink/common/model/json/JSONObject.java
>  * wink-common/src/main/java/org/apache/wink/common/model/json/JSONStringer.java
>  * wink-common/src/main/java/org/apache/wink/common/model/json/JSONTokener.java
>  * wink-common/src/main/java/org/apache/wink/common/model/json/JSONWriter.java
> instead they have:
> {noformat}
> /*
> Copyright (c) 2002 JSON.org
> Permission is hereby granted, free of charge, to any person obtaining a copy
> of this software and associated documentation files (the "Software"), to deal
> in the Software without restriction, including without limitation the rights
> to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> copies of the Software, and to permit persons to whom the Software is
> furnished to do so, subject to the following conditions:
> The above copyright notice and this permission notice shall be included in all
> copies or substantial portions of the Software.
> The Software shall be used for Good, not Evil.
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> SOFTWARE.
> */
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.