You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "kingsword09 (via GitHub)" <gi...@apache.org> on 2025/06/25 06:22:26 UTC
[PR] fix(bindings/nodejs): ListOptions test list with deleted [opendal]
kingsword09 opened a new pull request, #6335:
URL: https://github.com/apache/opendal/pull/6335
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
fix ListOptions list with deleted test
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking-changes` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(bindings/nodejs): ListOptions test list with deleted [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6335:
URL: https://github.com/apache/opendal/pull/6335#issuecomment-3003828758
> @Xuanwo How do I trigger the `COS` service test in GitHub Actions? After the merge, when the `COS` test was triggered, my `list with deleted` test had issues.
Hi, GitHub doesn't allow forked repositories to trigger tests that require credentials, so this isn't possible. The only way is to become an opendal committer.
According to the `cos` test, I personally believe it's an issue with the service itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(bindings/nodejs): ListOptions test list with deleted [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #6335:
URL: https://github.com/apache/opendal/pull/6335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(bindings/nodejs): ListOptions test list with deleted [opendal]
Posted by "kingsword09 (via GitHub)" <gi...@apache.org>.
kingsword09 commented on PR #6335:
URL: https://github.com/apache/opendal/pull/6335#issuecomment-3003850394
> > @Xuanwo How do I trigger the `COS` service test in GitHub Actions? After the merge, when the `COS` test was triggered, my `list with deleted` test had issues.
>
> Hi, GitHub doesn't allow forked repositories to trigger tests that require credentials, so this isn't possible. The only way is to become an opendal committer.
>
> According to the `cos` test, I personally believe it's an issue with the service itself.
@Xuanwo Then this list_with_deleted test whether you want to take a look again, it always feels a bit wrong，Is it right to list_with(file_path) instead of list_with(parent)?
https://github.com/apache/opendal/blob/6ad97f86cc76bf11df717d1a66f2b4628576dd0c/core/tests/behavior/async_list.rs#L619-L651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(bindings/nodejs): ListOptions test list with deleted [opendal]
Posted by "kingsword09 (via GitHub)" <gi...@apache.org>.
kingsword09 commented on PR #6335:
URL: https://github.com/apache/opendal/pull/6335#issuecomment-3003725275
@Xuanwo How can I trigger the `COS` service test? After the merge, when the `COS` test was triggered, my `list with deleted` test had issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(bindings/nodejs): ListOptions test list with deleted [opendal]
Posted by "kingsword09 (via GitHub)" <gi...@apache.org>.
kingsword09 commented on PR #6335:
URL: https://github.com/apache/opendal/pull/6335#issuecomment-3004656643
> > Then this list_with_deleted test whether you want to take a look again, it always feels a bit wrong，Is it right to list_with(file_path) instead of list_with(parent)?
>
> Yes, it's expected to list the `file_path` itself. We should see the file itself but is deleted.
Got it, thanks for confirming!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(bindings/nodejs): ListOptions test list with deleted [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6335:
URL: https://github.com/apache/opendal/pull/6335#issuecomment-3004646587
> Then this list_with_deleted test whether you want to take a look again, it always feels a bit wrong，Is it right to list_with(file_path) instead of list_with(parent)?
Yes, it's expected to list the `file_path` itself. We should see the file itself but is deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org