You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/27 07:04:47 UTC
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request
#4972: Fix getTableShardingStrategy return databaseShardingStrategy problem
KomachiSion opened a new pull request #4972: Fix getTableShardingStrategy return databaseShardingStrategy problem
URL: https://github.com/apache/incubator-shardingsphere/pull/4972
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #4972:
Fix getTableShardingStrategy return databaseShardingStrategy problem
Posted by GitBox <gi...@apache.org>.
cherrylzhao merged pull request #4972: Fix getTableShardingStrategy return databaseShardingStrategy problem
URL: https://github.com/apache/incubator-shardingsphere/pull/4972
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4972: Fix
getTableShardingStrategy return databaseShardingStrategy problem
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4972: Fix getTableShardingStrategy return databaseShardingStrategy problem
URL: https://github.com/apache/incubator-shardingsphere/pull/4972#issuecomment-604858584
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4972?src=pr&el=h1) Report
> Merging [#4972](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4972?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/622a035ee9737b7b0407712d898325fcb7b40780&el=desc) will **not change** coverage by `%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4972?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4972 +/- ##
=========================================
Coverage 54.30% 54.30%
Complexity 443 443
=========================================
Files 1143 1143
Lines 20525 20525
Branches 3763 3762 -1
=========================================
Hits 11147 11147
Misses 8672 8672
Partials 706 706
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4972?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4972/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `74.34% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4972?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4972?src=pr&el=footer). Last update [622a035...d8015f7](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4972?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4972: Fix
getTableShardingStrategy return databaseShardingStrategy problem
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4972: Fix getTableShardingStrategy return databaseShardingStrategy problem
URL: https://github.com/apache/incubator-shardingsphere/pull/4972#issuecomment-604856680
## Pull Request Test Coverage Report for [Build 2259](https://coveralls.io/builds/29654889)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.812%**
---
| Totals | [](https://coveralls.io/builds/29654889) |
| :-- | --: |
| Change from base [Build 1189](https://coveralls.io/builds/29654503): | 0.0% |
| Covered Lines: | 11866 |
| Relevant Lines: | 20525 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4972: Fix getTableShardingStrategy return databaseShardingStrategy problem
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4972: Fix getTableShardingStrategy return databaseShardingStrategy problem
URL: https://github.com/apache/incubator-shardingsphere/pull/4972#issuecomment-604856680
## Pull Request Test Coverage Report for [Build 10642](https://coveralls.io/builds/29655070)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.005%**) to **57.808%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29655070/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29655070) |
| :-- | --: |
| Change from base [Build 1189](https://coveralls.io/builds/29654503): | -0.005% |
| Covered Lines: | 11865 |
| Relevant Lines: | 20525 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services