You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2015/07/14 20:09:52 UTC

[GitHub] incubator-brooklyn pull request: Update brooklyn-node.yaml example

GitHub user bostko opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/744

    Update brooklyn-node.yaml example

    Include the more reasonable `brooklynnode.distro.uploadurl` attribute in the `brooklyn-node.yaml` example

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bostko/incubator-brooklyn doc_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #744
    
----
commit ffda1badc4aaafb12422fb58aa717bdc7a39f565
Author: Valentin Aitken <va...@cloudsoftcorp.com>
Date:   2015-07-14T18:07:11Z

    Update brooklyn-node.yaml example

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Update brooklyn-node.yaml example

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/744#discussion_r34603774
  
    --- Diff: software/base/src/main/resources/brooklyn/entity/brooklynnode/brooklyn-node.yaml ---
    @@ -22,8 +22,8 @@ name: Example Brooklyn Node
     services:
     - type: brooklyn.entity.brooklynnode.BrooklynNode
     
    -  ## to use a local file, specify something such as the following:   [BROOKLYN_VERSION_BELOW] 
    -  # downloadUrl: file:///tmp/brooklyn-dist-0.8.0-SNAPSHOT-dist.tar.gz
    +  ## URL for uploading the brooklyn distro (retrieved locally and pushed to remote install location)
    --- End diff --
    
    `BROOKLYN_VERSION_BELOW` is a marker, pointing out that the version on the line below should be updated when changing the project version. To avoid having a stale version you can either get the marker back in or use some generic text in the url (i.e. `brooklyn-dist-<version>-dist.tar.gz`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Update brooklyn-node.yaml example

Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/744#discussion_r34604623
  
    --- Diff: software/base/src/main/resources/brooklyn/entity/brooklynnode/brooklyn-node.yaml ---
    @@ -22,8 +22,8 @@ name: Example Brooklyn Node
     services:
     - type: brooklyn.entity.brooklynnode.BrooklynNode
     
    -  ## to use a local file, specify something such as the following:   [BROOKLYN_VERSION_BELOW] 
    -  # downloadUrl: file:///tmp/brooklyn-dist-0.8.0-SNAPSHOT-dist.tar.gz
    +  ## URL for uploading the brooklyn distro (retrieved locally and pushed to remote install location)
    --- End diff --
    
    Fixed. Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Update brooklyn-node.yaml example

Posted by mikezaccardo <gi...@git.apache.org>.
Github user mikezaccardo commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/744#issuecomment-121330695
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Update brooklyn-node.yaml example

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/744


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Update brooklyn-node.yaml example

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/744#issuecomment-121774478
  
    Thanks @bostko - merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---