You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Akshay Rai <ak...@gmail.com> on 2015/09/10 18:07:06 UTC
Request for a review - OOZIE-2346
Hi Oozie Committers,
I have uploaded a patch to OOZIE-2346 and the test-build has run with one
error. I don't think the error is related to the patch.
The patch adds information of sub-workflows and the job console url along
with other information in *oozie.job.info <http://oozie.job.info> *to the
job conf*. *This will be injected only when *oozie.action.jobinfo.enable*
is enabled in oozie-site.xml.
Could I get a review for it?
JIRA: https://issues.apache.org/jira/browse/OOZIE-2346
RB: https://reviews.apache.org/r/38088/
Regards,
Akshay
Re: Request for a review - OOZIE-2346
Posted by Akshay Rai <ak...@gmail.com>.
Eagerly waiting for a rb review. Could someone have a look at it?
JIRA: https://issues.apache.org/jira/browse/OOZIE-2346
RB: https://reviews.apache.org/r/38088
I will upload the updated patch to the jira after the RB is reviewed.
-Akshay
On Tue, Sep 29, 2015 at 5:51 PM, Akshay Rai <ak...@gmail.com> wrote:
> I have made a minor correction of setting the super parent id to the
> coordinator id rather than the workflow id when submitted through a
> coordinator.
>
> Waiting for a review.
> RB: https://reviews.apache.org/r/38088
>
> Thanks,
> - Akshay
>
> On Tue, Sep 22, 2015 at 1:35 PM, Akshay Rai <ak...@gmail.com> wrote:
>
>> Purshotam, I have addressed your comments.
>>
>> https://reviews.apache.org/r/38088/
>>
>> -Akshay
>>
>> On Mon, Sep 21, 2015 at 5:30 PM, Akshay Rai <ak...@gmail.com> wrote:
>>
>>> Thanks Purushotam for the review. Will address the changes soon.
>>>
>>> -Akshay
>>>
>>> On Mon, Sep 21, 2015 at 10:55 AM, Akshay Rai <ak...@gmail.com> wrote:
>>>
>>>> Eagerly waiting for a review.
>>>>
>>>> -Akshay
>>>>
>>>> On Tue, Sep 15, 2015 at 9:07 AM, Akshay Rai <ak...@gmail.com> wrote:
>>>>
>>>>> A gentle reminder.
>>>>>
>>>>> On Thu, Sep 10, 2015 at 10:35 PM, Purshotam Shah <
>>>>> purushah@yahoo-inc.com.invalid> wrote:
>>>>>
>>>>>> Thanks Akshay for putting patch.. I will review it.
>>>>>>
>>>>>> From: Akshay Rai <ak...@gmail.com>
>>>>>> To: dev@oozie.apache.org
>>>>>> Sent: Thursday, September 10, 2015 9:07 AM
>>>>>> Subject: Request for a review - OOZIE-2346
>>>>>>
>>>>>> Hi Oozie Committers,
>>>>>>
>>>>>> I have uploaded a patch to OOZIE-2346 and the test-build has run with
>>>>>> one
>>>>>> error. I don't think the error is related to the patch.
>>>>>>
>>>>>> The patch adds information of sub-workflows and the job console url
>>>>>> along
>>>>>> with other information in *oozie.job.info <http://oozie.job.info>
>>>>>> *to the
>>>>>> job conf*. *This will be injected only when
>>>>>> *oozie.action.jobinfo.enable*
>>>>>> is enabled in oozie-site.xml.
>>>>>>
>>>>>> Could I get a review for it?
>>>>>>
>>>>>> JIRA: https://issues.apache.org/jira/browse/OOZIE-2346
>>>>>> RB: https://reviews.apache.org/r/38088/
>>>>>>
>>>>>> Regards,
>>>>>> Akshay
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>
Re: Request for a review - OOZIE-2346
Posted by Akshay Rai <ak...@gmail.com>.
I have made a minor correction of setting the super parent id to the
coordinator id rather than the workflow id when submitted through a
coordinator.
Waiting for a review.
RB: https://reviews.apache.org/r/38088
Thanks,
- Akshay
On Tue, Sep 22, 2015 at 1:35 PM, Akshay Rai <ak...@gmail.com> wrote:
> Purshotam, I have addressed your comments.
>
> https://reviews.apache.org/r/38088/
>
> -Akshay
>
> On Mon, Sep 21, 2015 at 5:30 PM, Akshay Rai <ak...@gmail.com> wrote:
>
>> Thanks Purushotam for the review. Will address the changes soon.
>>
>> -Akshay
>>
>> On Mon, Sep 21, 2015 at 10:55 AM, Akshay Rai <ak...@gmail.com> wrote:
>>
>>> Eagerly waiting for a review.
>>>
>>> -Akshay
>>>
>>> On Tue, Sep 15, 2015 at 9:07 AM, Akshay Rai <ak...@gmail.com> wrote:
>>>
>>>> A gentle reminder.
>>>>
>>>> On Thu, Sep 10, 2015 at 10:35 PM, Purshotam Shah <
>>>> purushah@yahoo-inc.com.invalid> wrote:
>>>>
>>>>> Thanks Akshay for putting patch.. I will review it.
>>>>>
>>>>> From: Akshay Rai <ak...@gmail.com>
>>>>> To: dev@oozie.apache.org
>>>>> Sent: Thursday, September 10, 2015 9:07 AM
>>>>> Subject: Request for a review - OOZIE-2346
>>>>>
>>>>> Hi Oozie Committers,
>>>>>
>>>>> I have uploaded a patch to OOZIE-2346 and the test-build has run with
>>>>> one
>>>>> error. I don't think the error is related to the patch.
>>>>>
>>>>> The patch adds information of sub-workflows and the job console url
>>>>> along
>>>>> with other information in *oozie.job.info <http://oozie.job.info> *to
>>>>> the
>>>>> job conf*. *This will be injected only when
>>>>> *oozie.action.jobinfo.enable*
>>>>> is enabled in oozie-site.xml.
>>>>>
>>>>> Could I get a review for it?
>>>>>
>>>>> JIRA: https://issues.apache.org/jira/browse/OOZIE-2346
>>>>> RB: https://reviews.apache.org/r/38088/
>>>>>
>>>>> Regards,
>>>>> Akshay
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>
Re: Request for a review - OOZIE-2346
Posted by Akshay Rai <ak...@gmail.com>.
Purshotam, I have addressed your comments.
https://reviews.apache.org/r/38088/
-Akshay
On Mon, Sep 21, 2015 at 5:30 PM, Akshay Rai <ak...@gmail.com> wrote:
> Thanks Purushotam for the review. Will address the changes soon.
>
> -Akshay
>
> On Mon, Sep 21, 2015 at 10:55 AM, Akshay Rai <ak...@gmail.com> wrote:
>
>> Eagerly waiting for a review.
>>
>> -Akshay
>>
>> On Tue, Sep 15, 2015 at 9:07 AM, Akshay Rai <ak...@gmail.com> wrote:
>>
>>> A gentle reminder.
>>>
>>> On Thu, Sep 10, 2015 at 10:35 PM, Purshotam Shah <
>>> purushah@yahoo-inc.com.invalid> wrote:
>>>
>>>> Thanks Akshay for putting patch.. I will review it.
>>>>
>>>> From: Akshay Rai <ak...@gmail.com>
>>>> To: dev@oozie.apache.org
>>>> Sent: Thursday, September 10, 2015 9:07 AM
>>>> Subject: Request for a review - OOZIE-2346
>>>>
>>>> Hi Oozie Committers,
>>>>
>>>> I have uploaded a patch to OOZIE-2346 and the test-build has run with
>>>> one
>>>> error. I don't think the error is related to the patch.
>>>>
>>>> The patch adds information of sub-workflows and the job console url
>>>> along
>>>> with other information in *oozie.job.info <http://oozie.job.info> *to
>>>> the
>>>> job conf*. *This will be injected only when
>>>> *oozie.action.jobinfo.enable*
>>>> is enabled in oozie-site.xml.
>>>>
>>>> Could I get a review for it?
>>>>
>>>> JIRA: https://issues.apache.org/jira/browse/OOZIE-2346
>>>> RB: https://reviews.apache.org/r/38088/
>>>>
>>>> Regards,
>>>> Akshay
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>
Re: Request for a review - OOZIE-2346
Posted by Akshay Rai <ak...@gmail.com>.
Thanks Purushotam for the review. Will address the changes soon.
-Akshay
On Mon, Sep 21, 2015 at 10:55 AM, Akshay Rai <ak...@gmail.com> wrote:
> Eagerly waiting for a review.
>
> -Akshay
>
> On Tue, Sep 15, 2015 at 9:07 AM, Akshay Rai <ak...@gmail.com> wrote:
>
>> A gentle reminder.
>>
>> On Thu, Sep 10, 2015 at 10:35 PM, Purshotam Shah <
>> purushah@yahoo-inc.com.invalid> wrote:
>>
>>> Thanks Akshay for putting patch.. I will review it.
>>>
>>> From: Akshay Rai <ak...@gmail.com>
>>> To: dev@oozie.apache.org
>>> Sent: Thursday, September 10, 2015 9:07 AM
>>> Subject: Request for a review - OOZIE-2346
>>>
>>> Hi Oozie Committers,
>>>
>>> I have uploaded a patch to OOZIE-2346 and the test-build has run with one
>>> error. I don't think the error is related to the patch.
>>>
>>> The patch adds information of sub-workflows and the job console url along
>>> with other information in *oozie.job.info <http://oozie.job.info> *to
>>> the
>>> job conf*. *This will be injected only when *oozie.action.jobinfo.enable*
>>> is enabled in oozie-site.xml.
>>>
>>> Could I get a review for it?
>>>
>>> JIRA: https://issues.apache.org/jira/browse/OOZIE-2346
>>> RB: https://reviews.apache.org/r/38088/
>>>
>>> Regards,
>>> Akshay
>>>
>>>
>>>
>>>
>>
>>
>
Re: Request for a review - OOZIE-2346
Posted by Akshay Rai <ak...@gmail.com>.
Eagerly waiting for a review.
-Akshay
On Tue, Sep 15, 2015 at 9:07 AM, Akshay Rai <ak...@gmail.com> wrote:
> A gentle reminder.
>
> On Thu, Sep 10, 2015 at 10:35 PM, Purshotam Shah <
> purushah@yahoo-inc.com.invalid> wrote:
>
>> Thanks Akshay for putting patch.. I will review it.
>>
>> From: Akshay Rai <ak...@gmail.com>
>> To: dev@oozie.apache.org
>> Sent: Thursday, September 10, 2015 9:07 AM
>> Subject: Request for a review - OOZIE-2346
>>
>> Hi Oozie Committers,
>>
>> I have uploaded a patch to OOZIE-2346 and the test-build has run with one
>> error. I don't think the error is related to the patch.
>>
>> The patch adds information of sub-workflows and the job console url along
>> with other information in *oozie.job.info <http://oozie.job.info> *to the
>> job conf*. *This will be injected only when *oozie.action.jobinfo.enable*
>> is enabled in oozie-site.xml.
>>
>> Could I get a review for it?
>>
>> JIRA: https://issues.apache.org/jira/browse/OOZIE-2346
>> RB: https://reviews.apache.org/r/38088/
>>
>> Regards,
>> Akshay
>>
>>
>>
>>
>
>
Re: Request for a review - OOZIE-2346
Posted by Akshay Rai <ak...@gmail.com>.
A gentle reminder.
On Thu, Sep 10, 2015 at 10:35 PM, Purshotam Shah <
purushah@yahoo-inc.com.invalid> wrote:
> Thanks Akshay for putting patch.. I will review it.
>
> From: Akshay Rai <ak...@gmail.com>
> To: dev@oozie.apache.org
> Sent: Thursday, September 10, 2015 9:07 AM
> Subject: Request for a review - OOZIE-2346
>
> Hi Oozie Committers,
>
> I have uploaded a patch to OOZIE-2346 and the test-build has run with one
> error. I don't think the error is related to the patch.
>
> The patch adds information of sub-workflows and the job console url along
> with other information in *oozie.job.info <http://oozie.job.info> *to the
> job conf*. *This will be injected only when *oozie.action.jobinfo.enable*
> is enabled in oozie-site.xml.
>
> Could I get a review for it?
>
> JIRA: https://issues.apache.org/jira/browse/OOZIE-2346
> RB: https://reviews.apache.org/r/38088/
>
> Regards,
> Akshay
>
>
>
>
Re: Request for a review - OOZIE-2346
Posted by Purshotam Shah <pu...@yahoo-inc.com.INVALID>.
Thanks Akshay for putting patch.. I will review it.
From: Akshay Rai <ak...@gmail.com>
To: dev@oozie.apache.org
Sent: Thursday, September 10, 2015 9:07 AM
Subject: Request for a review - OOZIE-2346
Hi Oozie Committers,
I have uploaded a patch to OOZIE-2346 and the test-build has run with one
error. I don't think the error is related to the patch.
The patch adds information of sub-workflows and the job console url along
with other information in *oozie.job.info <http://oozie.job.info> *to the
job conf*. *This will be injected only when *oozie.action.jobinfo.enable*
is enabled in oozie-site.xml.
Could I get a review for it?
JIRA: https://issues.apache.org/jira/browse/OOZIE-2346
RB: https://reviews.apache.org/r/38088/
Regards,
Akshay