[VOTE] Release Apache Sling JCR Content Parser 1.0.0

[Stefan Seifert <ss...@pro-vision.de>]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12339767

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1673/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1673 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

stefan

RE: [VOTE] Release Apache Sling JCR Content Parser 1.0.0

[Stefan Seifert <ss...@pro-vision.de>]

well, the enum value is released as part of the public API, so we cannot change it now without breaking the API.
it makes sense to update the Javadoc to document what exact format is expected here (you can do it directly).

if we later want to add other formats we have to create new enum values.

my primary concern was to support the format that is used by default by the package manager files (this extended docview), and I assume this format will not change. not sure if there is a pressing need for the other formats.

stefan


>-----Original Message-----
>From: Konrad Windszus [mailto:konrad_w@gmx.de]
>Sent: Thursday, March 23, 2017 2:16 PM
>To: dev@sling.apache.org
>Subject: Re: [VOTE] Release Apache Sling JCR Content Parser 1.0.0
>
>@Stefan: I see that you just closed
>https://issues.apache.org/jira/browse/SLING-6592 and that this has
>obviously been released.
>Can you still quickly comment on my feedback given below? Do you want me
>to open a dedicated ticket in JIRA for that, so that we can fix that in
>a new version?
>
>Thanks,
>Konrad
>
>> On 21 Mar 2017, at 12:08, Konrad Windszus <ko...@gmx.de> wrote:
>>
>> I am not sure that JCR_XML is a good name for the Extended DocView
>format supported by FileVault
>(https://github.com/apache/sling/blob/trunk/bundles/jcr/contentparser/sr
>c/main/java/org/apache/sling/jcr/contentparser/ContentType.java#L37, )
>> I would rather prefer something like VAULT_EXT_DOCVIEW
>(https://issues.apache.org/jira/browse/JCRVLT-132).
>> In the future we may want to support JCRs DocumentView and SystemView
>in addition.
>> So I would prefer if we would rename that enum value.
>> Sorry for noticing so late.
>>
>>> On 21 Mar 2017, at 11:42, Carsten Ziegeler <cz...@apache.org>
>wrote:
>>>
>>> +1
>>>
>>>
>>>
>>> --
>>> Carsten Ziegeler
>>> Adobe Research Switzerland
>>> cziegeler@apache.org
>>
>

Re: [VOTE] Release Apache Sling JCR Content Parser 1.0.0

[Konrad Windszus <ko...@gmx.de>]

@Stefan: I see that you just closed https://issues.apache.org/jira/browse/SLING-6592 and that this has obviously been released.
Can you still quickly comment on my feedback given below? Do you want me to open a dedicated ticket in JIRA for that, so that we can fix that in a new version?

Thanks,
Konrad

> On 21 Mar 2017, at 12:08, Konrad Windszus <ko...@gmx.de> wrote:
> 
> I am not sure that JCR_XML is a good name for the Extended DocView format supported by FileVault (https://github.com/apache/sling/blob/trunk/bundles/jcr/contentparser/src/main/java/org/apache/sling/jcr/contentparser/ContentType.java#L37, )
> I would rather prefer something like VAULT_EXT_DOCVIEW (https://issues.apache.org/jira/browse/JCRVLT-132).
> In the future we may want to support JCRs DocumentView and SystemView in addition.
> So I would prefer if we would rename that enum value.
> Sorry for noticing so late.
> 
>> On 21 Mar 2017, at 11:42, Carsten Ziegeler <cz...@apache.org> wrote:
>> 
>> +1
>> 
>> 
>> 
>> -- 
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziegeler@apache.org
> 

Re: [VOTE] Release Apache Sling JCR Content Parser 1.0.0

[Carsten Ziegeler <cz...@apache.org>]

+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

RE: [VOTE] Release Apache Sling JCR Content Parser 1.0.0

[Stefan Seifert <ss...@pro-vision.de>]

+1

Re: [VOTE] Release Apache Sling JCR Content Parser 1.0.0

[Robert Munteanu <ro...@apache.org>]

On Mon, 2017-03-20 at 11:21 +0000, Stefan Seifert wrote:
> Please vote to approve this release:

+1

Robert