You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "lgoldstein (via GitHub)" <gi...@apache.org> on 2023/03/21 18:13:04 UTC
[GitHub] [mina-sshd] lgoldstein opened a new pull request, #342: Replaced jdk15on Bouncycastle artifacts with jdk18on ones
lgoldstein opened a new pull request, #342:
URL: https://github.com/apache/mina-sshd/pull/342
In order to keep up with the latest fixes - seems to be fully backward compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] lgoldstein closed pull request #342: Replaced jdk15on Bouncycastle artifacts with jdk18on ones
Posted by "lgoldstein (via GitHub)" <gi...@apache.org>.
lgoldstein closed pull request #342: Replaced jdk15on Bouncycastle artifacts with jdk18on ones
URL: https://github.com/apache/mina-sshd/pull/342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] lgoldstein commented on a diff in pull request #342: Replaced jdk15on Bouncycastle artifacts with jdk18on ones
Posted by "lgoldstein (via GitHub)" <gi...@apache.org>.
lgoldstein commented on code in PR #342:
URL: https://github.com/apache/mina-sshd/pull/342#discussion_r1147092780
##########
pom.xml:
##########
@@ -105,7 +105,11 @@
<min.required.maven.version>3.5.0</min.required.maven.version>
<groovy.version>3.0.11</groovy.version>
- <bouncycastle.version>1.70</bouncycastle.version>
+ <bouncycastle.version>1.72</bouncycastle.version>
+ <!-- NOTE: upgrading beyond this version causes
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] lgoldstein commented on a diff in pull request #342: Replaced jdk15on Bouncycastle artifacts with jdk18on ones
Posted by "lgoldstein (via GitHub)" <gi...@apache.org>.
lgoldstein commented on code in PR #342:
URL: https://github.com/apache/mina-sshd/pull/342#discussion_r1147090991
##########
pom.xml:
##########
@@ -105,7 +105,11 @@
<min.required.maven.version>3.5.0</min.required.maven.version>
<groovy.version>3.0.11</groovy.version>
- <bouncycastle.version>1.70</bouncycastle.version>
+ <bouncycastle.version>1.72</bouncycastle.version>
+ <!-- NOTE: upgrading beyond this version causes
Review Comment:
Will do in a future commit...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #342: Replaced jdk15on Bouncycastle artifacts with jdk18on ones
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on code in PR #342:
URL: https://github.com/apache/mina-sshd/pull/342#discussion_r1143847679
##########
pom.xml:
##########
@@ -105,7 +105,11 @@
<min.required.maven.version>3.5.0</min.required.maven.version>
<groovy.version>3.0.11</groovy.version>
- <bouncycastle.version>1.70</bouncycastle.version>
+ <bouncycastle.version>1.72</bouncycastle.version>
+ <!-- NOTE: upgrading beyond this version causes
Review Comment:
Could you please clarify "...beyond this version _of slf4j_...". I first thought the comment referred to bouncycastle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org