You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Andrew Poland (JIRA)" <ji...@apache.org> on 2012/06/18 19:01:43 UTC
[jira] [Created] (HIVE-3152) Disallow certain character patterns in
partition names
Andrew Poland created HIVE-3152:
-----------------------------------
Summary: Disallow certain character patterns in partition names
Key: HIVE-3152
URL: https://issues.apache.org/jira/browse/HIVE-3152
Project: Hive
Issue Type: New Feature
Components: Metastore
Reporter: Andrew Poland
Priority: Minor
New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
Match pattern is implemented as a regular expression
Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479637#comment-13479637 ]
Ashutosh Chauhan commented on HIVE-3152:
----------------------------------------
Cool. Totally agree. All we need is getHandler() as long as thats there, HCatalog will work fine.
And sorry for jumping on the jira so late. I will try to be more proactive on reading patches going forward.
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399552#comment-13399552 ]
Kevin Wilfong commented on HIVE-3152:
-------------------------------------
Andrew Poland submitted a diff for this change:
https://reviews.facebook.net/D3711
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Priority: Minor
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3152:
--------------------------------
Resolution: Fixed
Fix Version/s: 0.10.0
Status: Resolved (was: Patch Available)
Committed. Thanks Ivan.
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Fix For: 0.10.0
>
> Attachments: jira-3152.0.patch, jira-3152.1.patch, jira-3152.2.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433828#comment-13433828 ]
Kevin Wilfong commented on HIVE-3152:
-------------------------------------
Andrew, are you still working on this?
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Andrew Poland
> Priority: Minor
> Labels: api-addition, configuration-addition
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Gorbachev updated HIVE-3152:
---------------------------------
Status: Open (was: Patch Available)
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Sambavi Muthukrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sambavi Muthukrishnan reassigned HIVE-3152:
-------------------------------------------
Assignee: Ivan Gorbachev (was: Andrew Poland)
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: unicode.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Gorbachev updated HIVE-3152:
---------------------------------
Status: Open (was: Patch Available)
It has compilation errors
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch, jira-3152.1.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Gorbachev updated HIVE-3152:
---------------------------------
Status: Patch Available (was: Open)
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Andrew Poland
> Priority: Minor
> Labels: api-addition, configuration-addition
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479504#comment-13479504 ]
Kevin Wilfong commented on HIVE-3152:
-------------------------------------
Ashutosh, that change wasn't really the point of this JIRA, if Ivan's ok with it, I'd be happy leaving it out, and filing a JIRA to make that change later. If that change to ListenerEvent was removed, would this be compatible with HCatalog?
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Gorbachev updated HIVE-3152:
---------------------------------
Attachment: jira-3152.1.patch
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch, jira-3152.1.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399555#comment-13399555 ]
Kevin Wilfong commented on HIVE-3152:
-------------------------------------
I'm +1 on it and running tests.
I will give it some time though before committing to give others a chance to look.
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Andrew Poland
> Priority: Minor
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3152:
--------------------------------
Affects Version/s: 0.10.0
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Affects Versions: 0.10.0
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Fix For: 0.10.0
>
> Attachments: jira-3152.0.patch, jira-3152.1.patch, jira-3152.2.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480777#comment-13480777 ]
Ashutosh Chauhan commented on HIVE-3152:
----------------------------------------
+1
Kevin can you take care of running tests and committing it.
Ivan, on a side note for your future patches I will suggest to avoid whitespace changes, that makes it harder while reading patch to see where exactly important changes are.
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch, jira-3152.1.patch, jira-3152.2.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Gorbachev updated HIVE-3152:
---------------------------------
Attachment: unicode.patch
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Andrew Poland
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: unicode.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Gorbachev updated HIVE-3152:
---------------------------------
Status: Patch Available (was: Open)
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch, jira-3152.1.patch, jira-3152.2.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Gorbachev updated HIVE-3152:
---------------------------------
Attachment: jira-3152.0.patch
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3152:
--------------------------------
Assignee: Andrew Poland
Status: Patch Available (was: Open)
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Andrew Poland
> Priority: Minor
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Gorbachev updated HIVE-3152:
---------------------------------
Attachment: (was: unicode.patch)
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Gorbachev updated HIVE-3152:
---------------------------------
Status: Patch Available (was: Open)
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3152:
---------------------------------
Status: Open (was: Patch Available)
@Andrew: I left some comments on phabricator. Thanks.
On a related note, please file a JIRA ticket before creating a review request, and make sure to update the JIRA ticket with the location of the code review once it's created.
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Andrew Poland
> Priority: Minor
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479524#comment-13479524 ]
Ivan Gorbachev commented on HIVE-3152:
--------------------------------------
[~kevinwilfong] I agree. I think it's good idea to remove everything from this patch that doesn't belong to disallowing character patterns.
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476821#comment-13476821 ]
Ashutosh Chauhan commented on HIVE-3152:
----------------------------------------
In ListenerEvent.java
{code}
- public ListenerEvent(boolean status, HMSHandler handler) {
+ public ListenerEvent(boolean status) {
{code}
This is backward incompatible change. In particular, this will break HCatalog. Please hold off for commit.
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399581#comment-13399581 ]
Carl Steinbach commented on HIVE-3152:
--------------------------------------
I'm looking at this now.
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Andrew Poland
> Priority: Minor
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3152) Disallow certain character patterns in
partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Gorbachev updated HIVE-3152:
---------------------------------
Attachment: jira-3152.2.patch
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch, jira-3152.1.patch, jira-3152.2.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476574#comment-13476574 ]
Kevin Wilfong commented on HIVE-3152:
-------------------------------------
+1
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Attachments: jira-3152.0.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453173#comment-13453173 ]
Ivan Gorbachev commented on HIVE-3152:
--------------------------------------
I couldn't connect the diff to this task via `arc diff --jira HIVE-3152` so provide diff link in comment - https://reviews.facebook.net/D5235.
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Andrew Poland
> Assignee: Andrew Poland
> Priority: Minor
> Labels: api-addition, configuration-addition
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3152) Disallow certain character patterns
in partition names
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483754#comment-13483754 ]
Hudson commented on HIVE-3152:
------------------------------
Integrated in Hive-trunk-h0.21 #1755 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1755/])
HIVE-3152. Disallow certain character patterns in partition names. (Ivan Gorbachev via kevinwilfong) (Revision 1401784)
Result = FAILURE
kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401784
Files :
* /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
* /hive/trunk/conf/hive-default.xml.template
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/PartitionNameWhitelistPreEventListener.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateDatabaseEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateTableEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropDatabaseEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/LoadPartitionDoneEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreCreateTableEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropDatabaseEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropTableEvent.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreEventContext.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/PreLoadPartitionDoneEvent.java
* /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java
* /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
* /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestPartitionNameWhitelistPreEventHook.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/MetaDataExportListener.java
* /hive/trunk/ql/src/test/queries/clientnegative/add_partition_with_whitelist.q
* /hive/trunk/ql/src/test/queries/clientnegative/dynamic_partitions_with_whitelist.q
* /hive/trunk/ql/src/test/queries/clientpositive/add_partition_no_whitelist.q
* /hive/trunk/ql/src/test/queries/clientpositive/add_partition_with_whitelist.q
* /hive/trunk/ql/src/test/results/clientnegative/add_partition_with_whitelist.q.out
* /hive/trunk/ql/src/test/results/clientnegative/dynamic_partitions_with_whitelist.q.out
* /hive/trunk/ql/src/test/results/clientpositive/add_partition_no_whitelist.q.out
* /hive/trunk/ql/src/test/results/clientpositive/add_partition_with_whitelist.q.out
> Disallow certain character patterns in partition names
> ------------------------------------------------------
>
> Key: HIVE-3152
> URL: https://issues.apache.org/jira/browse/HIVE-3152
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Affects Versions: 0.10.0
> Reporter: Andrew Poland
> Assignee: Ivan Gorbachev
> Priority: Minor
> Labels: api-addition, configuration-addition
> Fix For: 0.10.0
>
> Attachments: jira-3152.0.patch, jira-3152.1.patch, jira-3152.2.patch
>
>
> New event listener to allow metastore to reject a partition name if it contains undesired character patterns such as unicode and commas.
> Match pattern is implemented as a regular expression
> Modifies append_partition to call a new MetaStorePreventListener implementation, PreAppendPartitionEvent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira