You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/04/18 17:20:53 UTC
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10097
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
KUDU-2365: [Java] Fix Gradle Artifacts
This resolves KUDU-2365 and adresses the remaining
Gradle artifact issues.
- Fixes the handling of compileUnshaded scope
- Adds NOTICE.txt and LICENSE.txt file to the jar manifest
- Moves SLF4J to provided scope in Flume, Spark, and
Mapreduce integrations where we want to use the version
on the existing classpath.
- Reduce the usage of large aggregate dependencies where
smaller more pointed ones are available
- Enables the /build directory on verify_jars.pl
Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
---
M build-support/verify_jars.pl
M java/gradle/artifacts.gradle
M java/gradle/shadow.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
16 files changed, 119 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/10097/1
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10097/1/java/kudu-client-tools/build.gradle
File java/kudu-client-tools/build.gradle:
http://gerrit.cloudera.org:8080/#/c/10097/1/java/kudu-client-tools/build.gradle@31
PS1, Line 31: // TODO: This pulls a lot of dependencies into the shaded jar
This is still an open item for this patch.
Gradle includes all the transitive dependencies. I think that is the right thing to do but creates a larger shaded jar than maven. It also fails verify_jars.pl because of the extra classes.
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 21 Apr 2018 14:39:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 5:
(3 comments)
Only got 1/2 way through this and need to go to meeting, but wanted to put up what I have.
http://gerrit.cloudera.org:8080/#/c/10097/1/java/gradle.properties
File java/gradle.properties:
http://gerrit.cloudera.org:8080/#/c/10097/1/java/gradle.properties@25
PS1, Line 25: mavenUrl = https://repository.apache.org/service/local/staging/deploy/maven2
Why are scmUrl and issueTrackerUrl removed?
http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties
File java/gradle.properties:
http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties@25
PS5, Line 25: mavenUrl = https://repository.apache.org/service/local/staging/deploy/maven2
I think it'd be better to call this something like 'publishUrl' or 'mavenPublishUrl' to make it clear that this URL is being fed into publishing.gradle, and isn't used for any other kind of dependency resolution (where it wouldn't be appropriate to use a staging repo).
http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties@41
PS5, Line 41: signing.gnupg.executable = gpg
Do we expect these properties to ever be modified? If not, it may be a bit more streamlined to put them in publishing.gradle to keep them close to where they are used.
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 16:57:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10097
to look at the new patch set (#5).
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
KUDU-2365: [Java] Fix Gradle Artifacts
This resolves KUDU-2365 and adresses the remaining
Gradle artifact issues.
- Fixes the handling of compileUnshaded scope
- Adds NOTICE.txt and LICENSE.txt file to the jar manifest
- Adds a licence section to the published poms
- Removes empty directories from jars
- Moves SLF4J to provided scope in Flume, Spark, and
Mapreduce integrations where we want to use the version
on the existing classpath.
- Reduce the usage of large aggregate dependencies where
smaller more pointed ones are available
- Prevents publishing of kudu-hive and kudu-jepsen
- Enables the /build directory on verify_jars.pl
- Tweaks the artifact signing flags and enables using
gpg-agent like the current Maven signing process
Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
---
M build-support/verify_jars.pl
M java/gradle.properties
M java/gradle/artifacts.gradle
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
20 files changed, 170 insertions(+), 73 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/10097/5
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10097/7/java/gradle/publishing.gradle
File java/gradle/publishing.gradle:
http://gerrit.cloudera.org:8080/#/c/10097/7/java/gradle/publishing.gradle@39
PS7, Line 39: propertyWithDefault
> They are only required if the maven repository requires them. Below is the
OK, I was thinking passing an empty string pair to authentication(..) would always be an issue. This is fine, if not.
http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle
File java/kudu-spark/build.gradle:
http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle@22
PS7, Line 22: compile(project(path: ":kudu-client", configuration: "shadow")) {
> I think I could globally exclude it from being shaded.
I think that would be good, if possible.
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 21:32:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10097/1/java/gradle.properties
File java/gradle.properties:
http://gerrit.cloudera.org:8080/#/c/10097/1/java/gradle.properties@25
PS1, Line 25: mavenUrl = https://repository.apache.org/service/local/staging/deploy/maven2
> Why are scmUrl and issueTrackerUrl removed?
They are not being used in the build so I didn't think it was worth keeping them.
Some projects will add them to their generated poms, but I thought that had minimal value given we add the project url in the pom and that's likely where we would want users and contributors to go for information.
http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties
File java/gradle.properties:
http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties@25
PS5, Line 25: mavenUrl = https://repository.apache.org/service/local/staging/deploy/maven2
> I think it'd be better to call this something like 'publishUrl' or 'mavenPu
Good idea. Will do.
http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties@41
PS5, Line 41: signing.gnupg.executable = gpg
> Do we expect these properties to ever be modified? If not, it may be a bit
If a user upgrades to gpg2 they may want to change these details. gpg2 is actually the default and these properties are set to use gpg as that's what our maven release process expected and seams more common.
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 17:22:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 02:27:53 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10097
to look at the new patch set (#9).
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
KUDU-2365: [Java] Fix Gradle Artifacts
This resolves KUDU-2365 and adresses the remaining
Gradle artifact issues.
- Fixes the handling of compileUnshaded scope
- Adds NOTICE.txt and LICENSE.txt file to the jar manifest
- Adds a licence section to the published poms
- Removes empty directories from jars
- Moves SLF4J to provided scope in Flume, Spark, and
Mapreduce integrations where we want to use the version
on the existing classpath.
- Reduce the usage of large aggregate dependencies where
smaller more pointed ones are available
- Prevents publishing of kudu-hive and kudu-jepsen
- Enables the /build directory on verify_jars.pl
- Tweaks the artifact signing flags and enables using
gpg-agent like the current Maven signing process
Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
---
M build-support/verify_jars.pl
M java/gradle.properties
M java/gradle/artifacts.gradle
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
20 files changed, 167 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/10097/9
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 9
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle
File java/kudu-spark/build.gradle:
http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle@22
PS7, Line 22: compile(project(path: ":kudu-client", configuration: "shadow")) {
> > I think I could globally exclude it from being shaded.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 21:44:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10097
to look at the new patch set (#2).
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
KUDU-2365: [Java] Fix Gradle Artifacts
This resolves KUDU-2365 and adresses the remaining
Gradle artifact issues.
- Fixes the handling of compileUnshaded scope
- Adds NOTICE.txt and LICENSE.txt file to the jar manifest
- Removes empty directories from jars
- Moves SLF4J to provided scope in Flume, Spark, and
Mapreduce integrations where we want to use the version
on the existing classpath.
- Reduce the usage of large aggregate dependencies where
smaller more pointed ones are available
- Prevents publishing of kudu-hive and kudu-jepsen
- Enables the /build directory on verify_jars.pl
Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
---
M build-support/verify_jars.pl
M java/gradle/artifacts.gradle
M java/gradle/shadow.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
18 files changed, 128 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/10097/2
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10097
to look at the new patch set (#6).
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
KUDU-2365: [Java] Fix Gradle Artifacts
This resolves KUDU-2365 and adresses the remaining
Gradle artifact issues.
- Fixes the handling of compileUnshaded scope
- Adds NOTICE.txt and LICENSE.txt file to the jar manifest
- Adds a licence section to the published poms
- Removes empty directories from jars
- Moves SLF4J to provided scope in Flume, Spark, and
Mapreduce integrations where we want to use the version
on the existing classpath.
- Reduce the usage of large aggregate dependencies where
smaller more pointed ones are available
- Prevents publishing of kudu-hive and kudu-jepsen
- Enables the /build directory on verify_jars.pl
- Tweaks the artifact signing flags and enables using
gpg-agent like the current Maven signing process
Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
---
M build-support/verify_jars.pl
M java/gradle.properties
M java/gradle/artifacts.gradle
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
20 files changed, 173 insertions(+), 74 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/10097/6
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 9
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 22:19:51 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10097
to look at the new patch set (#8).
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
KUDU-2365: [Java] Fix Gradle Artifacts
This resolves KUDU-2365 and adresses the remaining
Gradle artifact issues.
- Fixes the handling of compileUnshaded scope
- Adds NOTICE.txt and LICENSE.txt file to the jar manifest
- Adds a licence section to the published poms
- Removes empty directories from jars
- Moves SLF4J to provided scope in Flume, Spark, and
Mapreduce integrations where we want to use the version
on the existing classpath.
- Reduce the usage of large aggregate dependencies where
smaller more pointed ones are available
- Prevents publishing of kudu-hive and kudu-jepsen
- Enables the /build directory on verify_jars.pl
- Tweaks the artifact signing flags and enables using
gpg-agent like the current Maven signing process
Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
---
M build-support/verify_jars.pl
M java/gradle.properties
M java/gradle/artifacts.gradle
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
20 files changed, 167 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/10097/8
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
KUDU-2365: [Java] Fix Gradle Artifacts
This resolves KUDU-2365 and adresses the remaining
Gradle artifact issues.
- Fixes the handling of compileUnshaded scope
- Adds NOTICE.txt and LICENSE.txt file to the jar manifest
- Adds a licence section to the published poms
- Removes empty directories from jars
- Moves SLF4J to provided scope in Flume, Spark, and
Mapreduce integrations where we want to use the version
on the existing classpath.
- Reduce the usage of large aggregate dependencies where
smaller more pointed ones are available
- Prevents publishing of kudu-hive and kudu-jepsen
- Enables the /build directory on verify_jars.pl
- Tweaks the artifact signing flags and enables using
gpg-agent like the current Maven signing process
Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Reviewed-on: http://gerrit.cloudera.org:8080/10097
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M build-support/verify_jars.pl
M java/gradle.properties
M java/gradle/artifacts.gradle
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
20 files changed, 167 insertions(+), 71 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 10
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 9
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 7:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties
File java/gradle.properties:
http://gerrit.cloudera.org:8080/#/c/10097/5/java/gradle.properties@41
PS5, Line 41: # gpg-agent configuration for artifact signing.
> If a user upgrades to gpg2 they may want to change these details. gpg2 is a
SGTM
http://gerrit.cloudera.org:8080/#/c/10097/7/java/gradle/publishing.gradle
File java/gradle/publishing.gradle:
http://gerrit.cloudera.org:8080/#/c/10097/7/java/gradle/publishing.gradle@39
PS7, Line 39: propertyWithDefault
Are the username and password properties required? If so I think this shouldn't fallback to the empty string, because it will fail with a confusing error below about empty authentication creds. I imagine it will be easier to debug if you had a propert("mavenUsername") method which threw if it were undefined.
http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle
File java/kudu-spark/build.gradle:
http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle@22
PS7, Line 22: compile(project(path: ":kudu-client", configuration: "shadow")) {
Can you do the same trick you did in https://github.com/apache/kudu/commit/650e39e234142c69d4ff7adc56ad6359b790741b to only declare this exclusion once in build.gradle instead of every shaded jar? AFAICT you would want to do this wherever kudu-client is used in a shaded jar.
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 21:17:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 18 Apr 2018 19:28:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10097
to look at the new patch set (#4).
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
KUDU-2365: [Java] Fix Gradle Artifacts
This resolves KUDU-2365 and adresses the remaining
Gradle artifact issues.
- Fixes the handling of compileUnshaded scope
- Adds NOTICE.txt and LICENSE.txt file to the jar manifest
- Adds a licence section to the published poms
- Removes empty directories from jars
- Moves SLF4J to provided scope in Flume, Spark, and
Mapreduce integrations where we want to use the version
on the existing classpath.
- Reduce the usage of large aggregate dependencies where
smaller more pointed ones are available
- Prevents publishing of kudu-hive and kudu-jepsen
- Enables the /build directory on verify_jars.pl
- Tweaks the artifact signing flags and enables using
gpg-agent like the current Maven signing process
Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
---
M build-support/verify_jars.pl
M java/gradle.properties
M java/gradle/artifacts.gradle
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
20 files changed, 159 insertions(+), 68 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/10097/4
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10097
to look at the new patch set (#3).
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
KUDU-2365: [Java] Fix Gradle Artifacts
This resolves KUDU-2365 and adresses the remaining
Gradle artifact issues.
- Fixes the handling of compileUnshaded scope
- Adds NOTICE.txt and LICENSE.txt file to the jar manifest
- Removes empty directories from jars
- Moves SLF4J to provided scope in Flume, Spark, and
Mapreduce integrations where we want to use the version
on the existing classpath.
- Reduce the usage of large aggregate dependencies where
smaller more pointed ones are available
- Prevents publishing of kudu-hive and kudu-jepsen
- Enables the /build directory on verify_jars.pl
Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
---
M build-support/verify_jars.pl
M java/gradle/artifacts.gradle
M java/gradle/shadow.gradle
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-client/build.gradle
M java/kudu-client/pom.xml
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
M java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/build.gradle
M java/kudu-mapreduce/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
18 files changed, 128 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/10097/3
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 19 Apr 2018 18:58:38 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10097/8/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/10097/8/java/gradle/shadow.gradle@47
PS8, Line 47: revent's
> prevents
I don't know why I have been so trigger happy on apostrophes lately. Some weird bad muscle memory.
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 21:50:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10097/8/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/10097/8/java/gradle/shadow.gradle@47
PS8, Line 47: revent's
prevents
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 21:48:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 9: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 9
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 24 Apr 2018 00:46:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2365: [Java] Fix Gradle Artifacts
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10097 )
Change subject: KUDU-2365: [Java] Fix Gradle Artifacts
......................................................................
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10097/7/java/gradle/publishing.gradle
File java/gradle/publishing.gradle:
http://gerrit.cloudera.org:8080/#/c/10097/7/java/gradle/publishing.gradle@39
PS7, Line 39: propertyWithDefault
> Are the username and password properties required? If so I think this shou
They are only required if the maven repository requires them. Below is the error that is printed if you don't set a password and one is required:
Execution failed for task ':kudu-client:uploadArchives'.
> Could not publish configuration 'archives'
> Failed to retrieve remote metadata org.apache.kudu:kudu-client:1.8.0-SNAPSHOT/maven-metadata.xml: Could not transfer metadata org.apache.kudu:kudu-client:1.8.0-SNAPSHOT/maven-metadata.xml from/to remote
(https://repository.apache.org/service/local/staging/deploy/maven2): Not authorized , ReasonPhrase:Unauthorized.
http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle
File java/kudu-spark/build.gradle:
http://gerrit.cloudera.org:8080/#/c/10097/7/java/kudu-spark/build.gradle@22
PS7, Line 22: compile(project(path: ":kudu-client", configuration: "shadow")) {
> Can you do the same trick you did in https://github.com/apache/kudu/commit/
I think I could globally exclude it from being shaded. I can't globally exclude it like in the mentioned commit, because that would exclude it all together.
--
To view, visit http://gerrit.cloudera.org:8080/10097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef485eca7eebe55286ad5670452839bebb0c47e
Gerrit-Change-Number: 10097
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 23 Apr 2018 21:29:06 +0000
Gerrit-HasComments: Yes