You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Hyde <jh...@apache.org> on 2016/03/18 00:49:59 UTC
[VOTE] Release apache-calcite-1.7.0 (release candidate 0)
Hi all,
I have created a build for Apache Calcite 1.7.0, release candidate 0.
Thanks to everyone who has contributed to this release. This is the
first Calcite release since Avatica became an independent project, so
now includes Avatica as it would any other library, and also features
a brand new Cassandra adapter, and a slew of bug-fixes and
improvements to the planning process.
You can read the release notes here:
https://github.com/apache/calcite/blob/branch-1.7/site/_docs/history.md
The commit to be voted upon:
http://git-wip-us.apache.org/repos/asf/calcite/commit/8eebfc6d169421509e5d4792a18917fcb6c44efb
Its hash is 8eebfc6d169421509e5d4792a18917fcb6c44efb.
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.7.0-rc0
The hashes of the artifacts are as follows:
src.tar.gz.md5 fe75444b842d9fe1764777765a012c02
src.tar.gz.sha1 78c94408d3742b275c3a77d7312845ac2a98d067
src.zip.md5 c37a9079fe7b948ee1bcfbd84b3b2852
src.zip.sha1 62fe9a411cb4f6b62b5376c7e396092cf4415fe3
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1017
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/jhyde.asc
Please vote on releasing this package as Apache Calcite 1.7.0.
The vote is open until 12 noon Pacific on Monday, and passes if a majority of
at least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.7.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Julian
Re: [VOTE] Release apache-calcite-1.7.0 (release candidate 0)
Posted by Alan Gates <al...@gmail.com>.
Confirmed, I get the same results.
Alan.
> On Mar 18, 2016, at 09:51, Julian Hyde <jh...@apache.org> wrote:
>
> Try adding ‘-Papache-release’. Our rat config is only within the apache-release profile.
>
> I just ran it on the source tarball and it had one failure, due to git.properties. I’ll fix that next time.
>
> Julian
>
>
>> On Mar 18, 2016, at 9:46 AM, Alan Gates <al...@gmail.com> wrote:
>>
>> I ran it with the command:
>> mvn apache-rat:check -Dmaven.repo.local=/Users/gates/tmp/calcite/m2/
>>
>> Is there a different command I should use? If so, I think it’s fine if we document that in a developer readme or something.
>>
>> Alan.
>>
>>> On Mar 18, 2016, at 09:39, Julian Hyde <jh...@apache.org> wrote:
>>>
>>> This has come up before[1]. We run rat as part of the build process, from within Maven. The pom has some rat exclusions. But when rat is run outside of maven, it doesn’t pick up those exclusions. A useful feature for rat would be to take exclusions in a file, so that it could use the same exclusions list when run from within and from outside maven.
>>>
>>> Julian
>>>
>>> [1] https://issues.apache.org/jira/browse/CALCITE-746
>>>
>>>
>>>
>>>> On Mar 18, 2016, at 9:31 AM, Alan Gates <al...@gmail.com> wrote:
>>>>
>>>> +1, checked the LICENSE and NOTICE files, did a build with a fresh maven repo, and checked for any binary files. The one thing I’d note is that the rat check fails because a number of files don’t have licenses. Some of these look like they are generated so maybe we don’t have an option to put the license in. If that is the case is there a way to tell rat to ignore these file? It would be good to have a clean rat check so we know when it fails we need to pay attention.
>>>>
>>>> Alan.
>>>>
>>>>> On Mar 17, 2016, at 16:49, Julian Hyde <jh...@apache.org> wrote:
>>>>>
>>>>> Hi all,
>>>>>
>>>>> I have created a build for Apache Calcite 1.7.0, release candidate 0.
>>>>>
>>>>> Thanks to everyone who has contributed to this release. This is the
>>>>> first Calcite release since Avatica became an independent project, so
>>>>> now includes Avatica as it would any other library, and also features
>>>>> a brand new Cassandra adapter, and a slew of bug-fixes and
>>>>> improvements to the planning process.
>>>>>
>>>>> You can read the release notes here:
>>>>> https://github.com/apache/calcite/blob/branch-1.7/site/_docs/history.md
>>>>>
>>>>> The commit to be voted upon:
>>>>> http://git-wip-us.apache.org/repos/asf/calcite/commit/8eebfc6d169421509e5d4792a18917fcb6c44efb
>>>>>
>>>>> Its hash is 8eebfc6d169421509e5d4792a18917fcb6c44efb.
>>>>>
>>>>> The artifacts to be voted on are located here:
>>>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.7.0-rc0
>>>>>
>>>>> The hashes of the artifacts are as follows:
>>>>> src.tar.gz.md5 fe75444b842d9fe1764777765a012c02
>>>>> src.tar.gz.sha1 78c94408d3742b275c3a77d7312845ac2a98d067
>>>>> src.zip.md5 c37a9079fe7b948ee1bcfbd84b3b2852
>>>>> src.zip.sha1 62fe9a411cb4f6b62b5376c7e396092cf4415fe3
>>>>>
>>>>> A staged Maven repository is available for review at:
>>>>> https://repository.apache.org/content/repositories/orgapachecalcite-1017
>>>>>
>>>>> Release artifacts are signed with the following key:
>>>>> https://people.apache.org/keys/committer/jhyde.asc
>>>>>
>>>>> Please vote on releasing this package as Apache Calcite 1.7.0.
>>>>>
>>>>> The vote is open until 12 noon Pacific on Monday, and passes if a majority of
>>>>> at least three +1 PMC votes are cast.
>>>>>
>>>>> [ ] +1 Release this package as Apache Calcite 1.7.0
>>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>>>> [ ] -1 Do not release this package because...
>>>>>
>>>>>
>>>>> Here is my vote:
>>>>>
>>>>> +1 (binding)
>>>>>
>>>>> Julian
>>>>
>>>
>>
>
Re: [VOTE] Release apache-calcite-1.7.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
Try adding ‘-Papache-release’. Our rat config is only within the apache-release profile.
I just ran it on the source tarball and it had one failure, due to git.properties. I’ll fix that next time.
Julian
> On Mar 18, 2016, at 9:46 AM, Alan Gates <al...@gmail.com> wrote:
>
> I ran it with the command:
> mvn apache-rat:check -Dmaven.repo.local=/Users/gates/tmp/calcite/m2/
>
> Is there a different command I should use? If so, I think it’s fine if we document that in a developer readme or something.
>
> Alan.
>
>> On Mar 18, 2016, at 09:39, Julian Hyde <jh...@apache.org> wrote:
>>
>> This has come up before[1]. We run rat as part of the build process, from within Maven. The pom has some rat exclusions. But when rat is run outside of maven, it doesn’t pick up those exclusions. A useful feature for rat would be to take exclusions in a file, so that it could use the same exclusions list when run from within and from outside maven.
>>
>> Julian
>>
>> [1] https://issues.apache.org/jira/browse/CALCITE-746
>>
>>
>>
>>> On Mar 18, 2016, at 9:31 AM, Alan Gates <al...@gmail.com> wrote:
>>>
>>> +1, checked the LICENSE and NOTICE files, did a build with a fresh maven repo, and checked for any binary files. The one thing I’d note is that the rat check fails because a number of files don’t have licenses. Some of these look like they are generated so maybe we don’t have an option to put the license in. If that is the case is there a way to tell rat to ignore these file? It would be good to have a clean rat check so we know when it fails we need to pay attention.
>>>
>>> Alan.
>>>
>>>> On Mar 17, 2016, at 16:49, Julian Hyde <jh...@apache.org> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> I have created a build for Apache Calcite 1.7.0, release candidate 0.
>>>>
>>>> Thanks to everyone who has contributed to this release. This is the
>>>> first Calcite release since Avatica became an independent project, so
>>>> now includes Avatica as it would any other library, and also features
>>>> a brand new Cassandra adapter, and a slew of bug-fixes and
>>>> improvements to the planning process.
>>>>
>>>> You can read the release notes here:
>>>> https://github.com/apache/calcite/blob/branch-1.7/site/_docs/history.md
>>>>
>>>> The commit to be voted upon:
>>>> http://git-wip-us.apache.org/repos/asf/calcite/commit/8eebfc6d169421509e5d4792a18917fcb6c44efb
>>>>
>>>> Its hash is 8eebfc6d169421509e5d4792a18917fcb6c44efb.
>>>>
>>>> The artifacts to be voted on are located here:
>>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.7.0-rc0
>>>>
>>>> The hashes of the artifacts are as follows:
>>>> src.tar.gz.md5 fe75444b842d9fe1764777765a012c02
>>>> src.tar.gz.sha1 78c94408d3742b275c3a77d7312845ac2a98d067
>>>> src.zip.md5 c37a9079fe7b948ee1bcfbd84b3b2852
>>>> src.zip.sha1 62fe9a411cb4f6b62b5376c7e396092cf4415fe3
>>>>
>>>> A staged Maven repository is available for review at:
>>>> https://repository.apache.org/content/repositories/orgapachecalcite-1017
>>>>
>>>> Release artifacts are signed with the following key:
>>>> https://people.apache.org/keys/committer/jhyde.asc
>>>>
>>>> Please vote on releasing this package as Apache Calcite 1.7.0.
>>>>
>>>> The vote is open until 12 noon Pacific on Monday, and passes if a majority of
>>>> at least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release this package as Apache Calcite 1.7.0
>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>>> [ ] -1 Do not release this package because...
>>>>
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>>
>>>> Julian
>>>
>>
>
Re: [VOTE] Release apache-calcite-1.7.0 (release candidate 0)
Posted by Alan Gates <al...@gmail.com>.
I ran it with the command:
mvn apache-rat:check -Dmaven.repo.local=/Users/gates/tmp/calcite/m2/
Is there a different command I should use? If so, I think it’s fine if we document that in a developer readme or something.
Alan.
> On Mar 18, 2016, at 09:39, Julian Hyde <jh...@apache.org> wrote:
>
> This has come up before[1]. We run rat as part of the build process, from within Maven. The pom has some rat exclusions. But when rat is run outside of maven, it doesn’t pick up those exclusions. A useful feature for rat would be to take exclusions in a file, so that it could use the same exclusions list when run from within and from outside maven.
>
> Julian
>
> [1] https://issues.apache.org/jira/browse/CALCITE-746
>
>
>
>> On Mar 18, 2016, at 9:31 AM, Alan Gates <al...@gmail.com> wrote:
>>
>> +1, checked the LICENSE and NOTICE files, did a build with a fresh maven repo, and checked for any binary files. The one thing I’d note is that the rat check fails because a number of files don’t have licenses. Some of these look like they are generated so maybe we don’t have an option to put the license in. If that is the case is there a way to tell rat to ignore these file? It would be good to have a clean rat check so we know when it fails we need to pay attention.
>>
>> Alan.
>>
>>> On Mar 17, 2016, at 16:49, Julian Hyde <jh...@apache.org> wrote:
>>>
>>> Hi all,
>>>
>>> I have created a build for Apache Calcite 1.7.0, release candidate 0.
>>>
>>> Thanks to everyone who has contributed to this release. This is the
>>> first Calcite release since Avatica became an independent project, so
>>> now includes Avatica as it would any other library, and also features
>>> a brand new Cassandra adapter, and a slew of bug-fixes and
>>> improvements to the planning process.
>>>
>>> You can read the release notes here:
>>> https://github.com/apache/calcite/blob/branch-1.7/site/_docs/history.md
>>>
>>> The commit to be voted upon:
>>> http://git-wip-us.apache.org/repos/asf/calcite/commit/8eebfc6d169421509e5d4792a18917fcb6c44efb
>>>
>>> Its hash is 8eebfc6d169421509e5d4792a18917fcb6c44efb.
>>>
>>> The artifacts to be voted on are located here:
>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.7.0-rc0
>>>
>>> The hashes of the artifacts are as follows:
>>> src.tar.gz.md5 fe75444b842d9fe1764777765a012c02
>>> src.tar.gz.sha1 78c94408d3742b275c3a77d7312845ac2a98d067
>>> src.zip.md5 c37a9079fe7b948ee1bcfbd84b3b2852
>>> src.zip.sha1 62fe9a411cb4f6b62b5376c7e396092cf4415fe3
>>>
>>> A staged Maven repository is available for review at:
>>> https://repository.apache.org/content/repositories/orgapachecalcite-1017
>>>
>>> Release artifacts are signed with the following key:
>>> https://people.apache.org/keys/committer/jhyde.asc
>>>
>>> Please vote on releasing this package as Apache Calcite 1.7.0.
>>>
>>> The vote is open until 12 noon Pacific on Monday, and passes if a majority of
>>> at least three +1 PMC votes are cast.
>>>
>>> [ ] +1 Release this package as Apache Calcite 1.7.0
>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>> [ ] -1 Do not release this package because...
>>>
>>>
>>> Here is my vote:
>>>
>>> +1 (binding)
>>>
>>> Julian
>>
>
Re: [VOTE] Release apache-calcite-1.7.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
This has come up before[1]. We run rat as part of the build process, from within Maven. The pom has some rat exclusions. But when rat is run outside of maven, it doesn’t pick up those exclusions. A useful feature for rat would be to take exclusions in a file, so that it could use the same exclusions list when run from within and from outside maven.
Julian
[1] https://issues.apache.org/jira/browse/CALCITE-746
> On Mar 18, 2016, at 9:31 AM, Alan Gates <al...@gmail.com> wrote:
>
> +1, checked the LICENSE and NOTICE files, did a build with a fresh maven repo, and checked for any binary files. The one thing I’d note is that the rat check fails because a number of files don’t have licenses. Some of these look like they are generated so maybe we don’t have an option to put the license in. If that is the case is there a way to tell rat to ignore these file? It would be good to have a clean rat check so we know when it fails we need to pay attention.
>
> Alan.
>
>> On Mar 17, 2016, at 16:49, Julian Hyde <jh...@apache.org> wrote:
>>
>> Hi all,
>>
>> I have created a build for Apache Calcite 1.7.0, release candidate 0.
>>
>> Thanks to everyone who has contributed to this release. This is the
>> first Calcite release since Avatica became an independent project, so
>> now includes Avatica as it would any other library, and also features
>> a brand new Cassandra adapter, and a slew of bug-fixes and
>> improvements to the planning process.
>>
>> You can read the release notes here:
>> https://github.com/apache/calcite/blob/branch-1.7/site/_docs/history.md
>>
>> The commit to be voted upon:
>> http://git-wip-us.apache.org/repos/asf/calcite/commit/8eebfc6d169421509e5d4792a18917fcb6c44efb
>>
>> Its hash is 8eebfc6d169421509e5d4792a18917fcb6c44efb.
>>
>> The artifacts to be voted on are located here:
>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.7.0-rc0
>>
>> The hashes of the artifacts are as follows:
>> src.tar.gz.md5 fe75444b842d9fe1764777765a012c02
>> src.tar.gz.sha1 78c94408d3742b275c3a77d7312845ac2a98d067
>> src.zip.md5 c37a9079fe7b948ee1bcfbd84b3b2852
>> src.zip.sha1 62fe9a411cb4f6b62b5376c7e396092cf4415fe3
>>
>> A staged Maven repository is available for review at:
>> https://repository.apache.org/content/repositories/orgapachecalcite-1017
>>
>> Release artifacts are signed with the following key:
>> https://people.apache.org/keys/committer/jhyde.asc
>>
>> Please vote on releasing this package as Apache Calcite 1.7.0.
>>
>> The vote is open until 12 noon Pacific on Monday, and passes if a majority of
>> at least three +1 PMC votes are cast.
>>
>> [ ] +1 Release this package as Apache Calcite 1.7.0
>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>> [ ] -1 Do not release this package because...
>>
>>
>> Here is my vote:
>>
>> +1 (binding)
>>
>> Julian
>
Re: [VOTE] Release apache-calcite-1.7.0 (release candidate 0)
Posted by Alan Gates <al...@gmail.com>.
+1, checked the LICENSE and NOTICE files, did a build with a fresh maven repo, and checked for any binary files. The one thing I’d note is that the rat check fails because a number of files don’t have licenses. Some of these look like they are generated so maybe we don’t have an option to put the license in. If that is the case is there a way to tell rat to ignore these file? It would be good to have a clean rat check so we know when it fails we need to pay attention.
Alan.
> On Mar 17, 2016, at 16:49, Julian Hyde <jh...@apache.org> wrote:
>
> Hi all,
>
> I have created a build for Apache Calcite 1.7.0, release candidate 0.
>
> Thanks to everyone who has contributed to this release. This is the
> first Calcite release since Avatica became an independent project, so
> now includes Avatica as it would any other library, and also features
> a brand new Cassandra adapter, and a slew of bug-fixes and
> improvements to the planning process.
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.7/site/_docs/history.md
>
> The commit to be voted upon:
> http://git-wip-us.apache.org/repos/asf/calcite/commit/8eebfc6d169421509e5d4792a18917fcb6c44efb
>
> Its hash is 8eebfc6d169421509e5d4792a18917fcb6c44efb.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.7.0-rc0
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 fe75444b842d9fe1764777765a012c02
> src.tar.gz.sha1 78c94408d3742b275c3a77d7312845ac2a98d067
> src.zip.md5 c37a9079fe7b948ee1bcfbd84b3b2852
> src.zip.sha1 62fe9a411cb4f6b62b5376c7e396092cf4415fe3
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1017
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.7.0.
>
> The vote is open until 12 noon Pacific on Monday, and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.7.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
[RESULT] [VOTE] Release apache-calcite-1.7.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
Thanks to everyone who has tested the release candidate and given
their comments and votes.
The tally is as follows.
3 binding +1s:
Alan Gates
Josh Elser
Julian Hyde
No other votes.
Therefore I am delighted to announce that the proposal to release
Apache Calcite 1.7.0 has passed.
Thanks everyone. We’ll now roll the release out to the mirrors.
Julian
Re: [VOTE] Release apache-calcite-1.7.0 (release candidate 0)
Posted by Julian Hyde <jh...@apache.org>.
> * site/.sass_cache seems to have crept back into this release. Not a blocker IMO, but maybe a sign that we need to do something in the release process to try to catch this (here and for Avatica)
Agreed; I’ve added it to https://issues.apache.org/jira/browse/CALCITE-746.
Julian
Re: [VOTE] Release apache-calcite-1.7.0 (release candidate 0)
Posted by Josh Elser <el...@apache.org>.
+1 (binding)
* xsums/sigs good
* Inspected list of all files, nothing jumped out as binary
* RAT check fine (same caveat from Alan/Julian)
* LICENSE looks accurate (just Jekyll stuff)
* Using Avatica 1.7.1 (security concerns)
Nits:
* site/.sass_cache seems to have crept back into this release. Not a
blocker IMO, but maybe a sign that we need to do something in the
release process to try to catch this (here and for Avatica)
Julian Hyde wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.7.0, release candidate 0.
>
> Thanks to everyone who has contributed to this release. This is the
> first Calcite release since Avatica became an independent project, so
> now includes Avatica as it would any other library, and also features
> a brand new Cassandra adapter, and a slew of bug-fixes and
> improvements to the planning process.
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/branch-1.7/site/_docs/history.md
>
> The commit to be voted upon:
> http://git-wip-us.apache.org/repos/asf/calcite/commit/8eebfc6d169421509e5d4792a18917fcb6c44efb
>
> Its hash is 8eebfc6d169421509e5d4792a18917fcb6c44efb.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.7.0-rc0
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 fe75444b842d9fe1764777765a012c02
> src.tar.gz.sha1 78c94408d3742b275c3a77d7312845ac2a98d067
> src.zip.md5 c37a9079fe7b948ee1bcfbd84b3b2852
> src.zip.sha1 62fe9a411cb4f6b62b5376c7e396092cf4415fe3
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1017
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 1.7.0.
>
> The vote is open until 12 noon Pacific on Monday, and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.7.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian