You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (JIRA)" <ji...@apache.org> on 2010/01/26 22:40:34 UTC
[jira] Created: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Suppress Checkstyle warnings for generated files
------------------------------------------------
Key: HIVE-1104
URL: https://issues.apache.org/jira/browse/HIVE-1104
Project: Hadoop Hive
Issue Type: Task
Components: Build Infrastructure
Affects Versions: 0.6.0
Reporter: Carl Steinbach
Assignee: Carl Steinbach
Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1104:
---------------------------------
Status: Patch Available (was: Open)
* Suppress Checkstyle warnings for JavaCC and Thrift generated files.
* Add ASF header check.
* Bump Checkstyle version number from 4.2 to 5.0 (required for SuppressWithNearbyCommentFilter).
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1104:
---------------------------------
Attachment: HIVE-1104.4.patch
* Add suppressions.xml file suppression list (includes gen-java and JDBM).
* Apply HiddenField check to local variables only (ignore parameters).
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.2.patch, HIVE-1104.3.patch, HIVE-1104.4.patch, HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1104:
---------------------------------
Attachment: HIVE-1104.patch
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1104:
---------------------------------
Attachment: HIVE-1104.3.patch
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.2.patch, HIVE-1104.3.patch, HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1104:
---------------------------------
Status: Patch Available (was: In Progress)
* Suppress Checkstyle warnings for JavaCC and Thrift generated files.
* Add ASF header check.
* Bump Checkstyle version number from 4.2 to 5.0 (required for SuppressWithNearbyCommentFilter).
* Add .checkstyle configuration file in project root for Eclipse checkstyle plugin.
* Enable the following CheckStyle modules:
** DefaultComesLast
** EqualsAvoidNull
** EqualsHashCode
** ExplicitInitialization
** IllegalCatch
** MagicNumber
** MissingSwitchDefault
** MissingOverride
** MultipleStringLiterals
** NoClone
** ParameterAssignment
** StringLiteralEquality
With these settings Checkstyle finds 6749 errors in 872 source files.
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.2.patch, HIVE-1104.3.patch, HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828416#action_12828416 ]
Carl Steinbach commented on HIVE-1104:
--------------------------------------
Fixed the checkstyle classpath problem by removing the "unless=offline" attributes from all of the checkstyle targets. If the checkstyle artifacts exist in the Ivy cache it operates in offline mode by default. If the artifacts are not in the Ivy cache, then we either have to let Ivy fetch them, or else proactively fail the target. I'm assuming that fetching the artifacts is preferable to a build failure, i.e. I'm assuming that "offline=true" implies best effort to operate in offline mode, but not at the expense of a build failure.
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.2.patch, HIVE-1104.3.patch, HIVE-1104.4.patch, HIVE-1104.6.git.patch, HIVE-1104.7.patch, HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1104:
-----------------------------
Resolution: Fixed
Fix Version/s: 0.6.0
Release Note: HIVE-1104. Suppress Checkstyle warnings for generated files. (Carl Steinbach via zshao)
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks Carl!
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.6.0
>
> Attachments: HIVE-1104.2.patch, HIVE-1104.3.patch, HIVE-1104.4.patch, HIVE-1104.6.git.patch, HIVE-1104.7.patch, HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1104:
---------------------------------
Attachment: HIVE-1104.6.git.patch
* git patch prepared using git-format-patch
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.2.patch, HIVE-1104.3.patch, HIVE-1104.4.patch, HIVE-1104.6.git.patch, HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1104:
---------------------------------
Affects Version/s: (was: 0.6.0)
Release Note: (was: HIVE-1104. Suppress Checkstyle warnings for generated files. (Carl Steinbach via zshao))
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Fix For: 0.6.0
>
> Attachments: HIVE-1104.2.patch, HIVE-1104.3.patch, HIVE-1104.4.patch, HIVE-1104.6.git.patch, HIVE-1104.7.patch, HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1104:
---------------------------------
Attachment: HIVE-1104.7.patch
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.2.patch, HIVE-1104.3.patch, HIVE-1104.4.patch, HIVE-1104.6.git.patch, HIVE-1104.7.patch, HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1104:
---------------------------------
Status: In Progress (was: Patch Available)
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1104:
---------------------------------
Attachment: HIVE-1104.2.patch
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.2.patch, HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1104) Suppress Checkstyle warnings for
generated files
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805826#action_12805826 ]
Zheng Shao commented on HIVE-1104:
----------------------------------
Can you make it work with "-Doffline=true"?
It will be great if the definition of pathid can be moved out of the "ivy-retrieve-checkstyle" because it only gets executed when offline is not defined.
{code}
<target name="ivy-retrieve-checkstyle" depends="ivy-resolve-checkstyle"
description="Retrieve Ivy-managed artifacts for the checkstyle configurations"
unless="offline">
<ivy:retrieve settingsRef="${ant.project.name}.ivy.settings"
pattern="${build.ivy.lib.dir}/${ivy.artifact.retrieve.pattern}"
log="${ivyresolvelog}"/>
<ivy:cachepath pathid="checkstyle-classpath" conf="checkstyle"/>
</target>
{code}
{code}
[zshao@dev /data/users/zshao/hadoop_hive_trunk] ant -Doffline=true checkstyle
Buildfile: build.xml
ivy-init-dirs:
ivy-download:
ivy-probe-antlib:
ivy-init-antlib:
ivy-init:
ivy-resolve-checkstyle:
[ivy:resolve] :: Ivy 2.0.0-rc2 - 20081028224207 :: http://ant.apache.org/ivy/ ::
:: loading settings :: file = /data/users/zshao/hadoop_hive_trunk/ivy/ivysettings.xml
ivy-retrieve-checkstyle:
check-for-checkstyle:
BUILD FAILED
/data/users/zshao/hadoop_hive_trunk/build.xml:518: Reference checkstyle-classpath not found.
{code}
> Suppress Checkstyle warnings for generated files
> ------------------------------------------------
>
> Key: HIVE-1104
> URL: https://issues.apache.org/jira/browse/HIVE-1104
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Affects Versions: 0.6.0
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1104.2.patch, HIVE-1104.3.patch, HIVE-1104.4.patch, HIVE-1104.6.git.patch, HIVE-1104.patch
>
>
> Suppress Checkstyle warnings for generated files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.