[GitHub] [spark] zero323 commented on a change in pull request #34466: [SPARK-37152][PYTHON] Inline type hints for python/pyspark/context.py

[GitBox <gi...@apache.org>]

zero323 commented on a change in pull request #34466:
URL: https://github.com/apache/spark/pull/34466#discussion_r762569040



##########
File path: python/pyspark/context.py
##########
@@ -45,23 +62,30 @@
 )
 from pyspark.storagelevel import StorageLevel
 from pyspark.resource.information import ResourceInformation
-from pyspark.rdd import RDD, _load_from_socket
+from pyspark.rdd import RDD, _load_from_socket  # type: ignore[attr-defined]
 from pyspark.taskcontext import TaskContext
 from pyspark.traceback_utils import CallSite, first_spark_call
 from pyspark.status import StatusTracker
 from pyspark.profiler import ProfilerCollector, BasicProfiler, UDFBasicProfiler
+from py4j.java_gateway import is_instance_of, JavaGateway, JavaObject, JVMView
 
+if TYPE_CHECKING:
+    from pyspark.serializers import Serializer

Review comment:
       Nit: It is already imported in L:56.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org