You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2015/08/28 22:46:10 UTC
logging-log4j2 git commit: [LOG4J2-1110]
org.apache.logging.log4j.jul.CoreLogger.setLevel() checks for security
permission too late.
Repository: logging-log4j2
Updated Branches:
refs/heads/master 32956ad36 -> b4f73bc8f
[LOG4J2-1110] org.apache.logging.log4j.jul.CoreLogger.setLevel() checks
for security permission too late.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/b4f73bc8
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/b4f73bc8
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/b4f73bc8
Branch: refs/heads/master
Commit: b4f73bc8f801bec8e6e2fa5123def7a2ad75c6ad
Parents: 32956ad
Author: ggregory <gg...@apache.org>
Authored: Fri Aug 28 13:46:07 2015 -0700
Committer: ggregory <gg...@apache.org>
Committed: Fri Aug 28 13:46:07 2015 -0700
----------------------------------------------------------------------
.../src/main/java/org/apache/logging/log4j/jul/CoreLogger.java | 2 +-
src/changes/changes.xml | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/b4f73bc8/log4j-jul/src/main/java/org/apache/logging/log4j/jul/CoreLogger.java
----------------------------------------------------------------------
diff --git a/log4j-jul/src/main/java/org/apache/logging/log4j/jul/CoreLogger.java b/log4j-jul/src/main/java/org/apache/logging/log4j/jul/CoreLogger.java
index eaf7a44..df85c77 100644
--- a/log4j-jul/src/main/java/org/apache/logging/log4j/jul/CoreLogger.java
+++ b/log4j-jul/src/main/java/org/apache/logging/log4j/jul/CoreLogger.java
@@ -44,8 +44,8 @@ public class CoreLogger extends ApiLogger {
@Override
public void setLevel(final Level level) throws SecurityException {
+ super.doSetLevel(level); // checks permissions
logger.setLevel(LevelTranslator.toLevel(level));
- super.doSetLevel(level);
}
/**
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/b4f73bc8/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index f33e78d..76d4af9 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -48,6 +48,9 @@
<action issue="LOG4J2-1108" dev="ggregory" type="fix" due-to="Mikael Ståldal">
NullPointerException when passing null to java.util.logging.Logger.setLevel().
</action>
+ <action issue="LOG4J2-1110" dev="ggregory" type="fix">
+ org.apache.logging.log4j.jul.CoreLogger.setLevel() checks for security permission too late.
+ </action>
<action dev="rpopma" type="remove">
Removed experimental interface LevelLogger which got committed to master by mistake.
</action>