You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Lin Sun (JIRA)" <ji...@apache.org> on 2009/06/10 15:56:07 UTC

[jira] Created: (GERONIMO-4683) Transaction.commit method signature isn't entirely correctly

Transaction.commit method signature isn't entirely correctly
------------------------------------------------------------

                 Key: GERONIMO-4683
                 URL: https://issues.apache.org/jira/browse/GERONIMO-4683
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: specs
    Affects Versions: 2.1.4
            Reporter: Lin Sun


I found out the Transaction.commit method signature isn't entirely correct.

Per JTA 1.1 for the Transaction interface:

commit 
public void commit() throws RollbackException, 
HeuristicMixedException, HeuristicRollbackException, 
IllegalStateException, SecurityException, SystemException

geronimo-jta_1.1_spec has:

    void commit() throws HeuristicMixedException, HeuristicRollbackException, RollbackException, SecurityException, SystemException;

which is missing the IllegalStateException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (GERONIMO-4683) Transaction.commit method signature isn't entirely correctly

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun reopened GERONIMO-4683:
-------------------------------


I just realized that the SecurityException is also unchecked exception.   So we are listing one but not the other.  Seems we should be consistent here.   

> Transaction.commit method signature isn't entirely correctly
> ------------------------------------------------------------
>
>                 Key: GERONIMO-4683
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4683
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: specs
>    Affects Versions: 2.1.4
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>
> I found out the Transaction.commit method signature isn't entirely correct.
> Per JTA 1.1 for the Transaction interface:
> commit 
> public void commit() throws RollbackException, 
> HeuristicMixedException, HeuristicRollbackException, 
> IllegalStateException, SecurityException, SystemException
> geronimo-jta_1.1_spec has:
>     void commit() throws HeuristicMixedException, HeuristicRollbackException, RollbackException, SecurityException, SystemException;
> which is missing the IllegalStateException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-4683) Transaction.commit method signature isn't entirely correctly

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718204#action_12718204 ] 

David Jencks commented on GERONIMO-4683:
----------------------------------------

IIUC IllegalStateException is an unchecked exception so you don't need to list it in method signatures.  The binary jar pases the signature tests which definitely check for the correct exceptions.

> Transaction.commit method signature isn't entirely correctly
> ------------------------------------------------------------
>
>                 Key: GERONIMO-4683
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4683
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: specs
>    Affects Versions: 2.1.4
>            Reporter: Lin Sun
>
> I found out the Transaction.commit method signature isn't entirely correct.
> Per JTA 1.1 for the Transaction interface:
> commit 
> public void commit() throws RollbackException, 
> HeuristicMixedException, HeuristicRollbackException, 
> IllegalStateException, SecurityException, SystemException
> geronimo-jta_1.1_spec has:
>     void commit() throws HeuristicMixedException, HeuristicRollbackException, RollbackException, SecurityException, SystemException;
> which is missing the IllegalStateException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-4683) Transaction.commit method signature isn't entirely correctly

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun closed GERONIMO-4683.
-----------------------------

    Resolution: Invalid
      Assignee: Lin Sun

> Transaction.commit method signature isn't entirely correctly
> ------------------------------------------------------------
>
>                 Key: GERONIMO-4683
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4683
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: specs
>    Affects Versions: 2.1.4
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>
> I found out the Transaction.commit method signature isn't entirely correct.
> Per JTA 1.1 for the Transaction interface:
> commit 
> public void commit() throws RollbackException, 
> HeuristicMixedException, HeuristicRollbackException, 
> IllegalStateException, SecurityException, SystemException
> geronimo-jta_1.1_spec has:
>     void commit() throws HeuristicMixedException, HeuristicRollbackException, RollbackException, SecurityException, SystemException;
> which is missing the IllegalStateException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-4683) Transaction.commit method signature isn't entirely correctly

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun resolved GERONIMO-4683.
-------------------------------

    Resolution: Fixed

> Transaction.commit method signature isn't entirely correctly
> ------------------------------------------------------------
>
>                 Key: GERONIMO-4683
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4683
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: specs
>    Affects Versions: 2.1.4
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>
> I found out the Transaction.commit method signature isn't entirely correct.
> Per JTA 1.1 for the Transaction interface:
> commit 
> public void commit() throws RollbackException, 
> HeuristicMixedException, HeuristicRollbackException, 
> IllegalStateException, SecurityException, SystemException
> geronimo-jta_1.1_spec has:
>     void commit() throws HeuristicMixedException, HeuristicRollbackException, RollbackException, SecurityException, SystemException;
> which is missing the IllegalStateException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-4683) Transaction.commit method signature isn't entirely correctly

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun closed GERONIMO-4683.
-----------------------------


> Transaction.commit method signature isn't entirely correctly
> ------------------------------------------------------------
>
>                 Key: GERONIMO-4683
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4683
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: specs
>    Affects Versions: 2.1.4
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>
> I found out the Transaction.commit method signature isn't entirely correct.
> Per JTA 1.1 for the Transaction interface:
> commit 
> public void commit() throws RollbackException, 
> HeuristicMixedException, HeuristicRollbackException, 
> IllegalStateException, SecurityException, SystemException
> geronimo-jta_1.1_spec has:
>     void commit() throws HeuristicMixedException, HeuristicRollbackException, RollbackException, SecurityException, SystemException;
> which is missing the IllegalStateException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.