You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/15 10:40:13 UTC
[GitHub] [shardingsphere] chakkk309 opened a new pull request, #19245: Add @ToString annotation for SQLStatement of PostgreSQL
chakkk309 opened a new pull request, #19245:
URL: https://github.com/apache/shardingsphere/pull/19245
Ref https://github.com/apache/shardingsphere/issues/19189
Changes proposed in this pull request:
- add @tostring annotation for PostgreSQL SQLStatement
- correct some wrong statement logic
- format some indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #19245: Update @ToString annotation for SQLStatement of PostgreSQL
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #19245:
URL: https://github.com/apache/shardingsphere/pull/19245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #19245: Update @ToString annotation for SQLStatement of PostgreSQL
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #19245:
URL: https://github.com/apache/shardingsphere/pull/19245#discussion_r922108570
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/framework/container/database/OpenGaussContainer.java:
##########
@@ -49,7 +49,7 @@ protected void configure() {
addEnv("GS_PASSWORD", password);
withClasspathResourceMapping("/env/postgresql/postgresql.conf", "/usr/local/opengauss/share/postgresql/postgresql.conf.sample", BindMode.READ_ONLY);
withClasspathResourceMapping("/env/postgresql/initdb.sql", "/docker-entrypoint-initdb.d/", BindMode.READ_ONLY);
-
+
Review Comment:
Please remove this useless black line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19245: Update @ToString annotation for SQLStatement of PostgreSQL
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19245:
URL: https://github.com/apache/shardingsphere/pull/19245#issuecomment-1185625679
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19245](https://codecov.io/gh/apache/shardingsphere/pull/19245?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df92a5c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/39b6dab961f7a7b5f3748903b65cbcbde70aceae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39b6dab) will **increase** coverage by `0.00%`.
> The diff coverage is `57.14%`.
> :exclamation: Current head df92a5c differs from pull request most recent head 4b81696. Consider uploading reports for the commit 4b81696 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19245 +/- ##
=========================================
Coverage 59.24% 59.24%
- Complexity 2332 2333 +1
=========================================
Files 3811 3813 +2
Lines 54338 54343 +5
Branches 9247 9247
=========================================
+ Hits 32190 32197 +7
+ Misses 19413 19411 -2
Partials 2735 2735
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ddlgenerator/PostgresColumnPropertiesAppender.java](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9wb3N0Z3Jlc3FsL2RkbGdlbmVyYXRvci9Qb3N0Z3Jlc0NvbHVtblByb3BlcnRpZXNBcHBlbmRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ment/oracle/ddl/OracleAlterIndexTypeStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVBbHRlckluZGV4VHlwZVN0YXRlbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ostgresql/dal/PostgreSQLAnalyzeTableStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kYWwvUG9zdGdyZVNRTEFuYWx5emVUYWJsZVN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...ent/postgresql/dal/PostgreSQLExplainStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kYWwvUG9zdGdyZVNRTEV4cGxhaW5TdGF0ZW1lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...tement/postgresql/dal/PostgreSQLLoadStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kYWwvUG9zdGdyZVNRTExvYWRTdGF0ZW1lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...tgresql/dal/PostgreSQLResetParameterStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kYWwvUG9zdGdyZVNRTFJlc2V0UGFyYW1ldGVyU3RhdGVtZW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...atement/postgresql/dal/PostgreSQLSetStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kYWwvUG9zdGdyZVNRTFNldFN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...tement/postgresql/dal/PostgreSQLShowStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kYWwvUG9zdGdyZVNRTFNob3dTdGF0ZW1lbnQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ment/postgresql/dal/PostgreSQLVacuumStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kYWwvUG9zdGdyZVNRTFZhY3V1bVN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...t/postgresql/dcl/PostgreSQLAlterRoleStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kY2wvUG9zdGdyZVNRTEFsdGVyUm9sZVN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [129 more](https://codecov.io/gh/apache/shardingsphere/pull/19245/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19245?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19245?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f982f3f...4b81696](https://codecov.io/gh/apache/shardingsphere/pull/19245?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] chakkk309 commented on a diff in pull request #19245: Update @ToString annotation for SQLStatement of PostgreSQL
Posted by GitBox <gi...@apache.org>.
chakkk309 commented on code in PR #19245:
URL: https://github.com/apache/shardingsphere/pull/19245#discussion_r922172424
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/framework/container/database/OpenGaussContainer.java:
##########
@@ -49,7 +49,7 @@ protected void configure() {
addEnv("GS_PASSWORD", password);
withClasspathResourceMapping("/env/postgresql/postgresql.conf", "/usr/local/opengauss/share/postgresql/postgresql.conf.sample", BindMode.READ_ONLY);
withClasspathResourceMapping("/env/postgresql/initdb.sql", "/docker-entrypoint-initdb.d/", BindMode.READ_ONLY);
-
+
Review Comment:
> Please remove this useless black line.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org