You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/09/06 01:38:00 UTC
[jira] [Work logged] (BEAM-12464) Change ProtoSchemaTranslator beam
schema creation to match the order for protobufs containing Oneof fields
[ https://issues.apache.org/jira/browse/BEAM-12464?focusedWorklogId=646728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646728 ]
ASF GitHub Bot logged work on BEAM-12464:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/21 01:37
Start Date: 06/Sep/21 01:37
Worklog Time Spent: 10m
Work Description: reubenvanammers commented on pull request #14974:
URL: https://github.com/apache/beam/pull/14974#issuecomment-913276245
Hey @reuvenlax ,
That'd be great to get another set of eyes on it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 646728)
Time Spent: 3h 40m (was: 3.5h)
> Change ProtoSchemaTranslator beam schema creation to match the order for protobufs containing Oneof fields
> ----------------------------------------------------------------------------------------------------------
>
> Key: BEAM-12464
> URL: https://issues.apache.org/jira/browse/BEAM-12464
> Project: Beam
> Issue Type: Improvement
> Components: extensions-java-protobuf
> Reporter: Reuben van Ammers
> Priority: P3
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Currently, when ProtoSchemaTranslator creates the beam schema from a protobuf definition it always puts the Oneofs at the start of the beam schema due to Oneofs being created from the code first. This means that the order of the fields doesn't match the order of the protobuf defintion. As the schema generation is used when converting from beam rows to protobufs, it additionally means that it is impossible to convert from a beam row where the oneof fields are not the first fields in the beamrow.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)