You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/09/23 00:46:29 UTC
[GitHub] [geode] nabarunnag opened a new pull request #6894: GEODE-9628: Fix setting client credential documentation
nabarunnag opened a new pull request #6894:
URL: https://github.com/apache/geode/pull/6894
* The current document mentions that we can choose between setting the properties or the AuthInitializer.
* After a few experiments we were able to confirm that both the settings are needed for successful client verification.
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag merged pull request #6894: GEODE-9628: Fix setting client credential documentation
Posted by GitBox <gi...@apache.org>.
nabarunnag merged pull request #6894:
URL: https://github.com/apache/geode/pull/6894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #6894: GEODE-9628: Fix setting client credential documentation
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #6894:
URL: https://github.com/apache/geode/pull/6894#discussion_r716860588
##########
File path: geode-docs/managing/security/implementing_authentication.html.md.erb
##########
@@ -95,7 +95,7 @@ sender or receiver.
In order to connect with a locator or a server that does authentication,
a client will need to set its credential, composed of the two properties
`security-username` and `security-password`.
-Choose one of these two ways to accomplish this:
+Follow these two steps to accomplish this:
Review comment:
@jinmeiliao @nabarunnag Perhaps we should add that subtlety to the description. So I know what wording to suggest, would you say that the gemfire properties dependency is the most common use-case, or is it relatively rare?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #6894: GEODE-9628: Fix setting client credential documentation
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #6894:
URL: https://github.com/apache/geode/pull/6894#discussion_r716860588
##########
File path: geode-docs/managing/security/implementing_authentication.html.md.erb
##########
@@ -95,7 +95,7 @@ sender or receiver.
In order to connect with a locator or a server that does authentication,
a client will need to set its credential, composed of the two properties
`security-username` and `security-password`.
-Choose one of these two ways to accomplish this:
+Follow these two steps to accomplish this:
Review comment:
@jinmeiliao @nabarunnag Perhaps we should add that subtlety to the description. So I know what wording to suggest, would you say that the gemfire properties dependency is the most common use-case, or is it relatively rare?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #6894: GEODE-9628: Fix setting client credential documentation
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #6894:
URL: https://github.com/apache/geode/pull/6894#discussion_r716860588
##########
File path: geode-docs/managing/security/implementing_authentication.html.md.erb
##########
@@ -95,7 +95,7 @@ sender or receiver.
In order to connect with a locator or a server that does authentication,
a client will need to set its credential, composed of the two properties
`security-username` and `security-password`.
-Choose one of these two ways to accomplish this:
+Follow these two steps to accomplish this:
Review comment:
@jinmeiliao Perhaps we should add that subtlety to the description. So I know what wording to suggest, would you say that the gemfire properties dependency is the most common use-case, or is it relatively rare?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jinmeiliao commented on a change in pull request #6894: GEODE-9628: Fix setting client credential documentation
Posted by GitBox <gi...@apache.org>.
jinmeiliao commented on a change in pull request #6894:
URL: https://github.com/apache/geode/pull/6894#discussion_r715050867
##########
File path: geode-docs/managing/security/implementing_authentication.html.md.erb
##########
@@ -95,7 +95,7 @@ sender or receiver.
In order to connect with a locator or a server that does authentication,
a client will need to set its credential, composed of the two properties
`security-username` and `security-password`.
-Choose one of these two ways to accomplish this:
+Follow these two steps to accomplish this:
Review comment:
Actually, only "AuthInitialize" is required for client authentication, depending on the implementation of "AuthtInitialize", if it's looking for these properties in the gemfire properties, then gemfire properties needs to have these properties, but it's solely depends on the implementation of that interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag commented on a change in pull request #6894: GEODE-9628: Fix setting client credential documentation
Posted by GitBox <gi...@apache.org>.
nabarunnag commented on a change in pull request #6894:
URL: https://github.com/apache/geode/pull/6894#discussion_r716941601
##########
File path: geode-docs/managing/security/implementing_authentication.html.md.erb
##########
@@ -95,7 +95,7 @@ sender or receiver.
In order to connect with a locator or a server that does authentication,
a client will need to set its credential, composed of the two properties
`security-username` and `security-password`.
-Choose one of these two ways to accomplish this:
+Follow these two steps to accomplish this:
Review comment:
@jinmeiliao fair point, I have made the change to reflect that. Previously, it assumed that if the properties are set then there is no need for implementing the AuthInitialize inteface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag merged pull request #6894: GEODE-9628: Fix setting client credential documentation
Posted by GitBox <gi...@apache.org>.
nabarunnag merged pull request #6894:
URL: https://github.com/apache/geode/pull/6894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag commented on a change in pull request #6894: GEODE-9628: Fix setting client credential documentation
Posted by GitBox <gi...@apache.org>.
nabarunnag commented on a change in pull request #6894:
URL: https://github.com/apache/geode/pull/6894#discussion_r716941601
##########
File path: geode-docs/managing/security/implementing_authentication.html.md.erb
##########
@@ -95,7 +95,7 @@ sender or receiver.
In order to connect with a locator or a server that does authentication,
a client will need to set its credential, composed of the two properties
`security-username` and `security-password`.
-Choose one of these two ways to accomplish this:
+Follow these two steps to accomplish this:
Review comment:
@jinmeiliao fair point, I have made the change to reflect that. Previously, it assumed that if the properties are set then there is no need for implementing the AuthInitialize inteface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org