You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Eugene Kirpichov (JIRA)" <ji...@apache.org> on 2018/03/01 01:58:00 UTC
[jira] [Commented] (BEAM-3714) JdbcIO.read() should create a
forward-only, read-only result set
[ https://issues.apache.org/jira/browse/BEAM-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381382#comment-16381382 ]
Eugene Kirpichov commented on BEAM-3714:
----------------------------------------
Hey Innocent, thanks for taking this! I'll be happy to help if you have any questions, and review your PR when it's ready.
> JdbcIO.read() should create a forward-only, read-only result set
> ----------------------------------------------------------------
>
> Key: BEAM-3714
> URL: https://issues.apache.org/jira/browse/BEAM-3714
> Project: Beam
> Issue Type: Bug
> Components: io-java-jdbc
> Reporter: Eugene Kirpichov
> Assignee: Innocent
> Priority: Major
>
> [https://stackoverflow.com/questions/48784889/streaming-data-from-cloudsql-into-dataflow/48819934#48819934] - a user is trying to load a large table from MySQL, and the MySQL JDBC driver requires special measures when loading large result sets.
> JdbcIO currently calls simply "connection.prepareStatement(query)" https://github.com/apache/beam/blob/bb8c12c4956cbe3c6f2e57113e7c0ce2a5c05009/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java#L508 - it should specify type TYPE_FORWARD_ONLY and concurrency CONCUR_READ_ONLY - these values should always be used.
> Seems that different databases have different requirements for streaming result sets.
> E.g. MySQL requires setting fetch size; PostgreSQL says "The Connection must not be in autocommit mode." https://jdbc.postgresql.org/documentation/head/query.html#query-with-cursor . Oracle, I think, doesn't have any special requirements but I don't know. Fetch size should probably still be set to a reasonably large value.
> Seems that the common denominator of these requirements is: set fetch size to a reasonably large but not maximum value; disable autocommit (there's nothing to commit in read() anyway).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)