You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/10/12 07:15:53 UTC

[PR] [SPARK-60184] Fix workload RBAC to allow `ExecutorResizePlugin` to resize executor pods [spark-kubernetes-operator]

dongjoon-hyun opened a new pull request, #962:
URL: https://github.com/apache/spark-kubernetes-operator/pull/962

   ### What changes were proposed in this pull request?
   
   This PR aims to grant the Spark workload `ClusterRole` and `Role`s the permissions which `ExecutorResizePlugin` needs:
   - `patch` on `pods/resize`
   - `get` on `pods` in the `metrics.k8s.io` API group
   
   ### Why are the changes needed?
   
   Apache Spark [v4.2.0](https://github.com/apache/spark/releases/tag/v4.2.0) (2026-07-11) provides `ExecutorResizePlugin`, which `examples/pi-java25-with-executor-resize-plugin.yaml` uses. Without these permissions, the plugin silently does nothing, since it swallows the `Forbidden` errors.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. The workload roles grant more permissions than [1.0.0](https://github.com/apache/spark-kubernetes-operator/releases/tag/1.0.0) (2026-07-23). The migration guide is updated.
   
   ### How was this patch tested?
   
   Pass the CIs with the updated `helm test`. I also verified manually on K8s 1.37 with a metrics server that the executor pod is resized in place only with this PR.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 5.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-60184] Fix workload RBAC to allow `ExecutorResizePlugin` to resize executor pods [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #962:
URL: https://github.com/apache/spark-kubernetes-operator/pull/962#issuecomment-6120757783

   Merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-60184] Fix workload RBAC to allow `ExecutorResizePlugin` to resize executor pods [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #962:
URL: https://github.com/apache/spark-kubernetes-operator/pull/962#issuecomment-6119976903

   Could you review this PR, @peter-toth ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-60184] Fix workload RBAC to allow `ExecutorResizePlugin` to resize executor pods [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #962: [SPARK-60184] Fix workload RBAC to allow `ExecutorResizePlugin` to resize executor pods
URL: https://github.com/apache/spark-kubernetes-operator/pull/962


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-60184] Fix workload RBAC to allow `ExecutorResizePlugin` to resize executor pods [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #962:
URL: https://github.com/apache/spark-kubernetes-operator/pull/962#issuecomment-6120743057

   Thank you, @peter-toth !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org