You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by prabeesh <gi...@git.apache.org> on 2014/04/05 06:37:55 UTC
[GitHub] incubator-storm pull request: Change Twitter authentication
GitHub user prabeesh opened a pull request:
https://github.com/apache/incubator-storm/pull/62
Change Twitter authentication
Change Twitter authentication stream using the new Twitter4J. An optional set of filters can be used to restricted tweets.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabeesh/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit 75800059a2d98a948939a81d47997590cb61ae00
Author: Prabeesh K <pr...@gmail.com>
Date: 2014-04-05T04:32:36Z
Change Twitter authentication
Change Twitter authentication stream using the new Twitter4J. An optional set of filters can be used to restricted tweets
commit aa064727d8b13d762c06509c185194b17edc40e7
Author: Prabeesh K <pr...@gmail.com>
Date: 2014-04-05T04:34:37Z
Update PrintSampleStream.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-310] Change Twitter authentic...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/62#issuecomment-42436699
Thanks, I am now seeing compilation issues, with this pull request. It looks like the pom.xml was not updated to use twitter4j.
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project storm-starter: Compilation failure: Compilation failure:
[ERROR] TwitterSampleSpout.java:[22,22] package twitter4j.conf does not exist
[ERROR] TwitterSampleSpout.java:[23,17] package twitter4j does not exist
[ERROR] TwitterSampleSpout.java:[24,17] package twitter4j does not exist
[ERROR] TwitterSampleSpout.java:[34,17] package twitter4j does not exist
[ERROR] TwitterSampleSpout.java:[35,17] package twitter4j does not exist
[ERROR] TwitterSampleSpout.java:[36,17] package twitter4j does not exist
[ERROR] TwitterSampleSpout.java:[37,17] package twitter4j does not exist
[ERROR] TwitterSampleSpout.java:[38,17] package twitter4j does not exist
[ERROR] TwitterSampleSpout.java:[39,22] package twitter4j.auth does not exist
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Change Twitter authentication
Posted by prabeesh <gi...@git.apache.org>.
Github user prabeesh commented on the pull request:
https://github.com/apache/incubator-storm/pull/62#issuecomment-42385017
Added new JIRA
https://issues.apache.org/jira/browse/STORM-310
I can make a new request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-310] Change Twitter authentic...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/62#issuecomment-42970523
Thanks, @prabeesh
Not a twitter API expert either, but I am changes look fine to me.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-310] Change Twitter authentic...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/62#discussion_r12542858
--- Diff: examples/storm-starter/src/jvm/storm/starter/PrintSampleStream.java ---
@@ -15,31 +15,39 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-/*
+
// to use this example, uncomment the twitter4j dependency information in the project.clj,
// uncomment storm.starter.spout.TwitterSampleSpout, and uncomment this class
--- End diff --
Do we still need this comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-310] Change Twitter authentic...
Posted by prabeesh <gi...@git.apache.org>.
Github user prabeesh commented on the pull request:
https://github.com/apache/incubator-storm/pull/62#issuecomment-42969453
updated, removed unnecessary comments.
thank you @d2r
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-310] Change Twitter authentic...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/62#issuecomment-42845358
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-310] Change Twitter authentic...
Posted by prabeesh <gi...@git.apache.org>.
Github user prabeesh commented on the pull request:
https://github.com/apache/incubator-storm/pull/62#issuecomment-42573635
@revans2 thank you.
Updated pom.xml to use twitter4j and also done some code fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-310] Change Twitter authentic...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Change Twitter authentication
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/62#issuecomment-42325320
I am not an expert on the twitter API, but the changes look good to me. Please file a JIRA for this change and add the JIRA number in the title of the pull request. (Like STORM-12345: Change Twitter authentication)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---