You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/02/28 02:15:46 UTC
Review Request 31569: Sqoop2: Show command for CLI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31569/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2144
https://issues.apache.org/jira/browse/SQOOP-2144
Repository: sqoop-sqoop2
Description
-------
commit 2ba6fdd4d713a65ec6109daec563bd7a5fbc0a19
Author: Abraham Elmahrek <ab...@apache.org>
Date: Fri Feb 27 15:06:59 2015 -0800
SQOOP-2144: Sqoop2: Show command for CLI
:100644 100644 1016b4d... e540b75... M common/src/main/java/org/apache/sqoop/json/PrincipalBean.java
:100644 100644 02ef4b2... 6819063... M common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java
:100644 100644 e552868... e1f5783... M common/src/main/java/org/apache/sqoop/json/RoleBean.java
:100644 100644 329b4d6... 82c52da... M shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
:000000 100644 0000000... 12b3b9e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java
:000000 100644 0000000... c23959e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java
:000000 100644 0000000... f400ed4... A shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java
:100644 100644 fc8ef42... 8efccdf... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
:100644 100644 750fd59... bc7bba4... M shell/src/main/resources/shell-resource.properties
Diffs
-----
common/src/main/java/org/apache/sqoop/json/PrincipalBean.java 1016b4d
common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java 02ef4b2
common/src/main/java/org/apache/sqoop/json/RoleBean.java e552868
shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java 329b4d6
shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java fc8ef42
shell/src/main/resources/shell-resource.properties 750fd59
Diff: https://reviews.apache.org/r/31569/diff/
Testing
-------
manually verified
Thanks,
Abraham Elmahrek
Re: Review Request 31569: Sqoop2: Show command for CLI
Posted by richard zhou <ri...@intel.com>.
> On Feb. 28, 2015, 2:38 a.m., richard zhou wrote:
> >
LGTM, only 2 comments: the information of principal and privilege is not sufficient.
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31569/#review74652
-----------------------------------------------------------
On Feb. 28, 2015, 1:15 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31569/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 1:15 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2144
> https://issues.apache.org/jira/browse/SQOOP-2144
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 2ba6fdd4d713a65ec6109daec563bd7a5fbc0a19
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Fri Feb 27 15:06:59 2015 -0800
>
> SQOOP-2144: Sqoop2: Show command for CLI
>
> :100644 100644 1016b4d... e540b75... M common/src/main/java/org/apache/sqoop/json/PrincipalBean.java
> :100644 100644 02ef4b2... 6819063... M common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java
> :100644 100644 e552868... e1f5783... M common/src/main/java/org/apache/sqoop/json/RoleBean.java
> :100644 100644 329b4d6... 82c52da... M shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
> :000000 100644 0000000... 12b3b9e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java
> :000000 100644 0000000... c23959e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java
> :000000 100644 0000000... f400ed4... A shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java
> :100644 100644 fc8ef42... 8efccdf... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 750fd59... bc7bba4... M shell/src/main/resources/shell-resource.properties
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/PrincipalBean.java 1016b4d
> common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java 02ef4b2
> common/src/main/java/org/apache/sqoop/json/RoleBean.java e552868
> shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java 329b4d6
> shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java fc8ef42
> shell/src/main/resources/shell-resource.properties 750fd59
>
> Diff: https://reviews.apache.org/r/31569/diff/
>
>
> Testing
> -------
>
> manually verified
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 31569: Sqoop2: Show command for CLI
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31569/#review74652
-----------------------------------------------------------
shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java
<https://reviews.apache.org/r/31569/#comment121301>
Please add principal.getType();
shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java
<https://reviews.apache.org/r/31569/#comment121302>
Please add privilege.isWith_grant_option();
- richard zhou
On Feb. 28, 2015, 1:15 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31569/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 1:15 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2144
> https://issues.apache.org/jira/browse/SQOOP-2144
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 2ba6fdd4d713a65ec6109daec563bd7a5fbc0a19
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Fri Feb 27 15:06:59 2015 -0800
>
> SQOOP-2144: Sqoop2: Show command for CLI
>
> :100644 100644 1016b4d... e540b75... M common/src/main/java/org/apache/sqoop/json/PrincipalBean.java
> :100644 100644 02ef4b2... 6819063... M common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java
> :100644 100644 e552868... e1f5783... M common/src/main/java/org/apache/sqoop/json/RoleBean.java
> :100644 100644 329b4d6... 82c52da... M shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
> :000000 100644 0000000... 12b3b9e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java
> :000000 100644 0000000... c23959e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java
> :000000 100644 0000000... f400ed4... A shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java
> :100644 100644 fc8ef42... 8efccdf... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 750fd59... bc7bba4... M shell/src/main/resources/shell-resource.properties
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/PrincipalBean.java 1016b4d
> common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java 02ef4b2
> common/src/main/java/org/apache/sqoop/json/RoleBean.java e552868
> shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java 329b4d6
> shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java fc8ef42
> shell/src/main/resources/shell-resource.properties 750fd59
>
> Diff: https://reviews.apache.org/r/31569/diff/
>
>
> Testing
> -------
>
> manually verified
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 31569: Sqoop2: Show command for CLI
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31569/#review74655
-----------------------------------------------------------
Ship it!
Ship It!
- richard zhou
On Feb. 28, 2015, 1:15 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31569/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 1:15 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2144
> https://issues.apache.org/jira/browse/SQOOP-2144
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 2ba6fdd4d713a65ec6109daec563bd7a5fbc0a19
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Fri Feb 27 15:06:59 2015 -0800
>
> SQOOP-2144: Sqoop2: Show command for CLI
>
> :100644 100644 1016b4d... e540b75... M common/src/main/java/org/apache/sqoop/json/PrincipalBean.java
> :100644 100644 02ef4b2... 6819063... M common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java
> :100644 100644 e552868... e1f5783... M common/src/main/java/org/apache/sqoop/json/RoleBean.java
> :100644 100644 329b4d6... 82c52da... M shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
> :000000 100644 0000000... 12b3b9e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java
> :000000 100644 0000000... c23959e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java
> :000000 100644 0000000... f400ed4... A shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java
> :100644 100644 fc8ef42... 8efccdf... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 750fd59... bc7bba4... M shell/src/main/resources/shell-resource.properties
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/PrincipalBean.java 1016b4d
> common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java 02ef4b2
> common/src/main/java/org/apache/sqoop/json/RoleBean.java e552868
> shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java 329b4d6
> shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java fc8ef42
> shell/src/main/resources/shell-resource.properties 750fd59
>
> Diff: https://reviews.apache.org/r/31569/diff/
>
>
> Testing
> -------
>
> manually verified
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 31569: Sqoop2: Show command for CLI
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31569/
-----------------------------------------------------------
(Updated Feb. 28, 2015, 11:46 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2144
https://issues.apache.org/jira/browse/SQOOP-2144
Repository: sqoop-sqoop2
Description
-------
commit 2ba6fdd4d713a65ec6109daec563bd7a5fbc0a19
Author: Abraham Elmahrek <ab...@apache.org>
Date: Fri Feb 27 15:06:59 2015 -0800
SQOOP-2144: Sqoop2: Show command for CLI
:100644 100644 1016b4d... e540b75... M common/src/main/java/org/apache/sqoop/json/PrincipalBean.java
:100644 100644 02ef4b2... 6819063... M common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java
:100644 100644 e552868... e1f5783... M common/src/main/java/org/apache/sqoop/json/RoleBean.java
:100644 100644 329b4d6... 82c52da... M shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
:000000 100644 0000000... 12b3b9e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java
:000000 100644 0000000... c23959e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java
:000000 100644 0000000... f400ed4... A shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java
:100644 100644 fc8ef42... 8efccdf... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
:100644 100644 750fd59... bc7bba4... M shell/src/main/resources/shell-resource.properties
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/PrincipalBean.java 1016b4d
common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java 02ef4b2
common/src/main/java/org/apache/sqoop/json/RoleBean.java e552868
shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java 329b4d6
shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java fc8ef42
shell/src/main/resources/shell-resource.properties 750fd59
Diff: https://reviews.apache.org/r/31569/diff/
Testing
-------
manually verified
Thanks,
Abraham Elmahrek
Re: Review Request 31569: Sqoop2: Show command for CLI
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31569/#review74675
-----------------------------------------------------------
Ship it!
Looks good to me, pending incorporating feedback from Richard.
- Jarek Cecho
On Feb. 28, 2015, 1:15 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31569/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 1:15 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2144
> https://issues.apache.org/jira/browse/SQOOP-2144
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 2ba6fdd4d713a65ec6109daec563bd7a5fbc0a19
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Fri Feb 27 15:06:59 2015 -0800
>
> SQOOP-2144: Sqoop2: Show command for CLI
>
> :100644 100644 1016b4d... e540b75... M common/src/main/java/org/apache/sqoop/json/PrincipalBean.java
> :100644 100644 02ef4b2... 6819063... M common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java
> :100644 100644 e552868... e1f5783... M common/src/main/java/org/apache/sqoop/json/RoleBean.java
> :100644 100644 329b4d6... 82c52da... M shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
> :000000 100644 0000000... 12b3b9e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java
> :000000 100644 0000000... c23959e... A shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java
> :000000 100644 0000000... f400ed4... A shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java
> :100644 100644 fc8ef42... 8efccdf... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 750fd59... bc7bba4... M shell/src/main/resources/shell-resource.properties
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/PrincipalBean.java 1016b4d
> common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java 02ef4b2
> common/src/main/java/org/apache/sqoop/json/RoleBean.java e552868
> shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java 329b4d6
> shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java fc8ef42
> shell/src/main/resources/shell-resource.properties 750fd59
>
> Diff: https://reviews.apache.org/r/31569/diff/
>
>
> Testing
> -------
>
> manually verified
>
>
> Thanks,
>
> Abraham Elmahrek
>
>