You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Jan Andersson (JIRA)" <ji...@apache.org> on 2005/03/07 21:54:52 UTC
[jira] Created: (DIRMINA-11) SSL Filter
SSL Filter
----------
Key: DIRMINA-11
URL: http://issues.apache.org/jira/browse/DIRMINA-11
Project: MINA
Type: New Feature
Environment: Request for new feature: SSL filter
Reporter: Jan Andersson
Assigned to: Trustin Lee
Attachments: mina-ssl.zip
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-11) SSL Filter
Posted by "Jan Andersson (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-11?page=comments#action_60474 ]
Jan Andersson commented on DIRMINA-11:
--------------------------------------
Great!
I have found bugs though (not related to your merge):
- Bug in SSLHandler when SSLEngine.unwrap() called multible times
- Bug in SSLHandler.doDecrypt() checking result status
- Now closing session in SSLFilter when SSL session closed in SSLFilter.dataRead()
See attachment (fix1.zip) for updated files.
> SSL Filter
> ----------
>
> Key: DIRMINA-11
> URL: http://issues.apache.org/jira/browse/DIRMINA-11
> Project: MINA
> Type: New Feature
> Environment: Request for new feature: SSL filter
> Reporter: Jan Andersson
> Assignee: Trustin Lee
> Attachments: mina-ssl.zip
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-11) SSL Filter
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-11?page=comments#action_60424 ]
Trustin Lee commented on DIRMINA-11:
------------------------------------
I merged your code into MINA trunk. I changed a little bit:
* The class name changed to org.apache.mina.io.filter.SSLFilter.
* The way to handle exceptions; I fired exceptionCaught event instead of logging it.
* The way to write debug logs; I introduced Debug inner interface.
WDYT?
> SSL Filter
> ----------
>
> Key: DIRMINA-11
> URL: http://issues.apache.org/jira/browse/DIRMINA-11
> Project: MINA
> Type: New Feature
> Environment: Request for new feature: SSL filter
> Reporter: Jan Andersson
> Assignee: Trustin Lee
> Attachments: mina-ssl.zip
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-11) SSL Filter
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-11?page=comments#action_60485 ]
Trustin Lee commented on DIRMINA-11:
------------------------------------
BTW, the changes on SocketAcceptor and DatagramAcceptor is not related with this issue. :)
> SSL Filter
> ----------
>
> Key: DIRMINA-11
> URL: http://issues.apache.org/jira/browse/DIRMINA-11
> Project: MINA
> Type: New Feature
> Environment: Request for new feature: SSL filter
> Reporter: Jan Andersson
> Assignee: Trustin Lee
> Attachments: fix1.zip, mina-ssl.zip
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIRMINA-11) SSL Filter
Posted by "Jan Andersson (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-11?page=history ]
Jan Andersson updated DIRMINA-11:
---------------------------------
Attachment: fix1.zip
Fix for 3 bugs.
> SSL Filter
> ----------
>
> Key: DIRMINA-11
> URL: http://issues.apache.org/jira/browse/DIRMINA-11
> Project: MINA
> Type: New Feature
> Environment: Request for new feature: SSL filter
> Reporter: Jan Andersson
> Assignee: Trustin Lee
> Attachments: fix1.zip, mina-ssl.zip
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DIRMINA-11) SSL Filter
Posted by "Enrique Rodriguez (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-11?page=history ]
Enrique Rodriguez reassigned DIRMINA-11:
----------------------------------------
Assign To: Enrique Rodriguez (was: Trustin Lee)
> SSL Filter
> ----------
>
> Key: DIRMINA-11
> URL: http://issues.apache.org/jira/browse/DIRMINA-11
> Project: MINA
> Type: New Feature
> Environment: Request for new feature: SSL filter
> Reporter: Jan Andersson
> Assignee: Enrique Rodriguez
> Attachments: mina-ssl.zip
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIRMINA-11) SSL Filter
Posted by "Jan Andersson (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-11?page=history ]
Jan Andersson updated DIRMINA-11:
---------------------------------
Attachment: mina-ssl.zip
Attached you find an early version of an SSL filter for Mina. See README for more info.
> SSL Filter
> ----------
>
> Key: DIRMINA-11
> URL: http://issues.apache.org/jira/browse/DIRMINA-11
> Project: MINA
> Type: New Feature
> Environment: Request for new feature: SSL filter
> Reporter: Jan Andersson
> Assignee: Trustin Lee
> Attachments: mina-ssl.zip
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-11) SSL Filter
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-11?page=comments#action_60484 ]
Trustin Lee commented on DIRMINA-11:
------------------------------------
Thanks, and I merged your fixes all.
Additionally, I found more bugs and fixed them. You can see the changes I've made:
http://svn.apache.org/viewcvs?view=rev&rev=156607
> SSL Filter
> ----------
>
> Key: DIRMINA-11
> URL: http://issues.apache.org/jira/browse/DIRMINA-11
> Project: MINA
> Type: New Feature
> Environment: Request for new feature: SSL filter
> Reporter: Jan Andersson
> Assignee: Trustin Lee
> Attachments: fix1.zip, mina-ssl.zip
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-11) SSL Filter
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-11?page=comments#action_60495 ]
Trustin Lee commented on DIRMINA-11:
------------------------------------
I didn't encountered BUFFER_OVERFLOW problem if I just run 'maven test'. But if you launch 'maven console' and run tests multiple times, 160 bytes (ten packets * 16-bytes) are read as one packet and problem arises possibly due to HotSpot optimization.
> SSL Filter
> ----------
>
> Key: DIRMINA-11
> URL: http://issues.apache.org/jira/browse/DIRMINA-11
> Project: MINA
> Type: New Feature
> Environment: Request for new feature: SSL filter
> Reporter: Jan Andersson
> Assignee: Trustin Lee
> Attachments: fix1.zip, mina-ssl.zip
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (DIRMINA-11) SSL Filter
Posted by Enrique Rodriguez <er...@apache.org>.
Alex Karasulu wrote:
> I love seeing two committers wresting for a JIRA issue. That's classic.
No fair! Trustin can code all night!!!
-enrique
>
> Alex
>
> Trustin Lee (JIRA) wrote:
>
>> [ http://issues.apache.org/jira/browse/DIRMINA-11?page=history ]
>>
>> Trustin Lee updated DIRMINA-11:
>> -------------------------------
>>
>> Assign To: Trustin Lee (was: Enrique Rodriguez)
>>
>>
>>
>>> SSL Filter
>>> ----------
>>>
>>> Key: DIRMINA-11
>>> URL: http://issues.apache.org/jira/browse/DIRMINA-11
>>> Project: MINA
>>> Type: New Feature
>>> Environment: Request for new feature: SSL filter
>>> Reporter: Jan Andersson
>>> Assignee: Trustin Lee
>>> Attachments: mina-ssl.zip
>>>
>>>
>>
>>
>>
>>
>>
Re: [jira] Updated: (DIRMINA-11) SSL Filter
Posted by Alex Karasulu <ao...@bellsouth.net>.
I love seeing two committers wresting for a JIRA issue. That's classic.
Alex
Trustin Lee (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DIRMINA-11?page=history ]
>
>Trustin Lee updated DIRMINA-11:
>-------------------------------
>
> Assign To: Trustin Lee (was: Enrique Rodriguez)
>
>
>
>>SSL Filter
>>----------
>>
>> Key: DIRMINA-11
>> URL: http://issues.apache.org/jira/browse/DIRMINA-11
>> Project: MINA
>> Type: New Feature
>> Environment: Request for new feature: SSL filter
>> Reporter: Jan Andersson
>> Assignee: Trustin Lee
>> Attachments: mina-ssl.zip
>>
>>
>>
>
>
>
>
[jira] Updated: (DIRMINA-11) SSL Filter
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-11?page=history ]
Trustin Lee updated DIRMINA-11:
-------------------------------
Assign To: Trustin Lee (was: Enrique Rodriguez)
> SSL Filter
> ----------
>
> Key: DIRMINA-11
> URL: http://issues.apache.org/jira/browse/DIRMINA-11
> Project: MINA
> Type: New Feature
> Environment: Request for new feature: SSL filter
> Reporter: Jan Andersson
> Assignee: Trustin Lee
> Attachments: mina-ssl.zip
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRMINA-11) SSL Filter
Posted by "Jan Andersson (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRMINA-11?page=comments#action_60490 ]
Jan Andersson commented on DIRMINA-11:
--------------------------------------
Great.
The only thing I'm not with you on is the fix in SSLByteBufferPool to double
the size for the application data buffer.
I have not run into BUFFER_OVERFLOW problems myself... Maybe we should
try to handle this in SSLHandler and re-allocate a larger buffer in cases like
this?
I will not have the time to look into this until next week though.
> SSL Filter
> ----------
>
> Key: DIRMINA-11
> URL: http://issues.apache.org/jira/browse/DIRMINA-11
> Project: MINA
> Type: New Feature
> Environment: Request for new feature: SSL filter
> Reporter: Jan Andersson
> Assignee: Trustin Lee
> Attachments: fix1.zip, mina-ssl.zip
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira